From patchwork Fri Jun 3 02:39:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Huang Shijie X-Patchwork-Id: 9151555 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 30DCC6074E for ; Fri, 3 Jun 2016 02:41:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2394D28328 for ; Fri, 3 Jun 2016 02:41:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 182B92832D; Fri, 3 Jun 2016 02:41:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9858E28328 for ; Fri, 3 Jun 2016 02:41:23 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1b8f1u-0003kG-Vt; Fri, 03 Jun 2016 02:40:10 +0000 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1b8f1r-0002Kx-8t for linux-arm-kernel@lists.infradead.org; Fri, 03 Jun 2016 02:40:08 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp0176.outbound.protection.outlook.com [213.199.154.176]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-29-95-eu4QDRru5Zm92HcNvtw-1; Fri, 03 Jun 2016 03:39:42 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vMzq18fUV5bhpws0abNrf93eZmEtUqKsIrcacyKvuUE=; b=NUCpp1s/jUggU8iuULwBobIhNrRh5KNOokdjrNZPV7pMn0EOfCLX4o17EOPPdcHv7Zh5niYAUGOPWbI7gRsl8eCGjU2NrXIBSK70f7/gusXD1yA6EWzN1ljfIxk+I6P737NFy71Eje2mmXcstIyrbQT4ATsj+1S50XXe784ccy8= Received: from sha-win-210.asiapac.arm.com (101.230.208.200) by HE1PR08MB0506.eurprd08.prod.outlook.com (10.161.120.153) with Microsoft SMTP Server (TLS) id 15.1.506.9; Fri, 3 Jun 2016 02:39:33 +0000 Date: Fri, 3 Jun 2016 10:39:07 +0800 From: Huang Shijie To: Will Deacon Subject: Re: [PATCH] arm64: fix the wrong comment Message-ID: <20160603023905.GB23297@sha-win-210.asiapac.arm.com> References: <1464574369-22618-1-git-send-email-shijie.huang@arm.com> <20160602180948.GE7697@arm.com> MIME-Version: 1.0 In-Reply-To: <20160602180948.GE7697@arm.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [101.230.208.200] X-ClientProxiedBy: OS2PR01CA0040.jpnprd01.prod.outlook.com (10.164.161.150) To HE1PR08MB0506.eurprd08.prod.outlook.com (10.161.120.153) X-MS-Office365-Filtering-Correlation-Id: e239a236-3a1b-4929-d195-08d38b584ddc X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB0506; 2:OUWiYB1xupBXaihz5PDTooHXOP05esvZbIBgrmgie5hKXVcH2E+FB4iTV6Ryd5/oysvqKiu/KemH0jDIsllqJoIQd1W9XvzNewL++T0SiTp0grUOK0twGaoc/RYMjnOs00zTJOMHsU/tJz6wMvDmaL1qkHJ5FibvaTrpFpBJPhz13NGz1HePPUFurDQXNs6+; 3:l8M9ASYuy58sZCLMLyv0zTruafkezH+LzYkb4Vyqf4cJCjK9kNOMCIXervXUtKk8I8LfS5VHcTJlpqTeDnLRWpWplWIAehMJ0XAoOS7H7xVNGor4NC150SeuE8X9UoSs; 25:3rXDXmBF8OuiBoZw2uExkIlcYD7qXNjET/hx60Mp0qIySh2NO2elVOr8Vy8D2mUvZo+tiGzjNiolE7Fk/8T87j6rpDjfjHDXq1v8DS7Rq7uKrgsDKYqc8NOvHrZ7I+0JkfcvzvaQ4XyNv/a/WRKrpkLGL1kaC9KfPDI2mvuS20G1v7mURzzx0TSe+yXYEsznEOFfe+UaLk7zqo/Oywl4LEB8spZ+KjaiZeqDgmEMLUwpPI+blUMYhcZQt4pxZgDRXzTTmJtpvTGhtTGQSphxTNqy3tHrhlroG1dbgRp5gSvoE4YCO+zmNfGrP4StAXzrbaCAemIXDGnXTySkpM0Oop0FK9gQfWrj2J4Mfvj0I+cUMqK/bLwMm6aS+q4z/8yLhg3xnjWyIx2fhr+jAgqQk1YWOFZ1ylnfxozhQaWFTvI=; 20:3cmCwstHWc3Zpk8ooPvjbegd63o3O8b0lfkG982sevh+NtMaHGdv43tPKvYTTSdMwo42IJVYaOTyQ9wJGA4/D84rqA2yuRk63JNrkGPSW7Pxdk7Kdx/S64OJsQVfygfuOjMyiLPDAwwOqkBvF0dW/tn5e+4ZWbIxn9/0PathZ+0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR08MB0506; NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026); SRVR:HE1PR08MB0506; BCL:0; PCL:0; RULEID:; SRVR:HE1PR08MB0506; X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB0506; 4:hOpFAuO3H2s/f0z1xWSDs4Tvmq/RNm055XsNyDsIQSm8RKvGIpsIoD5kUiNbf2ZR0Hui7vr1r/3tanitm1ZHpl78pHFnlaKfiRfG23kmMAJf3I6Kx6ga8Bwpmcb5iRFCcAaM7/AUw7W0/F2I0EhSo0/96RG1V8FwrIz6rZ7ph/H4oWBd5PtPyMvrKDlsNSeBaMtkiIIhDphoFrBb1h/RZel53kgjvy/iB26AGbY9/5JFMpYEwWcfR9ty86WQt6JAzPHBslDZ3WthA/M4i0ofVPQ6vWznzOMtKlNvzjB7pvq8JuA2YFflzt+STxjqjwWpkRIuwvzU1BS8t1uBWOvzoOS950EAGVQIVvv2d1gXlyizQ9KBQFgynjiDDbZoIzEthYtmGdF9jBSsL1sb68dadnu9PdJJd/z6K4/YYekXTqJAxDXZfp8x1THviLzFJeSg X-Forefront-PRVS: 0962D394D2 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(24454002)(450100001)(47776003)(5004730100002)(83506001)(50466002)(66066001)(4326007)(42186005)(2950100001)(97756001)(46406003)(4001350100001)(33656002)(2906002)(81166006)(5008740100001)(50986999)(54356999)(76176999)(19580395003)(19580405001)(92566002)(8676002)(23726003)(110136002)(1076002)(189998001)(586003)(575784001)(3846002)(86362001)(77096005)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR08MB0506; H:sha-win-210.asiapac.arm.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR08MB0506; 23:JtlQZim1PrgrzZVQeoPOap6MFG86G+xviy0FSMA2r?= =?us-ascii?Q?ZIPdCmcIwbAYtBYWpOPrdBnrkc32VJyqNmmgb0rMJ9x3WBLRQYC7OhZFvdJv?= =?us-ascii?Q?5JLQxnby0YmnOrHB37fblbwvJrKQWqEG62Kq5rdy1NW8JE+IZqw5bfyIk5GE?= =?us-ascii?Q?RZt9UdbGXCkYXZzdKSnIqEr9EXLVvdGD23sUTgFazs93hTs+fj8x2NdL/1gw?= =?us-ascii?Q?yj1c/Bu6I4pUggvnUOx6fV/NxwjSCrqQckp8RhYf4MurNcMbfXSkGMcg/6It?= =?us-ascii?Q?z4xvTi6o1okN1QFO08B1OVMZSz5rJLY//JZLuaGT1rBHenGh+uU9BNTCvEbw?= =?us-ascii?Q?2YznUK/un/WBVBt/B7sk2GvTkyaKH0frbp5ahpKhIP7S+DLnIhhWmNxMiYIE?= =?us-ascii?Q?2AFI4f6PpocPFlh7mGVTROk0jtSYpP0LE7SOjXO9p3n4Xw7Aoc4wK2q7jYQr?= =?us-ascii?Q?DXK1VK6vCVGYr8cb1n3dhaDLmEllYqYvZyjT8Difk4muN4yjwZfBET4rQBHt?= =?us-ascii?Q?4UAtjLC/pDHvt2kEJtadNpWgoyTnKfXwpgCfozWXe5/2mTFP1FFBAAXOZFPX?= =?us-ascii?Q?ROUdMEz5TzmZbbif6n2BgBBsUjCz0j1r5PC+t7OIQkMU7qoWYiSvTn3Rvc4Z?= =?us-ascii?Q?sl2HhTSFfIKNUTOfAfqX7OoU4PSTBeG7jPpiMae0Q0mYgKuuwjpxrvJ37OqP?= =?us-ascii?Q?nn+Zt1PnmoPGQ2k0JqGAGeyokBSZJ0FM3B7Z88zU+BrEvYq7DtErGz+r0Tb/?= =?us-ascii?Q?1aGFvTG53mOHyWE0I0tShpMjWbvWbxywQTzTNFUtBCVVC9tT5zZf9Q556owS?= =?us-ascii?Q?Vga1EggZ5EFc59vkeahajqv4tdTxtmlT/rlO+wRPCk3t8g1cnYQ7RkRXkcm5?= =?us-ascii?Q?RgucpacXybjbUTItm67HD5LmBryj3T25ThJ2EDeCDIHQb/EcJD1/1Eczf8Aa?= =?us-ascii?Q?kPS5VeVTMIO+A0h52ojHlIh8995ivflH0V6YN4ivszfrazVtGVZIwA8mKRfS?= =?us-ascii?Q?uA=3D?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB0506; 5:vkzZnpKgP21xBgPmO+bGaHHxaEw0vjOsu9zblY1SjaaNW5/ZbIX/gOntMqMLZ9sVi3eMeVpGzBBL7OlDWB6RxiNsKK8PYdgnrmd1asRhNYEcpW2rFSX7SzfdNrMunZWCXusPkFuKSVbT7te+HM81nA==; 24:dzz03csq3tg63TprTwjXBU9lYG5WW/oYrPUarAs2EWotw9XStaDEHVT6g1ZO/3tSIyrz4D3bRv1HeaIYHrysXQddHnLnrJM0jhbyU6cmJPk=; 7:TUeHIp4zY8RAZOcI31XpoBkZbnzCfHRBOGVep818BMDTTag4EnSe6dXT6+giH8HBDFS4yh0D5yETZ6l9177qDQjPt56s5qk1UCle3rha7O0y84BCWaMgGiazyP9MY1xCMz7t67im5p8Ocyr18uhS3sRu8+YK/8SgCD9DE0BiVenD/kKFr3VeUuuSksJbiXmyaUfDkwe3ghSSNKou5JFq31B0OAG/Br3Otg+UmS9JLbU=; 20:smtjfWobbhjEJx8ws2WY1Hwb5nFXKD6kAB0cz1Efq6SkyzTj+hJmiDirwXmUCYFVrgv3spzepF8oE3nMB50ifpLVJz77R+iUJggNz4z49ZJarufgurdjFQEUgTnZ+8ePkzcd4CivEL06utQMbDRt/Ry27NoJvzbBCBbYHE2mjZw= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2016 02:39:33.6728 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB0506 X-MC-Unique: 95-eu4QDRru5Zm92HcNvtw-1 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160602_194007_643581_9EAF15D1 X-CRM114-Status: GOOD ( 12.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, catalin.marinas@arm.com, nd@arm.com, linux-arm-kernel@lists.infradead.org, steve.capper@arm.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Jun 02, 2016 at 07:09:48PM +0100, Will Deacon wrote: > On Mon, May 30, 2016 at 10:12:49AM +0800, Huang Shijie wrote: > > Currently, we use the 48-bit for the kernel and user by default. > > The comment becomes stale. This patch fixes the wrong comment. > > > > Signed-off-by: Huang Shijie > > --- > > arch/arm64/mm/proc.S | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S > > index c431787..421386759 100644 > > --- a/arch/arm64/mm/proc.S > > +++ b/arch/arm64/mm/proc.S > > @@ -209,8 +209,8 @@ ENTRY(__cpu_setup) > > bic x0, x0, x5 // clear bits > > orr x0, x0, x6 // set bits > > /* > > - * Set/prepare TCR and TTBR. We use 512GB (39-bit) address range for > > - * both user and kernel. > > + * Set/prepare TCR. We use VA_BITS of address range for both > > + * kernel and user. > > */ > > To be honest, all three of these comments (including the two in the > context) are totally useless. Can we just remove them instead? Do you mean we could remove the comments like this: --- arch/arm64/mm/proc.S | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S index c431787..286d016 100644 --- a/arch/arm64/mm/proc.S +++ b/arch/arm64/mm/proc.S @@ -208,10 +208,7 @@ ENTRY(__cpu_setup) mrs x0, sctlr_el1 bic x0, x0, x5 // clear bits orr x0, x0, x6 // set bits - /* - * Set/prepare TCR and TTBR. We use 512GB (39-bit) address range for - * both user and kernel. - */ + ldr x10, =TCR_TxSZ(VA_BITS) | TCR_CACHE_FLAGS | TCR_SMP_FLAGS | \ TCR_TG_FLAGS | TCR_ASID16 | TCR_TBI0 tcr_set_idmap_t0sz x10, x9