diff mbox

ARM: dts: imx6sx: Add GPU bindings

Message ID 20160826142254.6950-1-marex@denx.de (mailing list archive)
State New, archived
Headers show

Commit Message

Marek Vasut Aug. 26, 2016, 2:22 p.m. UTC
Add bindings for the Vivante GC400T GPU found in the i.MX6SX .

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>
---
 arch/arm/boot/dts/imx6sx.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Lucas Stach Aug. 26, 2016, 2:36 p.m. UTC | #1
Am Freitag, den 26.08.2016, 16:22 +0200 schrieb Marek Vasut:
> Add bindings for the Vivante GC400T GPU found in the i.MX6SX .
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

> ---
>  arch/arm/boot/dts/imx6sx.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 6a993bfda..901c2d2 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -1250,6 +1250,16 @@
>  			};
>  		};
>  
> +		gpu: gpu@01800000 {
> +			compatible = "vivante,gc";
> +			reg = <0x01800000 0x4000>;
> +			interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&clks IMX6SX_CLK_GPU>,
> +				 <&clks IMX6SX_CLK_GPU>,
> +				 <&clks IMX6SX_CLK_GPU>;
> +			clock-names = "bus", "core", "shader";
> +		};
> +
>  		pcie: pcie@0x08000000 {
>  			compatible = "fsl,imx6sx-pcie", "snps,dw-pcie";
>  			reg = <0x08ffc000 0x4000>; /* DBI */
> @@ -1273,4 +1283,9 @@
>  			status = "disabled";
>  		};
>  	};
> +
> +	gpu-subsystem {
> +		compatible = "fsl,imx-gpu-subsystem";
> +		cores = <&gpu>;
> +	};
>  };
Shawn Guo Aug. 29, 2016, 1:41 p.m. UTC | #2
On Fri, Aug 26, 2016 at 04:22:54PM +0200, Marek Vasut wrote:
> Add bindings for the Vivante GC400T GPU found in the i.MX6SX .
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> ---
>  arch/arm/boot/dts/imx6sx.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 6a993bfda..901c2d2 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -1250,6 +1250,16 @@
>  			};
>  		};
>  
> +		gpu: gpu@01800000 {

Wrong place for the node.  It should go right before dma-apbh@01804000.
I fixed it up and applied patch.

Shawn

> +			compatible = "vivante,gc";
> +			reg = <0x01800000 0x4000>;
> +			interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&clks IMX6SX_CLK_GPU>,
> +				 <&clks IMX6SX_CLK_GPU>,
> +				 <&clks IMX6SX_CLK_GPU>;
> +			clock-names = "bus", "core", "shader";
> +		};
> +
>  		pcie: pcie@0x08000000 {
>  			compatible = "fsl,imx6sx-pcie", "snps,dw-pcie";
>  			reg = <0x08ffc000 0x4000>; /* DBI */
> @@ -1273,4 +1283,9 @@
>  			status = "disabled";
>  		};
>  	};
> +
> +	gpu-subsystem {
> +		compatible = "fsl,imx-gpu-subsystem";
> +		cores = <&gpu>;
> +	};
>  };
> -- 
> 2.9.3
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Marek Vasut Aug. 29, 2016, 1:45 p.m. UTC | #3
On 08/29/2016 03:41 PM, Shawn Guo wrote:
> On Fri, Aug 26, 2016 at 04:22:54PM +0200, Marek Vasut wrote:
>> Add bindings for the Vivante GC400T GPU found in the i.MX6SX .
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Lucas Stach <l.stach@pengutronix.de>
>> Cc: Fabio Estevam <fabio.estevam@nxp.com>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> ---
>>  arch/arm/boot/dts/imx6sx.dtsi | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
>> index 6a993bfda..901c2d2 100644
>> --- a/arch/arm/boot/dts/imx6sx.dtsi
>> +++ b/arch/arm/boot/dts/imx6sx.dtsi
>> @@ -1250,6 +1250,16 @@
>>  			};
>>  		};
>>  
>> +		gpu: gpu@01800000 {
> 
> Wrong place for the node.  It should go right before dma-apbh@01804000.
> I fixed it up and applied patch.

Thanks!

> Shawn

[..]
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
index 6a993bfda..901c2d2 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/arm/boot/dts/imx6sx.dtsi
@@ -1250,6 +1250,16 @@ 
 			};
 		};
 
+		gpu: gpu@01800000 {
+			compatible = "vivante,gc";
+			reg = <0x01800000 0x4000>;
+			interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clks IMX6SX_CLK_GPU>,
+				 <&clks IMX6SX_CLK_GPU>,
+				 <&clks IMX6SX_CLK_GPU>;
+			clock-names = "bus", "core", "shader";
+		};
+
 		pcie: pcie@0x08000000 {
 			compatible = "fsl,imx6sx-pcie", "snps,dw-pcie";
 			reg = <0x08ffc000 0x4000>; /* DBI */
@@ -1273,4 +1283,9 @@ 
 			status = "disabled";
 		};
 	};
+
+	gpu-subsystem {
+		compatible = "fsl,imx-gpu-subsystem";
+		cores = <&gpu>;
+	};
 };