diff mbox

[RFC,7/7] Make Hi3620 explicit, remove wildcards

Message ID 20160908172346.27506-7-netz.kernel@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Marty Plummer Sept. 8, 2016, 5:23 p.m. UTC
This is a preparatory series for adding the ARMv5/v6 hi3520 SoCs.
Assumptions were made when adding hi3620 that don't hold water in
light of adding support for the hi3520 SoC.  Fix the issue by renaming
config options and other namespaces to avoid collisions with the new
work.

Only internal APIs are modified with this series.

Signed-off-by: Marty Plummer <netz.kernel@gmail.com>
---
 drivers/dma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jason Cooper Sept. 8, 2016, 5:54 p.m. UTC | #1
On Thu, Sep 08, 2016 at 12:23:46PM -0500, Marty Plummer wrote:
> This is a preparatory series for adding the ARMv5/v6 hi3520 SoCs.
> Assumptions were made when adding hi3620 that don't hold water in
> light of adding support for the hi3520 SoC.  Fix the issue by renaming
> config options and other namespaces to avoid collisions with the new
> work.
> 
> Only internal APIs are modified with this series.
> 
> Signed-off-by: Marty Plummer <netz.kernel@gmail.com>
> ---
>  drivers/dma/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This doesn't have to do with DMA, but it's last in the series, so...

I saw on IRC that you have the serial port, vic, and clock at some
initial stage of working for your board, congrats!

I would add those patches to the end of this series implementing that
basic functionality.  That makes it very clear to everyone *why* the
previous patches are necessary.

thx,

Jason.
Marty Plummer Sept. 8, 2016, 6:04 p.m. UTC | #2
On 09/08/2016 12:54 PM, Jason Cooper wrote:
> On Thu, Sep 08, 2016 at 12:23:46PM -0500, Marty Plummer wrote:
>> This is a preparatory series for adding the ARMv5/v6 hi3520 SoCs.
>> Assumptions were made when adding hi3620 that don't hold water in
>> light of adding support for the hi3520 SoC.  Fix the issue by renaming
>> config options and other namespaces to avoid collisions with the new
>> work.
>>
>> Only internal APIs are modified with this series.
>>
>> Signed-off-by: Marty Plummer <netz.kernel@gmail.com>
>> ---
>>  drivers/dma/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This doesn't have to do with DMA, but it's last in the series, so...
> 
> I saw on IRC that you have the serial port, vic, and clock at some
> initial stage of working for your board, congrats!
> 
Yep! Also got usb going (well, I have to manually modprobe the modules,
but it does work). Thanks a lot!
> I would add those patches to the end of this series implementing that
> basic functionality.  That makes it very clear to everyone *why* the
> previous patches are necessary.
I suppose so, I was just trying to keep changes as modular as possible,
but if you think that's a good idea, I'll roll with it.
> 
> thx,
> 
> Jason.
>
diff mbox

Patch

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 739f797..74bab9d0 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -279,7 +279,7 @@  config INTEL_MIC_X100_DMA
 
 config K3_DMA
 	tristate "Hisilicon K3 DMA support"
-	depends on ARCH_HI3xxx
+	depends on ARCH_HI3620
 	select DMA_ENGINE
 	select DMA_VIRTUAL_CHANNELS
 	help