| Message ID | 20160916145936.3297-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Sep 16, 2016 at 04:59:36PM +0200, Hans de Goede wrote: > Export musb_root_disconnect for use in modules, so that musb glue > code build as module can use it. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/usb/musb/musb_virthub.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/musb/musb_virthub.c b/drivers/usb/musb/musb_virthub.c > index fe08e77..61b5f1c 100644 > --- a/drivers/usb/musb/musb_virthub.c > +++ b/drivers/usb/musb/musb_virthub.c > @@ -245,6 +245,7 @@ void musb_root_disconnect(struct musb *musb) > usb_otg_state_string(musb->xceiv->otg->state)); > } > } > +EXPORT_SYMBOL_GPL(musb_root_disconnect); > > > /*---------------------------------------------------------------------*/ Does this fix a build error somehow? Who reported it?
On Fri, Sep 16, 2016 at 05:47:01PM +0200, Greg Kroah-Hartman wrote: > On Fri, Sep 16, 2016 at 04:59:36PM +0200, Hans de Goede wrote: > > +EXPORT_SYMBOL_GPL(musb_root_disconnect); > Does this fix a build error somehow? Who reported it? Yes, the sunxi driver uses this symbol and the build bots reported it yesterday.
On Fri, Sep 16, 2016 at 04:53:17PM +0100, Mark Brown wrote: > On Fri, Sep 16, 2016 at 05:47:01PM +0200, Greg Kroah-Hartman wrote: > > On Fri, Sep 16, 2016 at 04:59:36PM +0200, Hans de Goede wrote: > > > > +EXPORT_SYMBOL_GPL(musb_root_disconnect); > > > Does this fix a build error somehow? Who reported it? > > Yes, the sunxi driver uses this symbol and the build bots reported it > yesterday. then all of that should have been in this patch :( So much for me trying to be subtle...
Hi, On 16-09-16 17:56, Greg Kroah-Hartman wrote: > On Fri, Sep 16, 2016 at 04:53:17PM +0100, Mark Brown wrote: >> On Fri, Sep 16, 2016 at 05:47:01PM +0200, Greg Kroah-Hartman wrote: >>> On Fri, Sep 16, 2016 at 04:59:36PM +0200, Hans de Goede wrote: >> >>>> +EXPORT_SYMBOL_GPL(musb_root_disconnect); >> >>> Does this fix a build error somehow? Who reported it? >> >> Yes, the sunxi driver uses this symbol and the build bots reported it >> yesterday. > > then all of that should have been in this patch :( > > So much for me trying to be subtle... Sorry, you're right, I'll add a Fixes tag, and I'll mention this fixes a buildbot reported error too. I'll do a v2 with this right away. For the next time, is there any official format to mention the buildbot report or some such ? Regards, Hans
On Sat, Sep 17, 2016 at 12:12:04PM +0200, Hans de Goede wrote: > Hi, > > On 16-09-16 17:56, Greg Kroah-Hartman wrote: > > On Fri, Sep 16, 2016 at 04:53:17PM +0100, Mark Brown wrote: > > > On Fri, Sep 16, 2016 at 05:47:01PM +0200, Greg Kroah-Hartman wrote: > > > > On Fri, Sep 16, 2016 at 04:59:36PM +0200, Hans de Goede wrote: > > > > > > > > +EXPORT_SYMBOL_GPL(musb_root_disconnect); > > > > > > > Does this fix a build error somehow? Who reported it? > > > > > > Yes, the sunxi driver uses this symbol and the build bots reported it > > > yesterday. > > > > then all of that should have been in this patch :( > > > > So much for me trying to be subtle... > > Sorry, you're right, I'll add a Fixes tag, and I'll mention > this fixes a buildbot reported error too. > > I'll do a v2 with this right away. > > For the next time, is there any official format to > mention the buildbot report or some such ? like normal: "Reported-by: ...."
diff --git a/drivers/usb/musb/musb_virthub.c b/drivers/usb/musb/musb_virthub.c index fe08e77..61b5f1c 100644 --- a/drivers/usb/musb/musb_virthub.c +++ b/drivers/usb/musb/musb_virthub.c @@ -245,6 +245,7 @@ void musb_root_disconnect(struct musb *musb) usb_otg_state_string(musb->xceiv->otg->state)); } } +EXPORT_SYMBOL_GPL(musb_root_disconnect); /*---------------------------------------------------------------------*/
Export musb_root_disconnect for use in modules, so that musb glue code build as module can use it. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/usb/musb/musb_virthub.c | 1 + 1 file changed, 1 insertion(+)