From patchwork Tue Sep 20 12:15:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ladislav Michl X-Patchwork-Id: 9341557 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7D64B601C2 for ; Tue, 20 Sep 2016 12:17:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6D90629634 for ; Tue, 20 Sep 2016 12:17:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6204D2963D; Tue, 20 Sep 2016 12:17:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 39C3829634 for ; Tue, 20 Sep 2016 12:17:33 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bmJxw-000634-K5; Tue, 20 Sep 2016 12:16:00 +0000 Received: from eddie.linux-mips.org ([148.251.95.138] helo=cvs.linux-mips.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bmJxr-0005yz-4x for linux-arm-kernel@lists.infradead.org; Tue, 20 Sep 2016 12:15:56 +0000 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23992800AbcITMP2Un0C6 (ORCPT ); Tue, 20 Sep 2016 14:15:28 +0200 Date: Tue, 20 Sep 2016 14:15:21 +0200 From: Ladislav Michl To: Tony Lindgren Subject: Re: [PATCH] ARM: dts: Add power button support for igepv5 Message-ID: <20160920121521.GA32519@localhost.localdomain> References: <20160909210729.20184-1-tony@atomide.com> <31409234-3185-5348-2d37-effb7769c92a@osg.samsung.com> <20160919230826.aubqvj2km4wg6gz7@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160919230826.aubqvj2km4wg6gz7@atomide.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160920_051555_563015_3FFCB9DC X-CRM114-Status: GOOD ( 14.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pau Pajuel , Enric Balletbo Serra , =?iso-8859-2?Q?Agust=ED?= Fontquerni i Gorchs , Javier Martinez Canillas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Sep 19, 2016 at 04:08:26PM -0700, Tony Lindgren wrote: > * Pau Pajuel [160919 01:13]: > > Hello Tony, > > > > 2016-09-14 3:26 GMT+02:00 Javier Martinez Canillas : > > > Hello Tony, > > > > > > On 09/09/2016 05:07 PM, Tony Lindgren wrote: > > >> Add power button support for igepv5. > > >> > > >> Cc: Agustí Fontquerni i Gorchs > > >> Cc: Enric Balletbo Serra > > >> Cc: Javier Martinez Canillas > > >> Cc: Pau Pajuel > > >> Signed-off-by: Tony Lindgren > > >> --- > > > > > > I don't have a schematics for this board, but the patch looks good to me. > > Patch has an errata. Power button is GPIO_ACTIVE_LOW instead GPIO_ACTIVE_HIGH. > > Oops sorry about that, here's an incremental fix. And here's another nitpick ;-) 8< ----------------------- >From 209f676512b5265ab4e9b4efa5a44c281ec2fc71 Mon Sep 17 00:00:00 2001 From: Ladislav Michl Date: Tue, 20 Sep 2016 14:09:03 +0200 Subject: [PATCH 2/2] ARM: omap5-igep0050.dts: Use tabs for indentation Cc: Agustí Fontquerni i Gorchs Cc: Enric Balletbo Serra Cc: Javier Martinez Canillas Cc: Pau Pajuel Fixes: b118c6a6ffa1 ("ARM: dts: Add power button support for igepv5") Signed-off-by: Ladislav Michl --- arch/arm/boot/dts/omap5-igep0050.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts index 139c8f7..44be08a 100644 --- a/arch/arm/boot/dts/omap5-igep0050.dts +++ b/arch/arm/boot/dts/omap5-igep0050.dts @@ -20,7 +20,7 @@ }; gpio_keys { - compatible = "gpio-keys"; + compatible = "gpio-keys"; pinctrl-0 = <&power_button_pin>; pinctrl-names = "default";