| Message ID | 20161014130033.14172-5-lokeshvutla@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Oct 14, 2016 at 06:30:28PM +0530, Lokesh Vutla wrote: > In order to have a proper topology of regulators for a platform, each > registering regulator needs to populate supply_name field for identifying > its supply's name. Add supply_name field for lp873x regulators. > > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Keerthy <j-keerthy@ti.com> > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > --- > Documentation/devicetree/bindings/mfd/lp873x.txt | 8 ++++++++ > drivers/regulator/lp873x-regulator.c | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/lp873x.txt b/Documentation/devicetree/bindings/mfd/lp873x.txt > index 52766c2..936cba3 100644 > --- a/Documentation/devicetree/bindings/mfd/lp873x.txt > +++ b/Documentation/devicetree/bindings/mfd/lp873x.txt > @@ -7,6 +7,9 @@ Required properties: > - #gpio-cells: Should be two. The first cell is the pin number and > the second cell is used to specify flags. > See ../gpio/gpio.txt for more information. > + - xxx-supply: Phandle to parent supply node of each regulator > + populated under regulators node. xxx should match > + the supply_name populated in driver. xxx-in-supply? > - regulators: List of child nodes that specify the regulator > initialization data. > Example: > @@ -17,6 +20,11 @@ pmic: lp8733@60 { > gpio-controller; > #gpio-cells = <2>; > > + buck0-in-supply = <&vsys_3v3>; > + buck1-in-supply = <&vsys_3v3>; > + ldo0-in-supply = <&vsys_3v3>; > + ldo1-in-supply = <&vsys_3v3>; > + > regulators { > lp8733_buck0: buck0 { > regulator-name = "lp8733-buck0";
On Tuesday 18 October 2016 07:57 PM, Rob Herring wrote: > On Fri, Oct 14, 2016 at 06:30:28PM +0530, Lokesh Vutla wrote: >> In order to have a proper topology of regulators for a platform, each >> registering regulator needs to populate supply_name field for identifying >> its supply's name. Add supply_name field for lp873x regulators. >> >> Cc: Lee Jones <lee.jones@linaro.org> >> Cc: Keerthy <j-keerthy@ti.com> >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> >> --- >> Documentation/devicetree/bindings/mfd/lp873x.txt | 8 ++++++++ >> drivers/regulator/lp873x-regulator.c | 1 + >> 2 files changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/lp873x.txt b/Documentation/devicetree/bindings/mfd/lp873x.txt >> index 52766c2..936cba3 100644 >> --- a/Documentation/devicetree/bindings/mfd/lp873x.txt >> +++ b/Documentation/devicetree/bindings/mfd/lp873x.txt >> @@ -7,6 +7,9 @@ Required properties: >> - #gpio-cells: Should be two. The first cell is the pin number and >> the second cell is used to specify flags. >> See ../gpio/gpio.txt for more information. >> + - xxx-supply: Phandle to parent supply node of each regulator >> + populated under regulators node. xxx should match >> + the supply_name populated in driver. > > xxx-in-supply? Oops. Right. Ill update it and repost. Thanks and regards, Lokesh
diff --git a/Documentation/devicetree/bindings/mfd/lp873x.txt b/Documentation/devicetree/bindings/mfd/lp873x.txt index 52766c2..936cba3 100644 --- a/Documentation/devicetree/bindings/mfd/lp873x.txt +++ b/Documentation/devicetree/bindings/mfd/lp873x.txt @@ -7,6 +7,9 @@ Required properties: - #gpio-cells: Should be two. The first cell is the pin number and the second cell is used to specify flags. See ../gpio/gpio.txt for more information. + - xxx-supply: Phandle to parent supply node of each regulator + populated under regulators node. xxx should match + the supply_name populated in driver. - regulators: List of child nodes that specify the regulator initialization data. Example: @@ -17,6 +20,11 @@ pmic: lp8733@60 { gpio-controller; #gpio-cells = <2>; + buck0-in-supply = <&vsys_3v3>; + buck1-in-supply = <&vsys_3v3>; + ldo0-in-supply = <&vsys_3v3>; + ldo1-in-supply = <&vsys_3v3>; + regulators { lp8733_buck0: buck0 { regulator-name = "lp8733-buck0"; diff --git a/drivers/regulator/lp873x-regulator.c b/drivers/regulator/lp873x-regulator.c index e504b91..70e3df6 100644 --- a/drivers/regulator/lp873x-regulator.c +++ b/drivers/regulator/lp873x-regulator.c @@ -24,6 +24,7 @@ [_id] = { \ .desc = { \ .name = _name, \ + .supply_name = _of "-in", \ .id = _id, \ .of_match = of_match_ptr(_of), \ .regulators_node = of_match_ptr("regulators"),\
In order to have a proper topology of regulators for a platform, each registering regulator needs to populate supply_name field for identifying its supply's name. Add supply_name field for lp873x regulators. Cc: Lee Jones <lee.jones@linaro.org> Cc: Keerthy <j-keerthy@ti.com> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> --- Documentation/devicetree/bindings/mfd/lp873x.txt | 8 ++++++++ drivers/regulator/lp873x-regulator.c | 1 + 2 files changed, 9 insertions(+)