diff mbox

[1/3] ARM: socfpga: dtsi: add qspi node

Message ID 20161018074304.6744-1-s.trumtrar@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Steffen Trumtrar Oct. 18, 2016, 7:43 a.m. UTC
Add the qspi node to the socfpga dtsi file.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 arch/arm/boot/dts/socfpga.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

dinguyen@opensource.altera.com Oct. 19, 2016, 3:55 p.m. UTC | #1
On Tue, 18 Oct 2016, Steffen Trumtrar wrote:

> Add the qspi node to the socfpga dtsi file.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  arch/arm/boot/dts/socfpga.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 9f48141270b8..0dc96d2248a6 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -705,6 +705,20 @@
>  			reg = <0xffff0000 0x10000>;
>  		};
>  
> +		qspi: spi@ff705000 {
> +			compatible = "cdns,qspi-nor";
> +                        #address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0xff705000 0x1000>,
> +			      <0xffa00000 0x1000>;

I think the QSPI data address space has a length of 0x100000. I've fixed it up locally.

BR,
Dinh
Steffen Trumtrar Oct. 20, 2016, 6:42 a.m. UTC | #2
On Wed, Oct 19, 2016 at 10:55:46AM -0500, Dinh Nguyen wrote:
> On Tue, 18 Oct 2016, Steffen Trumtrar wrote:
> 
> > Add the qspi node to the socfpga dtsi file.
> > 
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/socfpga.dtsi | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> > index 9f48141270b8..0dc96d2248a6 100644
> > --- a/arch/arm/boot/dts/socfpga.dtsi
> > +++ b/arch/arm/boot/dts/socfpga.dtsi
> > @@ -705,6 +705,20 @@
> >  			reg = <0xffff0000 0x10000>;
> >  		};
> >  
> > +		qspi: spi@ff705000 {
> > +			compatible = "cdns,qspi-nor";
> > +                        #address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <0xff705000 0x1000>,
> > +			      <0xffa00000 0x1000>;
> 
> I think the QSPI data address space has a length of 0x100000. I've fixed it up locally.
> 

Yeah, you are right. Good catch.

Thanks,
Steffen
diff mbox

Patch

diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
index 9f48141270b8..0dc96d2248a6 100644
--- a/arch/arm/boot/dts/socfpga.dtsi
+++ b/arch/arm/boot/dts/socfpga.dtsi
@@ -705,6 +705,20 @@ 
 			reg = <0xffff0000 0x10000>;
 		};
 
+		qspi: spi@ff705000 {
+			compatible = "cdns,qspi-nor";
+                        #address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0xff705000 0x1000>,
+			      <0xffa00000 0x1000>;
+			interrupts = <0 151 4>;
+			cdns,fifo-depth = <128>;
+			cdns,fifo-width = <4>;
+			cdns,trigger-address = <0x00000000>;
+			clocks = <&qspi_clk>;
+			status = "disabled";
+		};
+
 		rst: rstmgr@ffd05000 {
 			#reset-cells = <1>;
 			compatible = "altr,rst-mgr";