From patchwork Fri Oct 21 15:03:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 9389461 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E1DFB607F0 for ; Fri, 21 Oct 2016 15:06:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D2DF52A276 for ; Fri, 21 Oct 2016 15:06:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C755A2A27A; Fri, 21 Oct 2016 15:06:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5E0B12A276 for ; Fri, 21 Oct 2016 15:06:03 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bxbN1-0005y0-QT; Fri, 21 Oct 2016 15:04:31 +0000 Received: from mail.kernel.org ([198.145.29.136]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bxbMt-0005u5-Sz for linux-arm-kernel@lists.infradead.org; Fri, 21 Oct 2016 15:04:27 +0000 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 62C0220414; Fri, 21 Oct 2016 15:04:02 +0000 (UTC) Received: from tiger (unknown [180.106.218.2]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 88D6320412; Fri, 21 Oct 2016 15:03:58 +0000 (UTC) Date: Fri, 21 Oct 2016 23:03:36 +0800 From: Shawn Guo To: Stefan Wahren Subject: Re: [PATCH 0/4] ARM: boot: mxs: Add On-Chip RAM Message-ID: <20161021150336.GJ30578@tiger> References: <1473789066-8955-1-git-send-email-stefan.wahren@i2se.com> <20161021135343.GI30578@tiger> <9bf7c925-bdc2-d0b8-9886-70d46383d1e0@i2se.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9bf7c925-bdc2-d0b8-9886-70d46383d1e0@i2se.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161021_080424_015917_AD5B1854 X-CRM114-Status: GOOD ( 22.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Marek Vasut , Arnd Bergmann , devicetree@vger.kernel.org, =?iso-8859-1?Q?J=F6rg?= Krause , Rob Herring , Sascha Hauer , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lothar =?iso-8859-1?Q?Wa=DFmann?= Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Oct 21, 2016 at 04:05:59PM +0200, Stefan Wahren wrote: > Am 21.10.2016 um 15:53 schrieb Shawn Guo: > > On Tue, Sep 13, 2016 at 05:51:02PM +0000, Stefan Wahren wrote: > >> The i.MX23 / i.MX28 have a small amount of On-Chip RAM which is also necessary > >> for suspend to RAM and standby mode. But before we need to remove the fake reg > >> properties of all internal bus nodes as discussed in this thread [1]. > >> > >> This patch series requires Fabio Estevam's recent series "ARM: dts: imx23: > >> Remove skeleton.dtsi inclusion" [2]. > >> > >> [1] - https://marc.info/?l=devicetree&m=146139948426520&w=2 > > The page cannot be reached. I would like to understand the > > background for this change. > > Strange, because i don't have any problems while clicking on the URL. > > It's an older discussion on the devicetree / kernel newbie mailing list > with subject "strange dtc errors after adding sram node". Arnd suggested > in the discussion to remove the reg property from the ahb node. > > Please try this one: http://www.spinics.net/lists/newbies/msg57652.html If you go through 'Table 4-1. Address Map for i.MX28' of MCIMX28RM, you should be able to find there are 3 AHB buses: ahb@0, ahb@80080000 and ahb@c0000000. The ocram goes to ahb@0. The following change should be the right one for ocram addition. diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 0ad893bf5f43..8e5718df06b2 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -47,6 +47,19 @@ }; }; + ahb@0 { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <1>; + reg = <0x0 0x80000000>; + ranges; + + ocram: sram@0 { + compatible = "mmio-sram"; + reg = <0x0 0x20000>; + }; + }; + apb@80000000 { compatible = "simple-bus"; #address-cells = <1>;