From patchwork Mon Oct 24 11:33:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 9391905 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B58236077A for ; Mon, 24 Oct 2016 11:35:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A447328F31 for ; Mon, 24 Oct 2016 11:35:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 953DD28F71; Mon, 24 Oct 2016 11:35:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 39D6128F31 for ; Mon, 24 Oct 2016 11:35:47 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bydWR-0007OR-0T; Mon, 24 Oct 2016 11:34:31 +0000 Received: from mail.kernel.org ([198.145.29.136]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bydWM-0007Eo-AX for linux-arm-kernel@lists.infradead.org; Mon, 24 Oct 2016 11:34:27 +0000 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5DBBE20218; Mon, 24 Oct 2016 11:34:04 +0000 (UTC) Received: from tiger (unknown [180.106.218.214]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE2B4201B9; Mon, 24 Oct 2016 11:33:58 +0000 (UTC) Date: Mon, 24 Oct 2016 19:33:37 +0800 From: Shawn Guo To: Andreas =?iso-8859-1?Q?F=E4rber?= Subject: Re: [PATCH v2] ARM: dts: imx6sx: Add UDOO Neo support Message-ID: <20161024113337.GE30578@tiger> References: <1476629064-10634-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1476629064-10634-1-git-send-email-afaerber@suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161024_043426_464062_D57F69B0 X-CRM114-Status: GOOD ( 18.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Russell King , open list , Ettore Chimenti , Rob Herring , Sascha Hauer , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Fabio Estevam , Micael Meixeiro , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Sun, Oct 16, 2016 at 04:44:23PM +0200, Andreas Färber wrote: > Add initial device trees for UDOO Neo Basic, Extended and Full boards: > * Serial console is enabled, other serial ports are prepared. > * I2C based PMIC is enabled. > * Ethernet is enabled for Basic and Full. > * SDHC is enabled, with the SDIO_PWR GPIO modeled as a regulator. > * Both user LEDs are enabled, with the orange one reserved for the M4 > and with the SD card as default trigger for the red LED. > > The decision on a board compatible string is deferred to later. > > Cc: Ettore Chimenti > Signed-off-by: Andreas Färber > +/ { > + compatible = "fsl,imx6sx"; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + leds { > + compatible = "gpio-leds"; > + > + red { > + label = "udoo-neo:red:mmc"; > + gpios = <&gpio6 0 GPIO_ACTIVE_HIGH>; > + default-state = "off"; > + linux,default-trigger = "mmc0"; > + }; > + > + orange { > + label = "udoo-neo:orange:user"; > + gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>; > + default-state = "keep"; > + }; > + }; > + > + sdio_pwr_reg: sd-gpio-regulator { We do have a recommended naming schema for fixed regulator. I updated it a bit as below, and applied the patch. Shawn > + compatible = "regulator-fixed"; > + gpio = <&gpio6 1 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + regulator-name = "SDIO_PWR"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + }; > +}; diff --git a/arch/arm/boot/dts/imx6sx-udoo-neo.dtsi b/arch/arm/boot/dts/imx6sx-udoo-neo.dtsi index 314d25b15641..2b65d26f4396 100644 --- a/arch/arm/boot/dts/imx6sx-udoo-neo.dtsi +++ b/arch/arm/boot/dts/imx6sx-udoo-neo.dtsi @@ -66,7 +66,7 @@ }; }; - sdio_pwr_reg: sd-gpio-regulator { + reg_sdio_pwr: regulator-sdio-pwr { compatible = "regulator-fixed"; gpio = <&gpio6 1 GPIO_ACTIVE_HIGH>; enable-active-high; @@ -283,7 +283,7 @@ &usdhc2 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_usdhc2>; - vmmc-supply = <&sdio_pwr_reg>; + vmmc-supply = <®_sdio_pwr>; bus-width = <4>; cd-gpios = <&gpio6 2 GPIO_ACTIVE_LOW>; no-1-8-v;