| Message ID | 20161025211955.5345-4-gary.bisson@boundarydevices.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Gary, On Tue, Oct 25, 2016 at 7:19 PM, Gary Bisson <gary.bisson@boundarydevices.com> wrote: > Declared as a regulator since the driver doesn't have a reset-gpios > property for this. Peter Chen is working on adding USB reset-gpio property this. Please check his series: https://www.spinics.net/lists/arm-kernel/msg536105.html
Hi Fabio, On Tue, Oct 25, 2016 at 11:28 PM, Fabio Estevam <festevam@gmail.com> wrote: > Hi Gary, > > On Tue, Oct 25, 2016 at 7:19 PM, Gary Bisson > <gary.bisson@boundarydevices.com> wrote: >> Declared as a regulator since the driver doesn't have a reset-gpios >> property for this. > > Peter Chen is working on adding USB reset-gpio property this. Please > check his series: > https://www.spinics.net/lists/arm-kernel/msg536105.html Thanks, I wasn't aware of this series. Indeed if this power sequence code gets upstream soon I guess we can drop both patches about the USB PHY reset. Note that our Nitrogen6_MAX is using the regulator approach, it will need to be updated once Peter's series gets merged. Regards, Gary
On Tue, Oct 25, 2016 at 11:53:40PM +0200, Gary Bisson wrote: > Hi Fabio, > > On Tue, Oct 25, 2016 at 11:28 PM, Fabio Estevam <festevam@gmail.com> wrote: > > Hi Gary, > > > > On Tue, Oct 25, 2016 at 7:19 PM, Gary Bisson > > <gary.bisson@boundarydevices.com> wrote: > >> Declared as a regulator since the driver doesn't have a reset-gpios > >> property for this. > > > > Peter Chen is working on adding USB reset-gpio property this. Please > > check his series: > > https://www.spinics.net/lists/arm-kernel/msg536105.html > > Thanks, I wasn't aware of this series. Indeed if this power sequence > code gets upstream soon I guess we can drop both patches about the USB > PHY reset. Let's wait then instead of adding something that will be removed later. Shawn
diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi index cebea8a..bf00267 100644 --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi @@ -94,6 +94,19 @@ pinctrl-0 = <&pinctrl_can_xcvr>; gpio = <&gpio1 2 GPIO_ACTIVE_LOW>; }; + + reg_usb_h1_vbus: regulator@4 { + compatible = "regulator-fixed"; + reg = <4>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbh1>; + regulator-name = "usb_h1_vbus"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&gpio7 12 GPIO_ACTIVE_HIGH>; + enable-active-high; + regulator-always-on; + }; }; gpio-keys { @@ -481,6 +494,12 @@ >; }; + pinctrl_usbh1: usbh1grp { + fsl,pins = < + MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x030b0 + >; + }; + pinctrl_usbotg: usbotggrp { fsl,pins = < MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059 @@ -578,6 +597,7 @@ }; &usbh1 { + vbus-supply = <®_usb_h1_vbus>; status = "okay"; };
Declared as a regulator since the driver doesn't have a reset-gpios property for this. This ensures that the PHY is woken up, not depending on the state the second stage bootloader leaves the pin. Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> --- arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)