| Message ID | 20161111173821.21491-1-eric@anholt.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Eric, [add Gerd to CC] > Eric Anholt <eric@anholt.net> hat am 11. November 2016 um 18:38 geschrieben: > > > From: Andrea Merello <andrea.merello@gmail.com> > > We are incorrectly defining the pwr LED, attaching it to a gpio line > that is wired to the Wi-Fi SDIO module (which fails due to this). i agree with the intention of this patch, but is the upstream kernel really affected? I can't see any compatible for the Wifi interface. > > The actual power LED is connected to the GPIO expander, which we don't > expose currently. > > Thanks-to: Eric Anholt <eric@anholt.net> [for clarifying we can't control the > LED] > Signed-off-by: Andrea Merello <andrea.merello@gmail.com> > Signed-off-by: Eric Anholt <eric@anholt.net> Fixes: 9d56c22a7861 ("ARM: bcm2835: Add devicetree for the Raspberry Pi 3.") Stefan
Stefan Wahren <stefan.wahren@i2se.com> writes: > Hi Eric, > > [add Gerd to CC] > >> Eric Anholt <eric@anholt.net> hat am 11. November 2016 um 18:38 geschrieben: >> >> >> From: Andrea Merello <andrea.merello@gmail.com> >> >> We are incorrectly defining the pwr LED, attaching it to a gpio line >> that is wired to the Wi-Fi SDIO module (which fails due to this). > > i agree with the intention of this patch, but is the upstream kernel really > affected? I can't see any compatible for the Wifi interface. The wifi isn't in the DT yet because the driver isn't merged. Some progress was made on that a while ago, but people asked for more cleanups so it's still living out of tree.
On Mo, 2016-11-14 at 16:39 -0800, Eric Anholt wrote: > Stefan Wahren <stefan.wahren@i2se.com> writes: > > > Hi Eric, > > > > [add Gerd to CC] > > > >> Eric Anholt <eric@anholt.net> hat am 11. November 2016 um 18:38 geschrieben: > >> > >> > >> From: Andrea Merello <andrea.merello@gmail.com> > >> > >> We are incorrectly defining the pwr LED, attaching it to a gpio line > >> that is wired to the Wi-Fi SDIO module (which fails due to this). > > > > i agree with the intention of this patch, but is the upstream kernel really > > affected? I can't see any compatible for the Wifi interface. > > The wifi isn't in the DT yet because the driver isn't merged. Some > progress was made on that a while ago, but people asked for more > cleanups so it's still living out of tree. some low-hanging fruits (codestyle mostly) are done, but more work is needed (fix messy timeout handling, make dma work). Didn't happed yet due to -ENOTIME. My current state is here: https://www.kraxel.org/cgit/linux/log/?h=bcm2837-wifi In case anyone wants pick it up feel free to do so (but please tell me so we avoid duplicating work). cheers, Gerd
diff --git a/arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts index 7625e57a64b5..c309633a1e87 100644 --- a/arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts +++ b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts @@ -16,13 +16,6 @@ act { gpios = <&gpio 47 0>; }; - - pwr { - label = "PWR"; - gpios = <&gpio 35 0>; - default-state = "keep"; - linux,default-trigger = "default-on"; - }; }; };