| Message ID | 20161122160037.14400-1-gregory.clement@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
From: Gregory CLEMENT <gregory.clement@free-electrons.com> Date: Tue, 22 Nov 2016 17:00:37 +0100 > Actually only the mvneta_bm support is not 64-bits compatible. > The mvneta code itself can run on 64-bits architecture. > > Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> No it cannot, it emits warnings because it casts pointers to and from 32-bit integers. I'm not applying this. drivers/net/ethernet/marvell/mvneta.c: In function ‘mvneta_rx_refill’: drivers/net/ethernet/marvell/mvneta.c:1802:42: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] mvneta_rx_desc_fill(rx_desc, phys_addr, (u32)data); ^ drivers/net/ethernet/marvell/mvneta.c: In function ‘mvneta_rxq_drop_pkts’: drivers/net/ethernet/marvell/mvneta.c:1864:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] void *data = (void *)rx_desc->buf_cookie; ^ drivers/net/ethernet/marvell/mvneta.c: In function ‘mvneta_rx_swbm’: drivers/net/ethernet/marvell/mvneta.c:1902:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] data = (unsigned char *)rx_desc->buf_cookie; ^ drivers/net/ethernet/marvell/mvneta.c: In function ‘mvneta_rx_hwbm’: drivers/net/ethernet/marvell/mvneta.c:2023:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] data = (unsigned char *)rx_desc->buf_cookie; ^
Hi David, On mar., nov. 22 2016, David Miller <davem@davemloft.net> wrote: > From: Gregory CLEMENT <gregory.clement@free-electrons.com> > Date: Tue, 22 Nov 2016 17:00:37 +0100 > >> Actually only the mvneta_bm support is not 64-bits compatible. >> The mvneta code itself can run on 64-bits architecture. >> >> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> > > No it cannot, it emits warnings because it casts pointers to and > from 32-bit integers. > > I'm not applying this. > > drivers/net/ethernet/marvell/mvneta.c: In function ‘mvneta_rx_refill’: > drivers/net/ethernet/marvell/mvneta.c:1802:42: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > mvneta_rx_desc_fill(rx_desc, phys_addr, (u32)data); > ^ > drivers/net/ethernet/marvell/mvneta.c: In function ‘mvneta_rxq_drop_pkts’: > drivers/net/ethernet/marvell/mvneta.c:1864:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > void *data = (void *)rx_desc->buf_cookie; > ^ > drivers/net/ethernet/marvell/mvneta.c: In function ‘mvneta_rx_swbm’: > drivers/net/ethernet/marvell/mvneta.c:1902:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > data = (unsigned char *)rx_desc->buf_cookie; > ^ > drivers/net/ethernet/marvell/mvneta.c: In function ‘mvneta_rx_hwbm’: > drivers/net/ethernet/marvell/mvneta.c:2023:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > data = (unsigned char *)rx_desc->buf_cookie; > ^ Indeed! There was a missing patch for it that I had in my tree and I didn't submit yet. I am bout to doing it now. Thanks, Gregory
diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig index 66fd9dbb2ca7..2ccea9dd9248 100644 --- a/drivers/net/ethernet/marvell/Kconfig +++ b/drivers/net/ethernet/marvell/Kconfig @@ -44,6 +44,7 @@ config MVMDIO config MVNETA_BM_ENABLE tristate "Marvell Armada 38x/XP network interface BM support" depends on MVNETA + depends on !64BIT ---help--- This driver supports auxiliary block of the network interface units in the Marvell ARMADA XP and ARMADA 38x SoC @@ -58,7 +59,6 @@ config MVNETA tristate "Marvell Armada 370/38x/XP network interface support" depends on PLAT_ORION || COMPILE_TEST depends on HAS_DMA - depends on !64BIT select MVMDIO select FIXED_PHY ---help--- @@ -71,6 +71,7 @@ config MVNETA config MVNETA_BM tristate + depends on !64BIT default y if MVNETA=y && MVNETA_BM_ENABLE!=n default MVNETA_BM_ENABLE select HWBM
Actually only the mvneta_bm support is not 64-bits compatible. The mvneta code itself can run on 64-bits architecture. Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> --- drivers/net/ethernet/marvell/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)