| Message ID | 20161208171010.29446-4-gregory.clement@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Dec 08, 2016 at 06:10:10PM +0100, Gregory CLEMENT wrote: > The drivers are supposed to be portable, however there are few assumption > done here about the unsigned long size. Make sure we use the accurate > width for the variable. > > Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> > --- > drivers/rtc/rtc-armada38x.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/rtc/rtc-armada38x.c b/drivers/rtc/rtc-armada38x.c > index b8a74ffaae80..c4138130febf 100644 > --- a/drivers/rtc/rtc-armada38x.c > +++ b/drivers/rtc/rtc-armada38x.c > @@ -84,14 +84,14 @@ static void rtc_update_mbus_timing_params(struct armada38x_rtc *rtc) > } > > struct str_value_to_freq { > - unsigned long value; > + u32 value; > u8 freq; > } __packed; > > -static unsigned long read_rtc_register_wa(struct armada38x_rtc *rtc, u8 rtc_reg) > +static u32 read_rtc_register_wa(struct armada38x_rtc *rtc, u8 rtc_reg) > { > - unsigned long value_array[SAMPLE_NR], i, j, value; > - unsigned long max = 0, index_max = SAMPLE_NR - 1; > + int i, j, index_max = SAMPLE_NR - 1; > + u32 value_array[SAMPLE_NR], value, max = 0; Ah, I see my comments on patch 1 got addressed in patch 3... :)
diff --git a/drivers/rtc/rtc-armada38x.c b/drivers/rtc/rtc-armada38x.c index b8a74ffaae80..c4138130febf 100644 --- a/drivers/rtc/rtc-armada38x.c +++ b/drivers/rtc/rtc-armada38x.c @@ -84,14 +84,14 @@ static void rtc_update_mbus_timing_params(struct armada38x_rtc *rtc) } struct str_value_to_freq { - unsigned long value; + u32 value; u8 freq; } __packed; -static unsigned long read_rtc_register_wa(struct armada38x_rtc *rtc, u8 rtc_reg) +static u32 read_rtc_register_wa(struct armada38x_rtc *rtc, u8 rtc_reg) { - unsigned long value_array[SAMPLE_NR], i, j, value; - unsigned long max = 0, index_max = SAMPLE_NR - 1; + int i, j, index_max = SAMPLE_NR - 1; + u32 value_array[SAMPLE_NR], value, max = 0; struct str_value_to_freq value_to_freq[SAMPLE_NR]; for (i = 0; i < SAMPLE_NR; i++) {
The drivers are supposed to be portable, however there are few assumption done here about the unsigned long size. Make sure we use the accurate width for the variable. Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> --- drivers/rtc/rtc-armada38x.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)