| Message ID | 20170102022249.10657-2-f.fainelli@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> + > + switch: switch@10 { > + compatible = "marvell,mv88e6085"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <16>; Hummm, a device tree question. switch@10, reg = <16>. Is there an implicit understanding that the 10 is hex? Andrew
On 01/03/2017 08:36 AM, Andrew Lunn wrote: >> + >> + switch: switch@10 { >> + compatible = "marvell,mv88e6085"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <16>; > > Hummm, a device tree question. switch@10, reg = <16>. Is there an > implicit understanding that the 10 is hex? Most (if not all?) unit addresses are hexadecimal, which is why this was chosen here, but I really don't mind changing that.
Hi Florian, On mer., janv. 04 2017, Florian Fainelli <f.fainelli@gmail.com> wrote: > On 01/03/2017 08:36 AM, Andrew Lunn wrote: >>> + >>> + switch: switch@10 { >>> + compatible = "marvell,mv88e6085"; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + reg = <16>; >> >> Hummm, a device tree question. switch@10, reg = <16>. Is there an >> implicit understanding that the 10 is hex? > > Most (if not all?) unit addresses are hexadecimal, which is why this was > chosen here, but I really don't mind changing that. And what about using: reg = <0x10>; Gregory > -- > Florian
diff --git a/arch/arm/boot/dts/armada-370-rd.dts b/arch/arm/boot/dts/armada-370-rd.dts index c3fd6e49212f..9c6e924ac0b3 100644 --- a/arch/arm/boot/dts/armada-370-rd.dts +++ b/arch/arm/boot/dts/armada-370-rd.dts @@ -173,6 +173,8 @@ }; dsa { + status = "disabled"; + compatible = "marvell,dsa"; #address-cells = <2>; #size-cells = <0>; @@ -235,6 +237,48 @@ phy0: ethernet-phy@0 { reg = <0>; }; + + switch: switch@10 { + compatible = "marvell,mv88e6085"; + #address-cells = <1>; + #size-cells = <0>; + reg = <16>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + label = "lan0"; + }; + + port@1 { + reg = <1>; + label = "lan1"; + }; + + port@2 { + reg = <2>; + label = "lan2"; + }; + + port@3 { + reg = <3>; + label = "lan3"; + }; + + port@5 { + reg = <5>; + label = "cpu"; + ethernet = <ð1>; + fixed-link { + speed = <1000>; + full-duplex; + }; + }; + }; + }; };
Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net: dsa: Document new binding"). The legacy binding node is kept included, but is marked disabled. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- arch/arm/boot/dts/armada-370-rd.dts | 44 +++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+)