| Message ID | 20170111162841.15569-3-alex.bennee@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 11/01/2017 17:28, Alex Bennée wrote: > Using %x as a format string is not portable across 32/64 bit builds. > Use explicit PRIx32 format strings like the 64 bit version above. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > lib/pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/pci.c b/lib/pci.c > index 6416191..597d8f2 100644 > --- a/lib/pci.c > +++ b/lib/pci.c > @@ -67,7 +67,7 @@ bool pci_setup_msi(struct pci_dev *dev, uint64_t msi_addr, uint32_t msi_data) > pci_config_writel(addr, offset + PCI_MSI_DATA_32, msi_data); > printf("MSI: dev 0x%x init 32bit address: ", addr); > } > - printf("addr=0x%lx, data=0x%x\n", msi_addr, msi_data); > + printf("addr=0x%" PRIx64 ", data=0x%" PRIx32 "\n", msi_addr, msi_data); Applying only the %lx -> %"PRIx64" change for now (though it's also in Andrew's 32-bit compilation fixes patch). Paolo > > msi_control |= PCI_MSI_FLAGS_ENABLE; > pci_config_writew(addr, offset + PCI_MSI_FLAGS, msi_control); > @@ -237,7 +237,7 @@ void pci_bar_print(struct pci_dev *dev, int bar_num) > printf("BAR#%d,%d [%" PRIx64 "-%" PRIx64 " ", > bar_num, bar_num + 1, start, end); > } else { > - printf("BAR#%d [%02x-%02x ", > + printf("BAR#%d [%" PRIx32 "-%" PRIx32 " ", > bar_num, (uint32_t)start, (uint32_t)end); > } > >
diff --git a/lib/pci.c b/lib/pci.c index 6416191..597d8f2 100644 --- a/lib/pci.c +++ b/lib/pci.c @@ -67,7 +67,7 @@ bool pci_setup_msi(struct pci_dev *dev, uint64_t msi_addr, uint32_t msi_data) pci_config_writel(addr, offset + PCI_MSI_DATA_32, msi_data); printf("MSI: dev 0x%x init 32bit address: ", addr); } - printf("addr=0x%lx, data=0x%x\n", msi_addr, msi_data); + printf("addr=0x%" PRIx64 ", data=0x%" PRIx32 "\n", msi_addr, msi_data); msi_control |= PCI_MSI_FLAGS_ENABLE; pci_config_writew(addr, offset + PCI_MSI_FLAGS, msi_control); @@ -237,7 +237,7 @@ void pci_bar_print(struct pci_dev *dev, int bar_num) printf("BAR#%d,%d [%" PRIx64 "-%" PRIx64 " ", bar_num, bar_num + 1, start, end); } else { - printf("BAR#%d [%02x-%02x ", + printf("BAR#%d [%" PRIx32 "-%" PRIx32 " ", bar_num, (uint32_t)start, (uint32_t)end); }
Using %x as a format string is not portable across 32/64 bit builds. Use explicit PRIx32 format strings like the 64 bit version above. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- lib/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)