| Message ID | 20170119142134.8572-1-l.stach@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 2017-01-19 at 15:21 +0100, Lucas Stach wrote: > The regulation bound of this regulator are 2.1V to 2.875V, the > wrong DT values cause the driver to miscalculate the effective > voltage. As easily checked with $ grep vdd2p5 /sys/kernel/debug/regulator/regulator_summary - vdd2p5 0 0 0 2400mV 0mA 2000mV 2750mV + vdd2p5 0 0 0 2500mV 0mA 2000mV 2750mV > This isn't really an issue right now, as nobody actively changes > the regulator voltage, but better fix it now. > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > --- > arch/arm/boot/dts/imx6qdl.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > index 53e6e63cbb02..9313b9af2da8 100644 > --- a/arch/arm/boot/dts/imx6qdl.dtsi > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > @@ -661,8 +661,8 @@ > anatop-vol-bit-shift = <8>; > anatop-vol-bit-width = <5>; > anatop-min-bit-val = <0>; > - anatop-min-voltage = <2000000>; > - anatop-max-voltage = <2750000>; > + anatop-min-voltage = <2100000>; > + anatop-max-voltage = <2875000>; > }; > > reg_arm: regulator-vddcore { Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
On Thu, Jan 19, 2017 at 03:21:33PM +0100, Lucas Stach wrote: > The regulation bound of this regulator are 2.1V to 2.875V, the > wrong DT values cause the driver to miscalculate the effective > voltage. > > This isn't really an issue right now, as nobody actively changes > the regulator voltage, but better fix it now. > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Applied both, thanks.
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 53e6e63cbb02..9313b9af2da8 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -661,8 +661,8 @@ anatop-vol-bit-shift = <8>; anatop-vol-bit-width = <5>; anatop-min-bit-val = <0>; - anatop-min-voltage = <2000000>; - anatop-max-voltage = <2750000>; + anatop-min-voltage = <2100000>; + anatop-max-voltage = <2875000>; }; reg_arm: regulator-vddcore {
The regulation bound of this regulator are 2.1V to 2.875V, the wrong DT values cause the driver to miscalculate the effective voltage. This isn't really an issue right now, as nobody actively changes the regulator voltage, but better fix it now. Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- arch/arm/boot/dts/imx6qdl.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)