| Message ID | 20170126220504.4796-3-andrew.smirnov@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Andrey, Am Donnerstag, den 26.01.2017, 14:05 -0800 schrieb Andrey Smirnov: > Use IRQCHIP_DECLARE_DRIVER instead of Use IRQCHIP_DECLARE to allow > 'imx_gpc_driver' to be probed in addition to irqchip initialized by > imx_gpc_init(). > > Cc: yurovsky@gmail.com > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Marc Zyngier <marc.zyngier@arm.com> > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > --- > arch/arm/mach-imx/gpc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c > index 1dc2a34..8f0d19b 100644 > --- a/arch/arm/mach-imx/gpc.c > +++ b/arch/arm/mach-imx/gpc.c > @@ -279,7 +279,7 @@ static int __init imx_gpc_init(struct device_node *node, > > return 0; > } > -IRQCHIP_DECLARE(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init); > +IRQCHIP_DECLARE_DRIVER(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init); > > void __init imx_gpc_check_dt(void) > { I don't see the other patches from the series on the list, so commenting here: You might want to take a look at my GPC rework series, it has a much nicer binding for the power domains, that you might want to use for the GPCv2 also. Additionally I think the power domain stuff doesn't belong into the irqchip driver, but rather in a separate driver in drivers/soc like it is done in my series. I'll send out an updated version of this series today and you might consider basing your GPCv2 on top of that. Regards, Lucas
On Fri, Jan 27, 2017 at 1:54 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > Hi Andrey, > > Am Donnerstag, den 26.01.2017, 14:05 -0800 schrieb Andrey Smirnov: >> Use IRQCHIP_DECLARE_DRIVER instead of Use IRQCHIP_DECLARE to allow >> 'imx_gpc_driver' to be probed in addition to irqchip initialized by >> imx_gpc_init(). >> >> Cc: yurovsky@gmail.com >> Cc: Shawn Guo <shawnguo@kernel.org> >> Cc: Thomas Gleixner <tglx@linutronix.de> >> Cc: Jason Cooper <jason@lakedaemon.net> >> Cc: Marc Zyngier <marc.zyngier@arm.com> >> Cc: linux-arm-kernel@lists.infradead.org >> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> >> --- >> arch/arm/mach-imx/gpc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c >> index 1dc2a34..8f0d19b 100644 >> --- a/arch/arm/mach-imx/gpc.c >> +++ b/arch/arm/mach-imx/gpc.c >> @@ -279,7 +279,7 @@ static int __init imx_gpc_init(struct device_node *node, >> >> return 0; >> } >> -IRQCHIP_DECLARE(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init); >> +IRQCHIP_DECLARE_DRIVER(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init); >> >> void __init imx_gpc_check_dt(void) >> { > > I don't see the other patches from the series on the list, so commenting > here: You might want to take a look at my GPC rework series, it has a > much nicer binding for the power domains, that you might want to use for > the GPCv2 also. I messed up distribution list of my original patches, sorry. OK, I'll take a look. > > Additionally I think the power domain stuff doesn't belong into the > irqchip driver, but rather in a separate driver in drivers/soc like it > is done in my series. > > I'll send out an updated version of this series today and you might > consider basing your GPCv2 on top of that. Please CC me on it if you haven't sent the patches already. Thanks, Andrey Smirnov
diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c index 1dc2a34..8f0d19b 100644 --- a/arch/arm/mach-imx/gpc.c +++ b/arch/arm/mach-imx/gpc.c @@ -279,7 +279,7 @@ static int __init imx_gpc_init(struct device_node *node, return 0; } -IRQCHIP_DECLARE(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init); +IRQCHIP_DECLARE_DRIVER(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init); void __init imx_gpc_check_dt(void) {
Use IRQCHIP_DECLARE_DRIVER instead of Use IRQCHIP_DECLARE to allow 'imx_gpc_driver' to be probed in addition to irqchip initialized by imx_gpc_init(). Cc: yurovsky@gmail.com Cc: Shawn Guo <shawnguo@kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Jason Cooper <jason@lakedaemon.net> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> --- arch/arm/mach-imx/gpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)