| Message ID | 20170127085458.18270-17-quentin.schulz@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Fri, Jan 27, 2017 at 09:54:49AM +0100, Quentin Schulz wrote: > - added x-powers,constant-charge-current property to set the > maximal default constant current charge of the battery, Since this is information about the battery and not the fuel-gauge, it should use the WIP "framework" for information about batteries. Have a look at the following patchset: http://marc.info/?l=linux-pm&m=148411561025684&w=2 -- Sebastian
Hi, On 29/01/2017 17:47, Sebastian Reichel wrote: > Hi, > > On Fri, Jan 27, 2017 at 09:54:49AM +0100, Quentin Schulz wrote: >> - added x-powers,constant-charge-current property to set the >> maximal default constant current charge of the battery, > > Since this is information about the battery and not the fuel-gauge, > it should use the WIP "framework" for information about batteries. > > Have a look at the following patchset: > > http://marc.info/?l=linux-pm&m=148411561025684&w=2 > OK. So what you propose is to have a fourth property in this new structure named design-max-constant-charge-current that gives the maximal input amperage the battery can receive? Then, I set the charger to output a maximum of this amperage by default and let the user the possibility to choose between the minimum allowed by the PMIC and the maximum allowed by the battery from sysfs. That makes more sense than what I do here in the way that I didn't protect a possible over-amperage of the battery, thing that Chen-Yu was afraid some users would do. I've a comment on the linked patches however. Though the three properties are listed as optional in the binding-dt, the implementation is saying the opposite: http://marc.info/?l=linux-pm&m=148411561725693&w=2 If I'm not mistaken, if `nominal-microvolt' or `design-microwatt-hours' is not a property of the DT node, power_supply_get_battery_info will return without parsing the other properties and even return a negative error. Thanks, Quentin
diff --git a/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt new file mode 100644 index 0000000..6f7eff2 --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt @@ -0,0 +1,25 @@ +AXP20x and AXP22x battery power supply + +Required Properties: + - compatible, one of: + "x-powers,axp209-battery-power-supply" + "x-powers,axp221-battery-power-supply" + +Optional properties: + - x-powers,constant-charge-current: its value in uA gives the PMIC the default + maximal allowed value for the constant charge current of the battery. + +This node is a subnode of the axp20x/axp22x PMIC. + +The AXP20X and AXP22X can read the battery voltage, charge and discharge +currents of the battery by reading ADC channels from the AXP20X/AXP22X +ADC. + +Example: + +&axp209 { + battery_power_supply: battery-power-supply { + compatible = "x-powers,axp209-battery-power-supply"; + x-powers,constant-charge-current = <600000>; + } +};
The X-Powers AXP20X and AXP22X PMICs can have a battery as power supply. This patch adds the DT binding documentation for the battery power supply which gets various data from the PMIC, such as the battery status (charging, discharging, full, dead), current max limit, current current, battery capacity (in percentage), voltage max and min limits, current voltage and battery capacity (in Ah). Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com> --- v2: - changed DT node name from ac_power_supply to ac-power-supply, - removed io-channels and io-channel-names from DT (the IIO mapping is done in the IIO ADC driver now), - added x-powers,constant-charge-current property to set the maximal default constant current charge of the battery, .../bindings/power/supply/axp20x_battery.txt | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/axp20x_battery.txt