From patchwork Mon Jan 30 19:03:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Phillips X-Patchwork-Id: 9545979 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4C31F60417 for ; Mon, 30 Jan 2017 19:03:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3A0D52811E for ; Mon, 30 Jan 2017 19:03:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2BF442818B; Mon, 30 Jan 2017 19:03:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00 autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9DDD72811E for ; Mon, 30 Jan 2017 19:03:42 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cYHEp-0002lq-1A; Mon, 30 Jan 2017 19:03:39 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cYHEk-0002fy-ES for linux-arm-kernel@lists.infradead.org; Mon, 30 Jan 2017 19:03:36 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 078F514F6; Mon, 30 Jan 2017 11:03:14 -0800 (PST) Received: from dupont (unknown [10.118.14.86]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5CD0F3F24D; Mon, 30 Jan 2017 11:03:13 -0800 (PST) Date: Mon, 30 Jan 2017 13:03:12 -0600 From: Kim Phillips To: Will Deacon Subject: Re: [PATCH 09/10] drivers/perf: Add support for ARMv8.2 Statistical Profiling Extension Message-Id: <20170130130312.09e4aef34c685f4c228aba50@arm.com> In-Reply-To: <1485540470-11469-10-git-send-email-will.deacon@arm.com> References: <1485540470-11469-1-git-send-email-will.deacon@arm.com> <1485540470-11469-10-git-send-email-will.deacon@arm.com> Organization: ARM X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170130_110334_582461_BFE71886 X-CRM114-Status: GOOD ( 17.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, robh@kernel.org, mathieu.poirier@linaro.org, pawel.moll@arm.com, suzuki.poulose@arm.com, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com, peterz@infradead.org, mingo@redhat.com, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, alex.bennee@linaro.org, christoffer.dall@linaro.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, 27 Jan 2017 18:07:48 +0000 Will Deacon wrote: > +/* Perf callbacks */ > +static int arm_spe_pmu_event_init(struct perf_event *event) > +{ > + u64 reg; > + struct perf_event_attr *attr = &event->attr; > + struct arm_spe_pmu *spe_pmu = to_spe_pmu(event->pmu); > + > + /* This is, of course, deeply driver-specific */ > + if (attr->type != event->pmu->type) > + return -ENOENT; > + > + if (event->cpu >= 0 && > + !cpumask_test_cpu(event->cpu, &spe_pmu->supported_cpus)) > + return -ENOENT; > + > + if (arm_spe_event_to_pmsevfr(event) & PMSEVFR_EL1_RES0) > + return -EOPNOTSUPP; > + > + if (event->hw.sample_period < spe_pmu->min_period || > + event->hw.sample_period & PMSIRR_EL1_IVAL_MASK) > + return -EOPNOTSUPP; > + > + if (attr->exclude_idle) > + return -EOPNOTSUPP; > + > + /* > + * Feedback-directed frequency throttling doesn't work when we > + * have a buffer of samples. We'd need to manually count the > + * samples in the buffer when it fills up and adjust the event > + * count to reflect that. Instead, force the user to specify a > + * sample period instead. > + */ > + if (attr->freq) > + return -EINVAL; > + > + if (is_kernel_in_hyp_mode()) { > + if (attr->exclude_kernel != attr->exclude_hv) > + return -EOPNOTSUPP; > + } else if (!attr->exclude_hv) { > + return -EOPNOTSUPP; > + } > + > + reg = arm_spe_event_to_pmsfcr(event); > + if ((reg & BIT(PMSFCR_EL1_FE_SHIFT)) && > + !(spe_pmu->features & SPE_PMU_FEAT_FILT_EVT)) > + return -EOPNOTSUPP; > + > + if ((reg & BIT(PMSFCR_EL1_FT_SHIFT)) && > + !(spe_pmu->features & SPE_PMU_FEAT_FILT_TYP)) > + return -EOPNOTSUPP; > + > + if ((reg & BIT(PMSFCR_EL1_FL_SHIFT)) && > + !(spe_pmu->features & SPE_PMU_FEAT_FILT_LAT)) > + return -EOPNOTSUPP; > + > + return 0; > +} Please add below messaging such as to avoid users having to do so themselves: Thanks, Kim diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c index b4906c3..7c2635c 100644 --- a/drivers/perf/arm_spe_pmu.c +++ b/drivers/perf/arm_spe_pmu.c @@ -655,24 +655,33 @@ static int arm_spe_pmu_event_init(struct perf_event *event) u64 reg; struct perf_event_attr *attr = &event->attr; struct arm_spe_pmu *spe_pmu = to_spe_pmu(event->pmu); + struct device *dev = &spe_pmu->pdev->dev; /* This is, of course, deeply driver-specific */ if (attr->type != event->pmu->type) return -ENOENT; if (event->cpu >= 0 && - !cpumask_test_cpu(event->cpu, &spe_pmu->supported_cpus)) + !cpumask_test_cpu(event->cpu, &spe_pmu->supported_cpus)) { + dev_err_ratelimited(dev, "CPU not supported by SPE\n"); return -ENOENT; + } - if (arm_spe_event_to_pmsevfr(event) & PMSEVFR_EL1_RES0) + if (arm_spe_event_to_pmsevfr(event) & PMSEVFR_EL1_RES0) { + dev_err_ratelimited(dev, "Unsupported event filter\n"); return -EOPNOTSUPP; + } if (event->hw.sample_period < spe_pmu->min_period || - event->hw.sample_period & PMSIRR_EL1_IVAL_MASK) + event->hw.sample_period & PMSIRR_EL1_IVAL_MASK) { + dev_err_ratelimited(dev, "Cannot set sample period below the minimum interval\n"); return -EOPNOTSUPP; + } - if (attr->exclude_idle) + if (attr->exclude_idle) { + dev_err_ratelimited(dev, "Cannot exclude profiling when idle\n"); return -EOPNOTSUPP; + } /* * Feedback-directed frequency throttling doesn't work when we @@ -681,28 +690,39 @@ static int arm_spe_pmu_event_init(struct perf_event *event) * count to reflect that. Instead, force the user to specify a * sample period instead. */ - if (attr->freq) + if (attr->freq) { + dev_err_ratelimited(dev, "a sample period must be specified\n"); return -EINVAL; + } if (is_kernel_in_hyp_mode()) { - if (attr->exclude_kernel != attr->exclude_hv) + if (attr->exclude_kernel != attr->exclude_hv) { + dev_err_ratelimited(dev, "VHE is enabled but exclude_kernel and exclude_hv do not match\n"); return -EOPNOTSUPP; + } } else if (!attr->exclude_hv) { + dev_err_ratelimited(dev, "VHE is disabled but exclude_hv is not set\n"); return -EOPNOTSUPP; } reg = arm_spe_event_to_pmsfcr(event); if ((reg & BIT(PMSFCR_EL1_FE_SHIFT)) && - !(spe_pmu->features & SPE_PMU_FEAT_FILT_EVT)) + !(spe_pmu->features & SPE_PMU_FEAT_FILT_EVT)) { + dev_err_ratelimited(dev, "event filter feature not supported\n"); return -EOPNOTSUPP; + } if ((reg & BIT(PMSFCR_EL1_FT_SHIFT)) && - !(spe_pmu->features & SPE_PMU_FEAT_FILT_TYP)) + !(spe_pmu->features & SPE_PMU_FEAT_FILT_TYP)) { + dev_err_ratelimited(dev, "event type filter feature not supported\n"); return -EOPNOTSUPP; + } if ((reg & BIT(PMSFCR_EL1_FL_SHIFT)) && - !(spe_pmu->features & SPE_PMU_FEAT_FILT_LAT)) + !(spe_pmu->features & SPE_PMU_FEAT_FILT_LAT)) { + dev_err_ratelimited(dev, "latency filter feature not supported\n"); return -EOPNOTSUPP; + } return 0; }