[v5,3/7] rtc: ac100: Add RTC driver for X-Powers AC100

Commit Message

Rask Ingemann Lambertsen Feb. 5, 2017, 9:33 p.m. UTC

On Fri, Jul 08, 2016 at 10:33:38PM +0800, Chen-Yu Tsai wrote:
> X-Powers AC100 is a codec / RTC combo chip. This driver supports
> the RTC sub-device.

Don't we also want to build this driver by default, at least for
sunxi_defconfig, but possibly for multi_v7_defconfig as well?

-------------------- >8 --------------------
Subject: [PATCH] ARM: sunxi_defconfig: Enable AC100 RTC driver

Enable the AC100 RTC driver so boards with it can keep track of time.

Signed-off-by: Rask Ingemann Lambertsen <[e-mail]>
---
 arch/arm/configs/sunxi_defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Chen-Yu Tsai Feb. 6, 2017, 3:29 a.m. UTC | #1

On Mon, Feb 6, 2017 at 5:33 AM, Rask Ingemann Lambertsen
<[e-mail]> wrote:
> On Fri, Jul 08, 2016 at 10:33:38PM +0800, Chen-Yu Tsai wrote:
>> X-Powers AC100 is a codec / RTC combo chip. This driver supports
>> the RTC sub-device.
>
> Don't we also want to build this driver by default, at least for
> sunxi_defconfig, but possibly for multi_v7_defconfig as well?

True.

> -------------------- >8 --------------------
> Subject: [PATCH] ARM: sunxi_defconfig: Enable AC100 RTC driver
>
> Enable the AC100 RTC driver so boards with it can keep track of time.
>
> Signed-off-by: Rask Ingemann Lambertsen <[e-mail]>

Acked-by: Chen-Yu Tsai <[e-mail]>

I suggest you send this in a new thread. Patches in replies tend
to get missed.

> ---
>  arch/arm/configs/sunxi_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig
> index da92c25..5cd5dd70 100644
> --- a/arch/arm/configs/sunxi_defconfig
> +++ b/arch/arm/configs/sunxi_defconfig
> @@ -87,6 +87,7 @@ CONFIG_THERMAL_OF=y
>  CONFIG_CPU_THERMAL=y
>  CONFIG_WATCHDOG=y
>  CONFIG_SUNXI_WATCHDOG=y
> +CONFIG_MFD_AC100=y
>  CONFIG_MFD_AXP20X=y
>  CONFIG_MFD_AXP20X_I2C=y
>  CONFIG_MFD_AXP20X_RSB=y
> @@ -129,6 +130,7 @@ CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
>  CONFIG_RTC_CLASS=y
>  # CONFIG_RTC_INTF_SYSFS is not set
>  # CONFIG_RTC_INTF_PROC is not set
> +CONFIG_RTC_DRV_AC100=y
>  CONFIG_RTC_DRV_SUN6I=y
>  CONFIG_RTC_DRV_SUNXI=y
>  CONFIG_DMADEVICES=y
> --
> 2.10.2
>
> --
> Rask Ingemann Lambertsen

Rask Ingemann Lambertsen Feb. 6, 2017, 6:15 p.m. UTC | #2

On Mon, Feb 06, 2017 at 11:29:07AM +0800, Chen-Yu Tsai wrote:
> On Mon, Feb 6, 2017 at 5:33 AM, Rask Ingemann Lambertsen
> <[e-mail]> wrote:
> > -------------------- >8 --------------------
> > Subject: [PATCH] ARM: sunxi_defconfig: Enable AC100 RTC driver
> >
> > Enable the AC100 RTC driver so boards with it can keep track of time.
> >
> > Signed-off-by: Rask Ingemann Lambertsen <[e-mail]>
> 
> Acked-by: Chen-Yu Tsai <[e-mail]>
> 
> I suggest you send this in a new thread. Patches in replies tend
> to get missed.

I will. Should I Cc: stable on this?

Patch

diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig
index da92c25..5cd5dd70 100644
--- a/arch/arm/configs/sunxi_defconfig
+++ b/arch/arm/configs/sunxi_defconfig
@@ -87,6 +87,7 @@  CONFIG_THERMAL_OF=y
 CONFIG_CPU_THERMAL=y
 CONFIG_WATCHDOG=y
 CONFIG_SUNXI_WATCHDOG=y
+CONFIG_MFD_AC100=y
 CONFIG_MFD_AXP20X=y
 CONFIG_MFD_AXP20X_I2C=y
 CONFIG_MFD_AXP20X_RSB=y
@@ -129,6 +130,7 @@  CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
 CONFIG_RTC_CLASS=y
 # CONFIG_RTC_INTF_SYSFS is not set
 # CONFIG_RTC_INTF_PROC is not set
+CONFIG_RTC_DRV_AC100=y
 CONFIG_RTC_DRV_SUN6I=y
 CONFIG_RTC_DRV_SUNXI=y
 CONFIG_DMADEVICES=y