From patchwork Thu Feb 16 17:55:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 9579211 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E8F7D6049F for ; Fri, 17 Feb 2017 08:39:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E051028680 for ; Fri, 17 Feb 2017 08:39:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D47EB2868F; Fri, 17 Feb 2017 08:39:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=2.0 tests=BAYES_00, DATE_IN_PAST_12_24, DKIM_SIGNED,DKIM_VALID autolearn=no version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 70D4328680 for ; Fri, 17 Feb 2017 08:39:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h/mnVp4LINgBZz8S9HmqhY0Ffpr2pVHn3xTBS0csY4Y=; b=aJqt5nNMPCulaImm5N+v7c2Je iV8NgvxuwFsOTObwkrGoQqURK5FPKFp4b5DLhWbqyIeEECRMBO6sXisJuCVt6Asx2yPwyLbmhd+wo 4reTvP/h5Pyqlit6MJJSE8CtoOvgTvD4lqFjz/0x/JuFpT4lQExqxQhi5BIAp/xWp79xdhwafUA/M 8u52yx+ThIlFhKZndqYOWuO1/IiHRm0XmIcgqfJ7Q5rwITJ2KVUVwe63/F7kcz6HOH9xi0VfjZ1NP ZTyCAiP6Abu9ZtRWfwjtNpI1ripr757OM2ufvEEm4z3n7LuqwHW+Y919pxsq16gzWmsFdCIOLps44 6WfCLLnQA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cee4i-0005hG-Dt; Fri, 17 Feb 2017 08:39:32 +0000 Received: from mail.free-electrons.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cee4d-0005eq-Vo for linux-arm-kernel@lists.infradead.org; Fri, 17 Feb 2017 08:39:30 +0000 Received: by mail.free-electrons.com (Postfix, from userid 110) id BA20120B98; Fri, 17 Feb 2017 09:39:04 +0100 (CET) Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 963CF20706; Fri, 17 Feb 2017 09:39:04 +0100 (CET) Date: Thu, 16 Feb 2017 18:55:53 +0100 From: Maxime Ripard To: Bob Ham Subject: Re: [PATCH] clk: sunxi-ng: sun6i: Fix enable bit offset for hdmi-ddc module clock Message-ID: <20170216175553.epqbtjdazj76tjyu@lukather> References: <20170214022332.13326-1-wens@csie.org> <1487110855.7145.46.camel@settrans.net> MIME-Version: 1.0 In-Reply-To: <1487110855.7145.46.camel@settrans.net> User-Agent: Mutt/1.6.2-neo (2016-08-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170217_003928_226227_02B4D9A7 X-CRM114-Status: GOOD ( 16.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Chen-Yu Tsai , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Bob, On Tue, Feb 14, 2017 at 10:20:55PM +0000, Bob Ham wrote: > On Tue, 2017-02-14 at 10:23 +0800, Chen-Yu Tsai wrote: > > The enable bit offset for the hdmi-ddc module clock is wrong. It is > > pointing to the main hdmi module clock enable bit. > > > > Reported-by: Bob Ham > > Fixes: c6e6c96d8fa6 ("clk: sunxi-ng: Add A31/A31s clocks") > > Cc: stable@vger.kernel.org # 4.9.x- > > Signed-off-by: Chen-Yu Tsai > > --- > > > > Hi Bob, > > > > Can you try this patch and see if it fixes your HDMI issue? > > With the kernel running without "clk_ignore_unused" that is. > > Hi Chen-Yu, > > Unfortunately, that doesn't fix it; I get the same behaviour as without > clk_ignore_unused. can you apply that patch and give us your kernel boot logs? Thanks! ------8<--------- -------8<------- diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 820a939fb6bb..0a23b03ea393 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -773,7 +773,9 @@ static void clk_disable_unused_subtree(struct clk_core *core) if (core->enable_count) goto unlock_out; - if (core->flags & CLK_IGNORE_UNUSED) + printk("Ignoring %s\n", core->name); + + if (true) goto unlock_out; /*