From patchwork Fri Feb 24 12:54:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Keeping X-Patchwork-Id: 9590175 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1A0E3601AE for ; Fri, 24 Feb 2017 13:06:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D22E5286FE for ; Fri, 24 Feb 2017 13:06:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C63622875C; Fri, 24 Feb 2017 13:06:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3BB24286FE for ; Fri, 24 Feb 2017 13:06:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=5IEmf7Yn9gfzFsp3YWvBkDahhfvkew9dpntnltNIDzg=; b=m+lIpugaPAETAVtgANzJUMNgbu IauwD7/onr6IM3vIiQWeh+77FrONu0DIYimEi1VcWEs03SzSOMm+f8WFgfwjR7JoYTISu3A/6OsiW dxn0vLQsYPjbzp2dj7skApv01diMKChZW8gJgS3EGpSDz4K6nYEUTf8l85xHMibO+mMnKJbf6Y1HQ VAtrQgeV1XHaf3U8ecm5GxR3faSg+B0XFxOXTYvG2+k+N3AGHOKHa7rQowjzxHXspcJZvDraH8dey HV/qnH1IZChRdgtalawLuomfoh9oIMxIOJ+PUy8e+Z8aOsI2lt2FP97V0HwgbcSLkV3ztTohPLtTP B4/p2kng==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1chFZz-0006MC-0j; Fri, 24 Feb 2017 13:06:35 +0000 Received: from dougal.metanate.com ([90.155.101.14] helo=metanate.com) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1chFPb-0006R5-Nn; Fri, 24 Feb 2017 12:56:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=metanate.com; s=stronger; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=mz4BLR+SnFgDbOXVrTBye/QvUIz9lv99RmRNRJW7akg=; b=hfniAIhK8B3tpQfyd76BrS9L1PTH96Ci+L2E8r9tYf3xbUZoZRxJavbn/+/QwslVLYSmvGKOOW4hio2ToDtYy7MLJHhhaUt+LjSzY/CKtQTaF5Cw6rMTy5oncAC6EuykRJy6Sw5cOKfVmfcVM5cIQ7DovcSNtGUeUkJlKOIjPc5B8xivFmMHkb2ITOEg71w7mxlIJCE9hNIXJMCf4xNw+k83p1/kCsYIZACBYqGhFwug77x/8tR9f4aUiI3GsjNfOq6n/AhIU/dsIhd5qaXmH3NPtCYVMCZwomdVKT5sJ5qkLgIKPkuHkBb18Xcw+BPUC3BknQ4QusvVPemtU1af1g==; Received: from brian ([192.168.88.1] helo=leela.metanate.com) by shrek.metanate.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-GCM-SHA256:128) (Exim 4.83_RC2) (envelope-from ) id 1chFP1-0006ml-AN; Fri, 24 Feb 2017 12:55:15 +0000 From: John Keeping To: Mark Yao Subject: [PATCH v4 14/23] drm/rockchip: dw-mipi-dsi: ensure PHY is reset Date: Fri, 24 Feb 2017 12:54:57 +0000 Message-Id: <20170224125506.21533-15-john@metanate.com> X-Mailer: git-send-email 2.12.0.rc0.230.gf625d4cdb9.dirty In-Reply-To: <20170224125506.21533-1-john@metanate.com> References: <20170224125506.21533-1-john@metanate.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170224_045552_307080_101CF42F X-CRM114-Status: UNSURE ( 7.61 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Sean Paul , Chris Zhong , John Keeping , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Also don't power up the DSI host at this point since this is not necessary in order to configure the PHY and we do so later when selecting video or command mode. Signed-off-by: John Keeping Reviewed-by: Chris Zhong Reviewed-by: Sean Paul --- v4: - Add Sean's Reviewed-by v3: - Add Chris' Reviewed-by Unchanged in v2 --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c index 0f9be41f0361..78d676b7e516 100644 --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c @@ -397,7 +397,10 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi *dsi) return testdin; } - dsi_write(dsi, DSI_PWR_UP, POWERUP); + /* Start by clearing PHY state */ + dsi_write(dsi, DSI_PHY_TST_CTRL0, PHY_UNTESTCLR); + dsi_write(dsi, DSI_PHY_TST_CTRL0, PHY_TESTCLR); + dsi_write(dsi, DSI_PHY_TST_CTRL0, PHY_UNTESTCLR); dw_mipi_dsi_phy_write(dsi, 0x10, BYPASS_VCO_RANGE | VCO_RANGE_CON_SEL(vco) |