From patchwork Fri Mar 3 00:30:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 9601833 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5EB3E6016C for ; Fri, 3 Mar 2017 00:31:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4E1FD285EF for ; Fri, 3 Mar 2017 00:31:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 40E482861B; Fri, 3 Mar 2017 00:31:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A153A285EF for ; Fri, 3 Mar 2017 00:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From :Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=XWr0b3EZDRDsJ3aUmPsNmwxmIdAf8na6/L9wBiWNy2E=; b=WMkZDl5MhhYyeP sTsoi2J24mJ4UHN5YJdzUaGulZMKOk6/Yeknka6sDVzWcRLnDQz5lrbDJUa8uqRyM25rln1IbcYRK OXTny0wx5leZhOYyMQRGHA96sgRtsWniN3HxCli8+jg7gS5ZZwLkJonnsjqB+BhQwpD36Sg8ceLNX Xa0WXDQfqdw6xfS7y6OnZcYqll1wVL0vQMN4FGpnDMj1WxI3Z/T3Yx6SUQ4mFSEXjsRzGhMeN6dzK kYMK3n2RBar9p0U6K8cKy1FT36iTRwvw8sqbeOcLo8kWomeGMov/8xm9Ek6fnBAk/uJkqhwQmBWfH dM/5ECGyAVWXPLm/zfVA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cjb7y-0003nT-Dz; Fri, 03 Mar 2017 00:31:22 +0000 Received: from mail-pg0-x232.google.com ([2607:f8b0:400e:c05::232]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cjb7Y-0003mc-SA for linux-arm-kernel@lists.infradead.org; Fri, 03 Mar 2017 00:30:59 +0000 Received: by mail-pg0-x232.google.com with SMTP id s67so37541299pgb.3 for ; Thu, 02 Mar 2017 16:30:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=7q8uQhmbw8hfHljU/fjVJq1auvfYCEGqwgfpfAXQ5+0=; b=RFsDwMa1R1Bnh5CmPV5rtuRtlftqCHznV6oJtE1Fh/BsQzcYnpGXbU2kEe7HzismLh iSVGzXXeNfdNicku4WjiaCTOp430tgZXZ6Yx9zMrbtyqtyrJ9jIqLbuXGL2gyeTZGBMV phBidSLcoCRzZZ8cRJa4NdjLjtIzQbfB8f5P8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=7q8uQhmbw8hfHljU/fjVJq1auvfYCEGqwgfpfAXQ5+0=; b=Jl0Q0NNUobt/23asJaemzK4scOVs2OdEtwQPE5HdlBp0oL1aaK3bAcdgImO+TyqrOG XN+pu/zbI8qsYqDpHI73JGGlaPb22Ws0mc38QzXb2kh4Q6+kiU0e16S0xcQKHbN45xoM cgAymCgKzkbvJKIyzF3QyIRLEoOzbOhbTlMr9yA0xt6O/GnLkRh2QpsQ84uprHvjso7A 2RAV5EBqyx42NaF4HTDrrD7tJAEZgYbT8SVt3flkuJDORVno39mMY/G3FvBaURh+QjsU ee4PiVTRUF0vW8lbuHZUObBYML+4TWt9ddrKLsb0UEq2i4XsFqccltmtiCVX4VaU1NHu 5azw== X-Gm-Message-State: AMke39kfZxbiWLCY9klQ9rvXdAMKgMgacMTwdk0fwdym4EgYJ8CZPRq3vHZohaUsn/+Yc3U1 X-Received: by 10.98.196.221 with SMTP id h90mr18682437pfk.149.1488501035524; Thu, 02 Mar 2017 16:30:35 -0800 (PST) Received: from www.outflux.net ([2002:ada4:7085:0:709b:ceaf:5349:a597]) by smtp.gmail.com with ESMTPSA id b195sm19204644pfb.106.2017.03.02.16.30.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Mar 2017 16:30:34 -0800 (PST) Date: Thu, 2 Mar 2017 16:30:33 -0800 From: Kees Cook To: Russell King Subject: [PATCH v2] ARM: ptdump: Add domain to output Message-ID: <20170303003033.GA92641@beast> MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170302_163056_969826_4283472A X-CRM114-Status: GOOD ( 17.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Afzal Mohammed , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-hardening@lists.openwall.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This adds the memory domain (on non-LPAE) to the PMD and PTE dumps. This isn't in the regular PMD bit struct because I couldn't find a clean way to fall back to retain some of the PMD bits when reporting PTE. So this is special-cased for now. New output example: ---[ Modules ]--- 0x7f000000-0x7f001000 4K DOMAIN_KERNEL ro x SHD MEM/CACHED/WBWA 0x7f001000-0x7f002000 4K DOMAIN_KERNEL ro NX SHD MEM/CACHED/WBWA 0x7f002000-0x7f004000 8K DOMAIN_KERNEL RW NX SHD MEM/CACHED/WBWA ---[ Kernel Mapping ]--- 0x80000000-0x80100000 1M DOMAIN_KERNEL RW NX SHD 0x80100000-0x80800000 7M DOMAIN_KERNEL ro x SHD 0x80800000-0x80b00000 3M DOMAIN_KERNEL ro NX SHD 0x80b00000-0xa0000000 501M DOMAIN_KERNEL RW NX SHD ... ---[ Vectors ]--- 0xffff0000-0xffff1000 4K DOMAIN_VECTORS USR ro x SHD MEM/CACHED/WBWA 0xffff1000-0xffff2000 4K DOMAIN_VECTORS ro x SHD MEM/CACHED/WBWA Signed-off-by: Kees Cook --- This actually works correctly now (tested by forcing different domains on portions of the Kernel Mapping. I really wanted to find a way to use the existing bit structs, but I couldn't make anything work... I'm open to ideas. --- arch/arm/mm/dump.c | 54 ++++++++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 44 insertions(+), 10 deletions(-) diff --git a/arch/arm/mm/dump.c b/arch/arm/mm/dump.c index 21192d6eda40..3770d9f83bdc 100644 --- a/arch/arm/mm/dump.c +++ b/arch/arm/mm/dump.c @@ -17,6 +17,7 @@ #include #include +#include #include #include #include @@ -43,6 +44,7 @@ struct pg_state { unsigned long start_address; unsigned level; u64 current_prot; + const char *current_domain; }; struct prot_bits { @@ -216,7 +218,8 @@ static void dump_prot(struct pg_state *st, const struct prot_bits *bits, size_t } } -static void note_page(struct pg_state *st, unsigned long addr, unsigned level, u64 val) +static void note_page(struct pg_state *st, unsigned long addr, unsigned level, + u64 val, const char *domain) { static const char units[] = "KMGTPE"; u64 prot = val & pg_level[level].mask; @@ -224,8 +227,10 @@ static void note_page(struct pg_state *st, unsigned long addr, unsigned level, u if (!st->level) { st->level = level; st->current_prot = prot; + st->current_domain = domain; seq_printf(st->seq, "---[ %s ]---\n", st->marker->name); } else if (prot != st->current_prot || level != st->level || + domain != st->current_domain || addr >= st->marker[1].start_address) { const char *unit = units; unsigned long delta; @@ -240,6 +245,8 @@ static void note_page(struct pg_state *st, unsigned long addr, unsigned level, u unit++; } seq_printf(st->seq, "%9lu%c", delta, *unit); + if (st->current_domain) + seq_printf(st->seq, " %s", st->current_domain); if (pg_level[st->level].bits) dump_prot(st, pg_level[st->level].bits, pg_level[st->level].num); seq_printf(st->seq, "\n"); @@ -251,11 +258,13 @@ static void note_page(struct pg_state *st, unsigned long addr, unsigned level, u } st->start_address = addr; st->current_prot = prot; + st->current_domain = domain; st->level = level; } } -static void walk_pte(struct pg_state *st, pmd_t *pmd, unsigned long start) +static void walk_pte(struct pg_state *st, pmd_t *pmd, unsigned long start, + const char *domain) { pte_t *pte = pte_offset_kernel(pmd, 0); unsigned long addr; @@ -263,25 +272,50 @@ static void walk_pte(struct pg_state *st, pmd_t *pmd, unsigned long start) for (i = 0; i < PTRS_PER_PTE; i++, pte++) { addr = start + i * PAGE_SIZE; - note_page(st, addr, 4, pte_val(*pte)); + note_page(st, addr, 4, pte_val(*pte), domain); } } +static const char *get_domain_name(pmd_t *pmd) +{ +#ifndef CONFIG_ARM_LPAE + switch (pmd_val(*pmd) & PMD_DOMAIN_MASK) { + case PMD_DOMAIN(DOMAIN_KERNEL): + return "DOMAIN_KERNEL "; + case PMD_DOMAIN(DOMAIN_USER): + return "DOMAIN_USER "; + case PMD_DOMAIN(DOMAIN_IO): + return "DOMAIN_IO "; + case PMD_DOMAIN(DOMAIN_VECTORS): + return "DOMAIN_VECTORS"; + default: + return "DOMAIN_unknown"; + } +#endif + return NULL; +} + static void walk_pmd(struct pg_state *st, pud_t *pud, unsigned long start) { pmd_t *pmd = pmd_offset(pud, 0); unsigned long addr; unsigned i; + const char *domain; for (i = 0; i < PTRS_PER_PMD; i++, pmd++) { addr = start + i * PMD_SIZE; + domain = get_domain_name(pmd); if (pmd_none(*pmd) || pmd_large(*pmd) || !pmd_present(*pmd)) - note_page(st, addr, 3, pmd_val(*pmd)); + note_page(st, addr, 3, pmd_val(*pmd), domain); else - walk_pte(st, pmd, addr); + walk_pte(st, pmd, addr, domain); - if (SECTION_SIZE < PMD_SIZE && pmd_large(pmd[1])) - note_page(st, addr + SECTION_SIZE, 3, pmd_val(pmd[1])); + if (SECTION_SIZE < PMD_SIZE && pmd_large(pmd[1])) { + addr += SECTION_SIZE; + pmd++; + domain = get_domain_name(pmd); + note_page(st, addr, 3, pmd_val(*pmd), domain); + } } } @@ -296,7 +330,7 @@ static void walk_pud(struct pg_state *st, pgd_t *pgd, unsigned long start) if (!pud_none(*pud)) { walk_pmd(st, pud, addr); } else { - note_page(st, addr, 2, pud_val(*pud)); + note_page(st, addr, 2, pud_val(*pud), NULL); } } } @@ -317,11 +351,11 @@ static void walk_pgd(struct seq_file *m) if (!pgd_none(*pgd)) { walk_pud(&st, pgd, addr); } else { - note_page(&st, addr, 1, pgd_val(*pgd)); + note_page(&st, addr, 1, pgd_val(*pgd), NULL); } } - note_page(&st, 0, 0, 0); + note_page(&st, 0, 0, 0, NULL); } static int ptdump_show(struct seq_file *m, void *v)