| Message ID | 20170324064318.GD12604@b29396-OptiPlex-7040 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 2017-03-24 at 14:43 +0800, Dong Aisheng wrote: > Hi Leonard, > > On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote: > > > > The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY. > > Add this driver to the default imx config since the device is present on > > one of the evaluation boards. > Upstream currently no evaluation board support. > > This may leave to Shawn to decide whether apply it. Really? But the dts for this eval board is included in upstream. Shouldn't the default config try to work with the default imx*.dts files included? > > This used to work mostly fine with the generic phy driver but since > > commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer > I guess you should get a checkpatch error here. Because I didn't reference that other commit right? Sorry about this. Should I submit again with an improved commit message? > > performs a soft reset on startup. This causes netboot to sometimes > > timeout on DHCP because RX doesn't work right. DHCP is eventually retried > > and > Probably another checkpatch warning. Why, line too long? > > This was generated with "make savedefconfig" and it includes a few > > additional minor cleanups. > > > It is a bit strange, after apply your patch, i still get a lot difference > as follows when savedefconfig: > > I don't know what's wrong. Toolchains difference? Maybe, kconfig acts strangely sometimes. It's not clear option ordering is guaranteed to be stable. I don't think it matters though. -- Regards, Leonard
On Tue, Mar 28, 2017 at 02:16:50PM +0300, Leonard Crestez wrote: > On Fri, 2017-03-24 at 14:43 +0800, Dong Aisheng wrote: > > Hi Leonard, > > > > On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote: > > > > > > The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY. > > > Add this driver to the default imx config since the device is present on > > > one of the evaluation boards. > > Upstream currently no evaluation board support. > > > > This may leave to Shawn to decide whether apply it. > > Really? But the dts for this eval board is included in upstream. Shouldn't the > default config try to work with the default imx*.dts files included? > > > > This used to work mostly fine with the generic phy driver but since > > > commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer > > I guess you should get a checkpatch error here. > > Because I didn't reference that other commit right? Sorry about this. > > Should I submit again with an improved commit message? Yes, please, and make sure that checkpatch.pl is happy about the patch. Shawn
On Tue, Mar 28, 2017 at 02:16:50PM +0300, Leonard Crestez wrote: > On Fri, 2017-03-24 at 14:43 +0800, Dong Aisheng wrote: > > Hi Leonard, > > > > On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote: > > > > > > The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY. > > > Add this driver to the default imx config since the device is present on > > > one of the evaluation boards. > > Upstream currently no evaluation board support. > > > > This may leave to Shawn to decide whether apply it. > > Really? But the dts for this eval board is included in upstream. Shouldn't the > default config try to work with the default imx*.dts files included? > Oh.. i saw the board wrong, sorry for the noise. Regards Dong Aisheng > > > This used to work mostly fine with the generic phy driver but since > > > commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer > > I guess you should get a checkpatch error here. > > Because I didn't reference that other commit right? Sorry about this. > > Should I submit again with an improved commit message? > > > > performs a soft reset on startup. This causes netboot to sometimes > > > timeout on DHCP because RX doesn't work right. DHCP is eventually retried > > > and > > Probably another checkpatch warning. > > Why, line too long? > > > > This was generated with "make savedefconfig" and it includes a few > > > additional minor cleanups. > > > > > It is a bit strange, after apply your patch, i still get a lot difference > > as follows when savedefconfig: > > > > I don't know what's wrong. Toolchains difference? > > Maybe, kconfig acts strangely sometimes. It's not clear option ordering is > guaranteed to be stable. I don't think it matters though. > > -- > Regards, > Leonard
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index bb6fa56..64e5f4b 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -163,9 +163,9 @@ CONFIG_MOUSE_PS2_ELANTECH=y CONFIG_INPUT_TOUCHSCREEN=y CONFIG_TOUCHSCREEN_ADS7846=y CONFIG_TOUCHSCREEN_EGALAX=y +CONFIG_TOUCHSCREEN_MAX11801=y CONFIG_TOUCHSCREEN_IMX6UL_TSC=y CONFIG_TOUCHSCREEN_EDT_FT5X06=y -CONFIG_TOUCHSCREEN_MAX11801=y CONFIG_TOUCHSCREEN_MC13783=y CONFIG_TOUCHSCREEN_TSC2004=y CONFIG_TOUCHSCREEN_TSC2007=y @@ -174,7 +174,6 @@ CONFIG_TOUCHSCREEN_SX8654=y CONFIG_TOUCHSCREEN_COLIBRI_VF50=y CONFIG_INPUT_MISC=y CONFIG_INPUT_MMA8450=y -CONFIG_HID_MULTITOUCH=y CONFIG_SERIO_SERPORT=m # CONFIG_LEGACY_PTYS is not set CONFIG_SERIAL_IMX=y @@ -268,6 +267,7 @@ CONFIG_SND_SOC_CS42XX8_I2C=y CONFIG_SND_SOC_TLV320AIC3X=y CONFIG_SND_SOC_WM8960=y CONFIG_SND_SIMPLE_CARD=y +CONFIG_HID_MULTITOUCH=y CONFIG_USB=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_MXC=y