From patchwork Fri Mar 24 06:43:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dong Aisheng X-Patchwork-Id: 9641337 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9A65B6020B for ; Thu, 23 Mar 2017 14:47:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 89ED2206E2 for ; Thu, 23 Mar 2017 14:47:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7BEF223B23; Thu, 23 Mar 2017 14:47:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=2.0 tests=BAYES_00, DATE_IN_FUTURE_12_24, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM autolearn=no version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 036AC206E2 for ; Thu, 23 Mar 2017 14:47:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3QqTgaMO505NXLhx2JKIcCTkyS2DvOMmOng5VqdgzVo=; b=cRnzY8qc1mpUW/ llVWUY4SOk3hxsT/E+HBBVDmZ+7yHvgVdtpvhkYuVxMqPxsDmbR5oNicL2hwsBOBWE7fMex2UhwXv 9NSi6ML0L5WYiVqomwr/M+DQmjaF4tcqY81vcH72VXCVumhHfQ+nf5htWyRpLZa0Wq34bPk1Irz2Z 6EBJ+xBuFARbcWVrXC4uSluRTahkd6fmPx1CB9DOYZ12KzsB4tgqCvw7OFWM1vGsjnev/Jsj45J/x qmIocy5ff4VuoPBNxnMAWChPXcZGInOOur/8+XRkn4luxVXJSJWY0VE9rCVfDp1w9TrFGOkJo4c8z AwmKeQ324EfxsdUEEOaA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cr40z-0002EK-0L; Thu, 23 Mar 2017 14:47:01 +0000 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cr40u-0002BX-Ox for linux-arm-kernel@lists.infradead.org; Thu, 23 Mar 2017 14:46:58 +0000 Received: by mail-pf0-x242.google.com with SMTP id p189so26757779pfp.0 for ; Thu, 23 Mar 2017 07:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+BemgPj1Fs/AEIKkj8UJjBIX7kBgQY6J5qn+P6gabe8=; b=NjYJKsevbt2zSm/p+NX+cvFtz1GfHnIl9v6VkD0puDVL7HDNWjaftIG0iH79dV45JO 5Qu2AGD8614MRTbrz6yxh+WjCX1Dlnsc1Sxap+F+e8VfdIZmOTBZGfcz/00afv23r1VY +Wo3+kZPkvaZYdPxkvq2YF5WylfSyPFjLv/LpeaC98tEvys2HgLItYgUYdXjzL3HyRnE 4pVi3LL59Xd0oHjh+zksaLyArwUXZrcg3be/uLegREDm9hbY+OU5q18w1h11iKqigzHH VymXvLyFaVXA9Qk97Jni0WX2Y7JgWl4T6mgpLnYAo5yYj2H/1sRI+9rFTTIVJ5f6tSu0 /iBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+BemgPj1Fs/AEIKkj8UJjBIX7kBgQY6J5qn+P6gabe8=; b=BTI3H4kU9GYDRJOqNX35Qd8OzNJcHld6z2klog5iZohE6KB9BRN27NHxMQBkB7C2tX rnDNbfNTSbvq9RKmhAHSjpyT7CKoJNNJWNAZaZu1XdgqRSwL7uGvWsNsElKTzn5L69vI Xbsa7AtLC6MY7N9dP9EUTQOmC5BFGOfF8KskgfJUhfC0ijnAO/jnSRQ9z6kzKe6sK/mA HA+c9ANdfgWK3dtVq+W8lXsXPRCB0h5dAPrJ8vTSUjPYRGhjNBM46v3a0gKY13r/yJP4 ZjGQolM/WSn+2GCsW7xhULtY6PM6jQGAR89NZuQimavpejMMGu8f1D4dieqK5EFU8O4S Nong== X-Gm-Message-State: AFeK/H1jvxe5xHjS9drHTyIsbHRg9lwx84tDaKBoHGzd9vJmTBIVkU1FMRf+XdwlLY7bcg== X-Received: by 10.84.129.2 with SMTP id 2mr4025444plb.119.1490280396260; Thu, 23 Mar 2017 07:46:36 -0700 (PDT) Received: from b29396-OptiPlex-7040 (gate-zmy3.freescale.com. [192.88.167.1]) by smtp.gmail.com with ESMTPSA id 78sm10838716pfm.122.2017.03.23.07.46.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Mar 2017 07:46:35 -0700 (PDT) Date: Fri, 24 Mar 2017 14:43:18 +0800 From: Dong Aisheng To: Leonard Crestez Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY Message-ID: <20170324064318.GD12604@b29396-OptiPlex-7040> References: <82d0aeeaed87ae5c9390b889cef4c54d715cde61.1490191972.git.leonard.crestez@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <82d0aeeaed87ae5c9390b889cef4c54d715cde61.1490191972.git.leonard.crestez@nxp.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170323_074656_849449_819DBDD9 X-CRM114-Status: GOOD ( 22.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Fugang Duan , linux-kernel@vger.kernel.org, Octavian Purdila , Sascha Hauer , Fabio Estevam , Shawn Guo , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Leonard, On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote: > The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY. > Add this driver to the default imx config since the device is present on > one of the evaluation boards. Upstream currently no evaluation board support. This may leave to Shawn to decide whether apply it. > > This used to work mostly fine with the generic phy driver but since > commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer I guess you should get a checkpatch error here. > performs a soft reset on startup. This causes netboot to sometimes > timeout on DHCP because RX doesn't work right. DHCP is eventually retried and Probably another checkpatch warning. > it works the second time but it takes 90+ seconds to get a login prompt. > > This was generated with "make savedefconfig" and it includes a few > additional minor cleanups. > It is a bit strange, after apply your patch, i still get a lot difference as follows when savedefconfig: I don't know what's wrong. Toolchains difference? Quite strange... Regards Dong Aisheng > Signed-off-by: Leonard Crestez > --- > > I also tried to do some debugging in the fec driver and it apparently receives > corrupted packets when this happens. If I hack it to go into promiscuous mode > unconditionally it gets a whole bunch of rx errors (crc errors, length errors > and so on). So the phy config is probably wrong and is confusing the mac? > > In theory it might be possible to make that driver "just work" with phy > settings from uboot but it's not clear it's worthwhile. > > arch/arm/configs/imx_v6_v7_defconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig > index eaba3b1..e605389 100644 > --- a/arch/arm/configs/imx_v6_v7_defconfig > +++ b/arch/arm/configs/imx_v6_v7_defconfig > @@ -143,6 +143,7 @@ CONFIG_SMSC911X=y > # CONFIG_NET_VENDOR_STMICRO is not set > CONFIG_AT803X_PHY=y > CONFIG_MICREL_PHY=y > +CONFIG_SMSC_PHY=y > CONFIG_USB_PEGASUS=m > CONFIG_USB_RTL8150=m > CONFIG_USB_RTL8152=m > @@ -152,7 +153,6 @@ CONFIG_BRCMFMAC=m > CONFIG_WL12XX=m > CONFIG_WLCORE_SDIO=m > # CONFIG_WILINK_PLATFORM_DATA is not set > -# CONFIG_INPUT_MOUSEDEV_PSAUX is not set > CONFIG_INPUT_EVDEV=y > CONFIG_INPUT_EVBUG=m > CONFIG_KEYBOARD_GPIO=y > @@ -376,7 +376,6 @@ CONFIG_NLS_ISO8859_1=y > CONFIG_NLS_ISO8859_15=m > CONFIG_NLS_UTF8=y > CONFIG_PRINTK_TIME=y > -CONFIG_DEBUG_FS=y > CONFIG_MAGIC_SYSRQ=y > # CONFIG_SCHED_DEBUG is not set > CONFIG_PROVE_LOCKING=y > -- > 2.7.4 > diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index bb6fa56..64e5f4b 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -163,9 +163,9 @@ CONFIG_MOUSE_PS2_ELANTECH=y CONFIG_INPUT_TOUCHSCREEN=y CONFIG_TOUCHSCREEN_ADS7846=y CONFIG_TOUCHSCREEN_EGALAX=y +CONFIG_TOUCHSCREEN_MAX11801=y CONFIG_TOUCHSCREEN_IMX6UL_TSC=y CONFIG_TOUCHSCREEN_EDT_FT5X06=y -CONFIG_TOUCHSCREEN_MAX11801=y CONFIG_TOUCHSCREEN_MC13783=y CONFIG_TOUCHSCREEN_TSC2004=y CONFIG_TOUCHSCREEN_TSC2007=y @@ -174,7 +174,6 @@ CONFIG_TOUCHSCREEN_SX8654=y CONFIG_TOUCHSCREEN_COLIBRI_VF50=y CONFIG_INPUT_MISC=y CONFIG_INPUT_MMA8450=y -CONFIG_HID_MULTITOUCH=y CONFIG_SERIO_SERPORT=m # CONFIG_LEGACY_PTYS is not set CONFIG_SERIAL_IMX=y @@ -268,6 +267,7 @@ CONFIG_SND_SOC_CS42XX8_I2C=y CONFIG_SND_SOC_TLV320AIC3X=y CONFIG_SND_SOC_WM8960=y CONFIG_SND_SIMPLE_CARD=y +CONFIG_HID_MULTITOUCH=y CONFIG_USB=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_MXC=y