From patchwork Mon Mar 27 09:49:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Pieralisi X-Patchwork-Id: 9646245 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 11D64602BF for ; Mon, 27 Mar 2017 10:05:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E8DD2203C0 for ; Mon, 27 Mar 2017 10:05:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DD89B28364; Mon, 27 Mar 2017 10:05:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A2138203C0 for ; Mon, 27 Mar 2017 10:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=vCe8DA++hZi62mhxYHIcQPgYr9kcaf3jTVFm3xk/CMY=; b=GEBpeuW7mE4fr8zKpJyWCj54fF 2V7z2xB7GAKiO3o7Fqiy+IdZHhG33i7mTIdIEWwfWXcMhUUq9Many2oDgluaklGH95QMU7FxMh6gg Poz2A8usRCdbOkl8BMfNxjqbw7MffNuSCSFzvzyRkjEOXiXpxkAfDx1gZmVt83yLRBylrOw70U6QV Sz1xNdnQVVkru8DZ5s7C6wNVVLW/VDTBh/KDSVWaLhS9BIemkHe4r9KRws77myr/VKd7jdeNYagKw poHd21tkqsp1z+c4eJ8WQS8qykoyYY890AO5FUF39tGxeZSDZjrXrfpXzUi24wPR8y2TH/7v9sazw eB+unIiQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1csRWw-0004yR-PP; Mon, 27 Mar 2017 10:05:42 +0000 Received: from merlin.infradead.org ([2001:4978:20e::2]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1csRVl-0002f9-9W for linux-arm-kernel@bombadil.infradead.org; Mon, 27 Mar 2017 10:04:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dey8n4/ow46SRys+AkYaBBPE12TWTATh9Y8ASvoKL4Q=; b=vrsgEEX2QSo8syGqmGGvUW2MO ihMUJjrouRJ8rXALjo/4dniET8tYiSHhQRd6LMQ0jMeZZKJCZYZ3NWJK8lj29/Bg7PTZx69A9gtQW iocoroQrfLT9J70d/0WvWHrQUtzwja32CmaBJQz64y/QQyb+zy03S9IIdNA6mMiqRrL0jD+PteeIQ Lc7fDNYKuHTYKEvXRZiTAds85EUfz8i0/aYB4u0kpSbY//EWj/K8/IK248o4QyNrumpkJSzzEwTS/ V1N673ofpZOXikQlGAK7NSAjjdkZKiuqvM+d66grQbUi2uGm4pxxYMlYXVUhSdf3Hm62JcRmEnZ3f iGSV4bvSQ==; Received: from foss.arm.com ([217.140.101.70]) by merlin.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1csRIU-0007Iv-Sr for linux-arm-kernel@lists.infradead.org; Mon, 27 Mar 2017 09:50:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BF8EF165C; Mon, 27 Mar 2017 02:50:46 -0700 (PDT) Received: from red-moon.cambridge.arm.com (red-moon.cambridge.arm.com [10.1.206.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9890D3F23B; Mon, 27 Mar 2017 02:50:45 -0700 (PDT) From: Lorenzo Pieralisi To: linux-pci@vger.kernel.org Subject: [PATCH v2 16/22] PCI: designware: update PCI config space remap function Date: Mon, 27 Mar 2017 10:49:44 +0100 Message-Id: <20170327094954.7162-17-lorenzo.pieralisi@arm.com> X-Mailer: git-send-email 2.10.0 In-Reply-To: <20170327094954.7162-1-lorenzo.pieralisi@arm.com> References: <20170327094954.7162-1-lorenzo.pieralisi@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170327_055047_013652_BA8AB0A3 X-CRM114-Status: UNSURE ( 8.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joao Pinto , Jingoo Han , linux-kernel@vger.kernel.org, Lorenzo Pieralisi , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP PCI configuration space should be mapped with a memory region type that generates on the CPU host bus non-posted write transations. Update the driver to use the devm_ioremap_nopost* interface to make sure the correct memory mappings for PCI configuration space are used. Signed-off-by: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Jingoo Han Cc: Joao Pinto --- drivers/pci/dwc/pcie-designware-host.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pci/dwc/pcie-designware-host.c b/drivers/pci/dwc/pcie-designware-host.c index 5ba3349..d2dd228 100644 --- a/drivers/pci/dwc/pcie-designware-host.c +++ b/drivers/pci/dwc/pcie-designware-host.c @@ -338,8 +338,8 @@ int dw_pcie_host_init(struct pcie_port *pp) } if (!pci->dbi_base) { - pci->dbi_base = devm_ioremap(dev, pp->cfg->start, - resource_size(pp->cfg)); + pci->dbi_base = devm_ioremap_nopost(dev, pp->cfg->start, + resource_size(pp->cfg)); if (!pci->dbi_base) { dev_err(dev, "error with ioremap\n"); ret = -ENOMEM; @@ -350,8 +350,8 @@ int dw_pcie_host_init(struct pcie_port *pp) pp->mem_base = pp->mem->start; if (!pp->va_cfg0_base) { - pp->va_cfg0_base = devm_ioremap(dev, pp->cfg0_base, - pp->cfg0_size); + pp->va_cfg0_base = devm_ioremap_nopost(dev, pp->cfg0_base, + pp->cfg0_size); if (!pp->va_cfg0_base) { dev_err(dev, "error with ioremap in function\n"); ret = -ENOMEM; @@ -360,8 +360,8 @@ int dw_pcie_host_init(struct pcie_port *pp) } if (!pp->va_cfg1_base) { - pp->va_cfg1_base = devm_ioremap(dev, pp->cfg1_base, - pp->cfg1_size); + pp->va_cfg1_base = devm_ioremap_nopost(dev, pp->cfg1_base, + pp->cfg1_size); if (!pp->va_cfg1_base) { dev_err(dev, "error with ioremap\n"); ret = -ENOMEM;