From patchwork Wed Apr 5 05:28:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ralph Sennhauser X-Patchwork-Id: 9663459 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 072CA60352 for ; Wed, 5 Apr 2017 09:14:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DC2E628556 for ; Wed, 5 Apr 2017 09:14:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D0505285A0; Wed, 5 Apr 2017 09:14:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E151728556 for ; Wed, 5 Apr 2017 09:14:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=dBIntJMyfeM7TK8SfhIi/Mo7ogKZ8p2K0cObG+gyD6E=; b=eOg LXRhy3YA5CxTnqyk11cR1OgOuydhix9T+ToANvEhw2Ap7ISU9AZeO2dze8yTFc2FvNB+K12rcs06I kUQ/4tseFS3Kotb97EVxV8RWy+uQppyr5se8LbRtOZlUzG6A4KMqvWulHKfW21+z1D/yXLV1hKvGg Km2Uc/N76gvJ1t7UmS1opTSn6V6aRdGXREvxHIZg4MROcR4GF3LaCfHuZa6dbU7DRvWCBf+s3ytsC xZK5oXpmjBGmNyhR/8qESEpd1u7tJN2w1FcjdwCYtHQQeT8aqc8Q0Ys2GLq3z7tQ1BIAa12MvwCNt B2P+Wuis2WqOc1z4Gf1jc1YFaq9JfCg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cvh1Q-0004wP-Fb; Wed, 05 Apr 2017 09:14:36 +0000 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cvdVd-0007Ox-Oj for linux-arm-kernel@lists.infradead.org; Wed, 05 Apr 2017 05:34:04 +0000 Received: by mail-wm0-x242.google.com with SMTP id z133so723457wmb.2 for ; Tue, 04 Apr 2017 22:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=hCUgjy0gj0eX3Do4VvBbsuzJjSYaux/2w0ITmhF8CTE=; b=CNb7/qy1oXkwV6CnJ0X8ryvrIpQDM5pkPpehpaJDMCHhDRCN1A1FHIGdD9YanBFnK6 lBpDSrWIPy/uPzrtxHE94fpkBheM9HUgCokOo8bDgvo37Xrtuxxc+uC8lhBknxS7kVTt peeC07+EjC3tBOMnTEmLtLBarkprAlBE8TmC9pIun6mjlHH4EoQ7sOx8Q8YCmKbBgWl7 sTPDPriPl+pIU2ZL0euFAwTNCnPliLgAzaGIJltwnw8+jYrmDB3p2aUq58febNxyRiW9 vItKSIyxLwK6fTQT0qO5obJszQOLjcPBbf2aPaM9rHV8JKmIMYkCoDTDN8bvzCv49A7L n/0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=hCUgjy0gj0eX3Do4VvBbsuzJjSYaux/2w0ITmhF8CTE=; b=owPYe6X/U/2NQUwm89auiAkPENPKyJ3H/Y15IbrACpIFzSu+5NRMRiJ+DKDJRNoHGg nvVHQnXSsqWZHjYuqpdYOBUgopQXSNza8pw7m8SraeFDRU/yqmw0VqEQPyn404IMVkRE LVdB/IXApty5p7JskJEzMxuEaeclaTI/sEjz8OiiH1+U3fNU3ZQFVH1cAc89OlIPLArX rz2ZUBb6yJWSyiIpzryTbqRKzNVIr74f4K7V5ZshVO7PKzUuBum9Icr7wOE+haHJGoTZ HgKWGtcnF5jKbFKa3jvmoUgaTBjfidhYe9/bk4Brg7lPvMWOk3SeEHmslBZ0sCreTLRw rShA== X-Gm-Message-State: AFeK/H0LS38Cs6Gsq5pJUpwbfvFeYcvtTInw4ZE0gqgn/ddJb7kMHof/9BWzq9OMebpB0Q== X-Received: by 10.28.18.21 with SMTP id 21mr16814812wms.77.1491370134458; Tue, 04 Apr 2017 22:28:54 -0700 (PDT) Received: from localhost.lan ([37.209.189.139]) by smtp.googlemail.com with ESMTPSA id j138sm10835429wmg.10.2017.04.04.22.28.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 04 Apr 2017 22:28:53 -0700 (PDT) From: Ralph Sennhauser To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port Date: Wed, 5 Apr 2017 07:28:46 +0200 Message-Id: <20170405052847.326-1-ralph.sennhauser@gmail.com> X-Mailer: git-send-email 2.10.2 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, Gregory Clement , Rob Herring , Ralph Sennhauser , Sebastian Hesselbarth MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The LEDs for the "wan" port are already labeled "mamba:amber:wan" resp. "mamba:white:wan". So besides being an outlier with regard to the rest of the product line (see table below) changing the label fixes an internal inconsistency as well. This will be visible in user space. Given commit cb4f71c42988 ("ARM: dts: armada-38x: change order of ethernet DT nodes on Armada 38x") it's expected to happen anyway. Commit 499400c9ac20 ("ARM: dts: armada-xp-linksys-mamba: Utilize new DSA binding") switches to the new bindings, use this opportunity to do it now rather than later. |-----------------------------------------------------------------| | Labels used for the case and those used for the DSA ports | |-----------------------------------------------------------------| | case labels | armada-385-linksys-* | armada-xp-linksys-mamba | |---------------|-----------------------|-------------------------| | internet | wan | internet | | 1 | lan1 | lan1 | | 2 | lan2 | lan2 | | 3 | lan3 | lan3 | | 4 | lan4 | lan4 | |-----------------------------------------------------------------| Signed-off-by: Ralph Sennhauser --- Hi everybody, I underestimated the urge of people to make all the same before. While I do not particularly like this sort of change I see it coming anyway. So this patch is meant to make it a deliberate decision so it no longer is an item lurking in the shadows. Whether this patch gets taken or rejected my goal is reached. In hindsight wan would have been the better choice. Ralph arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts index 9efcf59..0143aed 100644 --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts @@ -354,7 +354,7 @@ port@4 { reg = <4>; - label = "internet"; + label = "wan"; }; port@5 { @@ -452,7 +452,7 @@ port@4 { reg = <4>; - label = "internet"; + label = "wan"; }; port@5 {