| Message ID | 20170418042205.27894-3-wens@csie.org (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
On Tue, Apr 18, 2017 at 12:22:04PM +0800, Chen-Yu Tsai wrote: > Kbuild now complains about leading zeroes in the address portion of > device node names. > > Get rid of them. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > index 913aacafe8d5..82cb87f21b96 100644 > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > @@ -162,7 +162,7 @@ > #size-cells = <1>; > ranges; > > - pio: pinctrl@01c20800 { > + pio: pinctrl@1c20800 { As far as I know this breaks Uboot's auto-addition of stdout-path Maxime >
On Tue, Apr 18, 2017 at 5:03 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Tue, Apr 18, 2017 at 12:22:04PM +0800, Chen-Yu Tsai wrote: >> Kbuild now complains about leading zeroes in the address portion of >> device node names. >> >> Get rid of them. >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >> --- >> arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi >> index 913aacafe8d5..82cb87f21b96 100644 >> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi >> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi >> @@ -162,7 +162,7 @@ >> #size-cells = <1>; >> ranges; >> >> - pio: pinctrl@01c20800 { >> + pio: pinctrl@1c20800 { > > As far as I know this breaks Uboot's auto-addition of stdout-path You're right. It breaks as Uboot has the path to the uarts hard-coded. That sucks. And from what I can tell, it's not easily solvable by just switching to serial alias based references. CONS_INDEX won't line up on the A23/A33 Q8 tablets. Maybe we can just keep the uart device node the same for now, but fix all the other ones. We can come back and fix the uart later once we figure out how to fix Uboot. Regards ChenYu
On Tue, Apr 18, 2017 at 05:22:02PM +0800, Chen-Yu Tsai wrote: > On Tue, Apr 18, 2017 at 5:03 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Tue, Apr 18, 2017 at 12:22:04PM +0800, Chen-Yu Tsai wrote: > >> Kbuild now complains about leading zeroes in the address portion of > >> device node names. > >> > >> Get rid of them. > >> > >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > >> --- > >> arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- > >> 1 file changed, 5 insertions(+), 5 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > >> index 913aacafe8d5..82cb87f21b96 100644 > >> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > >> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > >> @@ -162,7 +162,7 @@ > >> #size-cells = <1>; > >> ranges; > >> > >> - pio: pinctrl@01c20800 { > >> + pio: pinctrl@1c20800 { > > > > As far as I know this breaks Uboot's auto-addition of stdout-path > > You're right. It breaks as Uboot has the path to the uarts hard-coded. > That sucks. And from what I can tell, it's not easily solvable by just > switching to serial alias based references. CONS_INDEX won't line up > on the A23/A33 Q8 tablets. > > Maybe we can just keep the uart device node the same for now, but fix > all the other ones. We can come back and fix the uart later once we > figure out how to fix Uboot. Thinking more about this, I don't really know why we have that in U-Boot actually. All our DTs for a very long time have had stdout-path properly set (and if it's improperly set, this should be fixed). I'd say we can simply remove that from U-Boot and be done with it. Maxime
diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index 913aacafe8d5..82cb87f21b96 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -162,7 +162,7 @@ #size-cells = <1>; ranges; - pio: pinctrl@01c20800 { + pio: pinctrl@1c20800 { compatible = "allwinner,sun8i-a83t-pinctrl"; interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>, @@ -193,7 +193,7 @@ }; }; - timer@01c20c00 { + timer@1c20c00 { compatible = "allwinner,sun4i-a10-timer"; reg = <0x01c20c00 0xa0>; interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>, @@ -201,14 +201,14 @@ clocks = <&osc24M>; }; - watchdog@01c20ca0 { + watchdog@1c20ca0 { compatible = "allwinner,sun6i-a31-wdt"; reg = <0x01c20ca0 0x20>; interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; clocks = <&osc24M>; }; - uart0: serial@01c28000 { + uart0: serial@1c28000 { compatible = "snps,dw-apb-uart"; reg = <0x01c28000 0x400>; interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; @@ -218,7 +218,7 @@ status = "disabled"; }; - gic: interrupt-controller@01c81000 { + gic: interrupt-controller@1c81000 { compatible = "arm,cortex-a7-gic", "arm,cortex-a15-gic"; reg = <0x01c81000 0x1000>, <0x01c82000 0x2000>,
Kbuild now complains about leading zeroes in the address portion of device node names. Get rid of them. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)