| Message ID | 20170501224559.21028-1-edu.molinas@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, May 2, 2017 at 6:45 AM, Eduardo Molinas <edu.molinas@gmail.com> wrote: > If the driver is built as a module, it won't be autloaded if the devices > are registered via PLATFORM code because the PLATFORM device table > entries are not exported as aliases > > Before the patch: > $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias > $ > > After th patch: ^^ the > $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias > alias: platform:sun6i-a31-gpadc-iio > alias: platform:sun5i-a13-gpadc-iio > alias: platform:sun4i-a10-gpadc-iio > > Signed-off-by: Eduardo Molinas <edu.molinas@gmail.com> Acked-by: Chen-Yu Tsai <wens@csie.org> Can we merge this as a fix for 4.12?
On 02/05/17 03:10, Chen-Yu Tsai wrote: > On Tue, May 2, 2017 at 6:45 AM, Eduardo Molinas <edu.molinas@gmail.com> wrote: >> If the driver is built as a module, it won't be autloaded if the devices >> are registered via PLATFORM code because the PLATFORM device table >> entries are not exported as aliases >> >> Before the patch: >> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias >> $ >> >> After th patch: > > ^^ the > >> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias >> alias: platform:sun6i-a31-gpadc-iio >> alias: platform:sun5i-a13-gpadc-iio >> alias: platform:sun4i-a10-gpadc-iio >> >> Signed-off-by: Eduardo Molinas <edu.molinas@gmail.com> > > Acked-by: Chen-Yu Tsai <wens@csie.org> > > Can we merge this as a fix for 4.12? Applied to fixes-togreg branch of iio.git. Thanks, Jonathan >
diff --git a/drivers/iio/adc/sun4i-gpadc-iio.c b/drivers/iio/adc/sun4i-gpadc-iio.c index b23527309088..c3d7ba100a48 100644 --- a/drivers/iio/adc/sun4i-gpadc-iio.c +++ b/drivers/iio/adc/sun4i-gpadc-iio.c @@ -700,6 +700,7 @@ static const struct platform_device_id sun4i_gpadc_id[] = { { "sun6i-a31-gpadc-iio", (kernel_ulong_t)&sun6i_gpadc_data }, { /* sentinel */ }, }; +MODULE_DEVICE_TABLE(platform, sun4i_gpadc_id); static struct platform_driver sun4i_gpadc_driver = { .driver = {
If the driver is built as a module, it won't be autloaded if the devices are registered via PLATFORM code because the PLATFORM device table entries are not exported as aliases Before the patch: $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias $ After th patch: $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias alias: platform:sun6i-a31-gpadc-iio alias: platform:sun5i-a13-gpadc-iio alias: platform:sun4i-a10-gpadc-iio Signed-off-by: Eduardo Molinas <edu.molinas@gmail.com> --- --- drivers/iio/adc/sun4i-gpadc-iio.c | 1 + 1 file changed, 1 insertion(+)