diff mbox

clk: sunxi-ng: explicitly include linux/spinlock.h

Message ID 20170515102307.28743-1-tklauser@distanz.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Tobias Klauser May 15, 2017, 10:23 a.m. UTC 
ccu_reset.h and ccu_reset.c use spinlock_t and associated functions but
rely on implict inclusion of linux/spinlock.h which means that changes
in other headers could break the build. Thus, add an explicit include.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 drivers/clk/sunxi-ng/ccu_reset.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Chen-Yu Tsai May 15, 2017, 10:25 a.m. UTC | #1 
On Mon, May 15, 2017 at 6:23 PM, Tobias Klauser <tklauser@distanz.ch> wrote:
> ccu_reset.h and ccu_reset.c use spinlock_t and associated functions but
> rely on implict inclusion of linux/spinlock.h which means that changes
> in other headers could break the build. Thus, add an explicit include.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

Acked-by: Chen-Yu Tsai <wens@csie.org>
Maxime Ripard May 16, 2017, 5:05 p.m. UTC | #2 
On Mon, May 15, 2017 at 12:23:07PM +0200, Tobias Klauser wrote:
> ccu_reset.h and ccu_reset.c use spinlock_t and associated functions but
> rely on implict inclusion of linux/spinlock.h which means that changes
> in other headers could break the build. Thus, add an explicit include.
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

Applied, thanks!
Maxime
diff mbox

Patch

diff --git a/drivers/clk/sunxi-ng/ccu_reset.h b/drivers/clk/sunxi-ng/ccu_reset.h
index 36a4679210bd..ff8f5ebca435 100644
--- a/drivers/clk/sunxi-ng/ccu_reset.h
+++ b/drivers/clk/sunxi-ng/ccu_reset.h
@@ -15,6 +15,7 @@ 
 #define _CCU_RESET_H_
 
 #include <linux/reset-controller.h>
+#include <linux/spinlock.h>
 
 struct ccu_reset_map {
 	u16	reg;