From patchwork Thu May 18 15:55:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9734715 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BCA03601C8 for ; Thu, 18 May 2017 15:55:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9CD3C28897 for ; Thu, 18 May 2017 15:55:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8D2A72888D; Thu, 18 May 2017 15:55:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 074902888D for ; Thu, 18 May 2017 15:55:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=KokoJOqMbb7L3fsdrpCh5fRlW/ax4KVHFdjREIamGxg=; b=PFg3dAGIcqTtsh FvRJkBTvYTKopFE5qhjo1dZe/85H6eToGCM/ePu9i5ofajCFAy560w88OoFemrqCIwy/21ai+07OH PVfyLuMetPSzKs5S8Un24x3Lvwis8h+TxEcdNBtA81Uv9YVY9H0CxClpKLTo7tNfqwqg0XzzxKt/G fIdqS2DKJtH0VIr9i6a4fl5ElLk1Q+wiVk8rEivuZocyq+Q1mZhfawUFHiOFeve6WXF4stZS7jB6N 8rWfNSqiPba9o7FGyLwbf0+A360WmS7naUHukgtAZyiQ6Dl8965Rql3dfhLfJffFC/yT1VzOwkY2A hmXYa5+Br/LJir8w8uqg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dBNmK-0002xK-Cb; Thu, 18 May 2017 15:55:52 +0000 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dBNmG-0002vW-6U for linux-arm-kernel@lists.infradead.org; Thu, 18 May 2017 15:55:49 +0000 Received: by mail-pf0-x242.google.com with SMTP id n23so6241028pfb.3 for ; Thu, 18 May 2017 08:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/klBOvZsXMDn3gZCfiXF475+Wd6YYVSevVCZXaQS19g=; b=kLgDfdZi1mNrEvtC07MVlwB4GzPpPZQ3eM9YQ8ERVz88gHElZdvZmN2zHAN/oxqkQ5 DdfSjnMTvLZT2g6OdUH5R4ikONaEo+6DASGXrwI5mzGZLv85ljp3j5+Rrv+0GnrAsXUe AIuz0uG/95Gl2qZGTXBflzBXUCXjqt2EOX/mP2NA6KEz3GRD2rHp5VQJqYW2S8OUywW0 ZY6YrBQhf0yb9z2j8C9Myhljjty8FfxxmkL2i2yL5a3dOhLUBim+BoLVe0Ov6tp/4SHG M6CPU4NItf8r/K1RLSz2xfvd2yLRr5Uk5ydHIS6DL8WVaxratQFZrLWCU5hdXjOopr8X U0qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/klBOvZsXMDn3gZCfiXF475+Wd6YYVSevVCZXaQS19g=; b=Nt8GAu2t7mgWxmmPuAV1Vgdr2ygFZ7+/iG5KV6r5h/cgjJCiu11+8MLPo25NUal3to LV76frR9VB7KsjviePKrIdpUYuGUoMduvCqnUiw2c82/x9nAk9y0ndYiquqrE0mWDGoM 8zYiilimea5nRShJXX9gLdTduSzI3K2zpV+qa9PQ6f/cgNK+x2yYTWWzyRDOiz1tgVqS JVCkoNB3OaIX4+WAEqZabj8ruYYKU/dMHwvNU+PcSnlaiO6tkxzXKsl5zAUiRZXqMAss kKLEqg7L6K+PbI7wiJmi7bywbM98VRsw2IjsO/nLqHZSRPFRGT7gnYdUPKx+mPSe6MAQ +n8g== X-Gm-Message-State: AODbwcCgCGcpZOtXqsiORg6RPOJ5UpEBf+hb3FEFLhKMDGCcQAbgNPbI 0ij5nGjxZRW6bQ== X-Received: by 10.99.52.70 with SMTP id b67mr5333938pga.44.1495122926799; Thu, 18 May 2017 08:55:26 -0700 (PDT) Received: from 192.168.0.37 (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id o194sm10990943pfg.117.2017.05.18.08.55.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 May 2017 08:55:26 -0700 (PDT) From: Wei Yongjun To: Maxime Ripard , Chen-Yu Tsai , Michael Turquette , Stephen Boyd , Icenowy Zheng Subject: [PATCH -next] clk: sunxi-ng: de2: fix wrong pointer passed to PTR_ERR() Date: Thu, 18 May 2017 15:55:13 +0000 Message-Id: <20170518155513.29628-1-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170518_085548_286968_98232D66 X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wei Yongjun , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun PTR_ERR should access the value just tested by IS_ERR, otherwise the wrong error code will be returned. Fixes: b0d9a4bd52bd ("clk: sunxi-ng: add support for DE2 CCU") Signed-off-by: Wei Yongjun --- drivers/clk/sunxi-ng/ccu-sun8i-de2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-de2.c b/drivers/clk/sunxi-ng/ccu-sun8i-de2.c index 15aaa9c..5cdaf52 100644 --- a/drivers/clk/sunxi-ng/ccu-sun8i-de2.c +++ b/drivers/clk/sunxi-ng/ccu-sun8i-de2.c @@ -184,7 +184,7 @@ static int sunxi_de2_clk_probe(struct platform_device *pdev) rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL); if (IS_ERR(rstc)) { - ret = PTR_ERR(bus_clk); + ret = PTR_ERR(rstc); if (ret != -EPROBE_DEFER) dev_err(&pdev->dev, "Couldn't get reset control: %d\n", ret);