| Message ID | 20170519213550.8434-3-geomatsi@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Sergey, On Sat, May 20, 2017 at 12:35:50AM +0300, Sergey Matyukevich wrote: > Enable SPI NOR on orange-pi-zero board. > > For more information see: > - http://linux-sunxi.org/Orange_Pi_Zero#SPI_NOR_flash Same remark here than on the first patch > > Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com> > --- > arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts > index 34e4a5a80136..fe39e96cee65 100644 > --- a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts > +++ b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts > @@ -177,3 +177,19 @@ > status = "okay"; > usb0_id_det-gpios = <&pio 6 12 GPIO_ACTIVE_HIGH>; /* PG12 */ > }; > + > +&spi0 { > + status = "okay"; > + > + flash@0 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "mxicy,mx25l1606e", "winbond,w25q128"; > + reg = <0>; > + spi-max-frequency = <40000000>; How do the other OPi Zero that doesn't have that SPI flash behave? > + > + partition@00000000 { > + reg = <0x00000000 0x200000>; /* 2Mb */ > + }; There's no need to create a first partition, this needs to be user-defined. Maxime
> > For more information see: > > - http://linux-sunxi.org/Orange_Pi_Zero#SPI_NOR_flash > > Same remark here than on the first patch Ok, I will provide a more detailed commit message w/o external references. > > +&spi0 { > > + status = "okay"; > > + > > + flash@0 { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + compatible = "mxicy,mx25l1606e", "winbond,w25q128"; > > + reg = <0>; > > + spi-max-frequency = <40000000>; > > How do the other OPi Zero that doesn't have that SPI flash behave? Hmmm. Good point. According to linux-sunxi.org docs SPI NOR flash was optional in the first production batch in Dec 2016. In later batches flash chip was pre-populated. However there are should be quite a few boards around which do not have flash. Does it make sense to set status to 'disabled' by default adding appropriate comment in the commit message ? > > + > > + partition@00000000 { > > + reg = <0x00000000 0x200000>; /* 2Mb */ > > + }; > > There's no need to create a first partition, this needs to be > user-defined. Ok, than it probably makes sense to drop it from dts. User-defined list of partitions can be passed via kernel command line. Thanks, Sergey
Hi Sergey, On Mon, May 22, 2017 at 11:30:12PM +0300, Sergey Matyukevich wrote: > > > For more information see: > > > - http://linux-sunxi.org/Orange_Pi_Zero#SPI_NOR_flash > > > > Same remark here than on the first patch > > Ok, I will provide a more detailed commit message > w/o external references. > > > > +&spi0 { > > > + status = "okay"; > > > + > > > + flash@0 { > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > + compatible = "mxicy,mx25l1606e", "winbond,w25q128"; > > > + reg = <0>; > > > + spi-max-frequency = <40000000>; > > > > How do the other OPi Zero that doesn't have that SPI flash behave? > > Hmmm. Good point. According to linux-sunxi.org docs SPI NOR flash > was optional in the first production batch in Dec 2016. In later > batches flash chip was pre-populated. However there are should > be quite a few boards around which do not have flash. > > Does it make sense to set status to 'disabled' by default adding > appropriate comment in the commit message ? If it's just that the driver fails to probe, we can live with that I guess. If not, then yes, that's a solution too. Thanks! Maxime
diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts index 34e4a5a80136..fe39e96cee65 100644 --- a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts +++ b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts @@ -177,3 +177,19 @@ status = "okay"; usb0_id_det-gpios = <&pio 6 12 GPIO_ACTIVE_HIGH>; /* PG12 */ }; + +&spi0 { + status = "okay"; + + flash@0 { + #address-cells = <1>; + #size-cells = <1>; + compatible = "mxicy,mx25l1606e", "winbond,w25q128"; + reg = <0>; + spi-max-frequency = <40000000>; + + partition@00000000 { + reg = <0x00000000 0x200000>; /* 2Mb */ + }; + }; +};
Enable SPI NOR on orange-pi-zero board. For more information see: - http://linux-sunxi.org/Orange_Pi_Zero#SPI_NOR_flash Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com> --- arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)