diff mbox

ARM64: dts: meson-gx: Fix sensors reporting from SCP

Message ID 20170605200350.1113-1-carlo@caione.org (mailing list archive)
State New, archived
Headers show

Commit Message

Carlo Caione June 5, 2017, 8:03 p.m. UTC
From: Carlo Caione <carlo@endlessm.com>

Switch to use the new compatible for the SCPI sensors so that the
sensor readings are reported using the correct scale.

Signed-off-by: Carlo Caione <carlo@endlessm.com>
---
 arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kevin Hilman June 5, 2017, 9:54 p.m. UTC | #1
Carlo Caione <carlo@caione.org> writes:

> From: Carlo Caione <carlo@endlessm.com>
>
> Switch to use the new compatible for the SCPI sensors so that the
> sensor readings are reported using the correct scale.
>
> Signed-off-by: Carlo Caione <carlo@endlessm.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index 436b875..3128fa5 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -200,7 +200,7 @@
>  		};
>  
>  		scpi_sensors: sensors {
> -			compatible = "arm,scpi-sensors";
> +			compatible = "amlogic,meson-gxbb-scpi-sensors";

Shouldn't this be:

			compatible = "amlogic,meson-gxbb-scpi-sensors", "arm,scpi-sensors";

For a safe fallback on kernels without the new compatible?

Kevin
Carlo Caione June 6, 2017, 6:20 a.m. UTC | #2
On Mon, Jun 5, 2017 at 11:54 PM, Kevin Hilman <khilman@baylibre.com> wrote:
> Carlo Caione <carlo@caione.org> writes:
>
>> From: Carlo Caione <carlo@endlessm.com>
>>
>> Switch to use the new compatible for the SCPI sensors so that the
>> sensor readings are reported using the correct scale.
>>
>> Signed-off-by: Carlo Caione <carlo@endlessm.com>
>> ---
>>  arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> index 436b875..3128fa5 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> @@ -200,7 +200,7 @@
>>               };
>>
>>               scpi_sensors: sensors {
>> -                     compatible = "arm,scpi-sensors";
>> +                     compatible = "amlogic,meson-gxbb-scpi-sensors";
>
> Shouldn't this be:
>
>                         compatible = "amlogic,meson-gxbb-scpi-sensors", "arm,scpi-sensors";
>
> For a safe fallback on kernels without the new compatible?

Yeah, it should.
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
index 436b875..3128fa5 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
@@ -200,7 +200,7 @@ 
 		};
 
 		scpi_sensors: sensors {
-			compatible = "arm,scpi-sensors";
+			compatible = "amlogic,meson-gxbb-scpi-sensors";
 			#thermal-sensor-cells = <1>;
 		};
 	};