| Message ID | 20170606133615.20747-1-antoine.tenart@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello, On Tue, 6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote: > The mvpp22_port_mii_set() function was added by 2697582144dd, but the > function directly returns without doing anything. This return was used > when debugging and wasn't removed before sending the patch. Fix this. > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> Please add: Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences") with this: Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> I am wondering if we shouldn't Cc: stable as well. I don't think we have seen issues on our side because U-Boot does the necessary initialization, but people using other bootloaders might have issues. Best regards, Thomas
Hello Thomas, On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote: > On Tue, 6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote: > > The mvpp22_port_mii_set() function was added by 2697582144dd, but the > > function directly returns without doing anything. This return was used > > when debugging and wasn't removed before sending the patch. Fix this. > > > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> > > Please add: > > Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences") > > with this: > > Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> OK, will do. > I am wondering if we shouldn't Cc: stable as well. I don't think we > have seen issues on our side because U-Boot does the necessary > initialization, but people using other bootloaders might have issues. Yes, that might be safer to cc stable. I'll do this as well. Thanks, Antoine
On 06/06/2017 06:51 AM, Antoine Tenart wrote: > Hello Thomas, > > On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote: >> On Tue, 6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote: >>> The mvpp22_port_mii_set() function was added by 2697582144dd, but the >>> function directly returns without doing anything. This return was used >>> when debugging and wasn't removed before sending the patch. Fix this. >>> >>> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> >> >> Please add: >> >> Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences") >> >> with this: >> >> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > OK, will do. > >> I am wondering if we shouldn't Cc: stable as well. I don't think we >> have seen issues on our side because U-Boot does the necessary >> initialization, but people using other bootloaders might have issues. > > Yes, that might be safer to cc stable. I'll do this as well. David queues network patches for stable provided that you submit those against his "net" tree [1] and there is an appropriate Fixes tag (which Thomas provided). [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.txt#n114
Hi Florian, On Tue, Jun 06, 2017 at 07:24:35AM -0700, Florian Fainelli wrote: > On 06/06/2017 06:51 AM, Antoine Tenart wrote: > > On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote: > > > >> I am wondering if we shouldn't Cc: stable as well. I don't think we > >> have seen issues on our side because U-Boot does the necessary > >> initialization, but people using other bootloaders might have issues. > > > > Yes, that might be safer to cc stable. I'll do this as well. > > David queues network patches for stable provided that you submit those > against his "net" tree [1] and there is an appropriate Fixes tag (which > Thomas provided). > > [1]: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.txt#n114 That's good to know! Thanks, Antoine
Hello! On 06/06/2017 04:36 PM, Antoine Tenart wrote: > The mvpp22_port_mii_set() function was added by 2697582144dd, but the Need to also specify the commit summary line enclosed in (""). > function directly returns without doing anything. This return was used > when debugging and wasn't removed before sending the patch. Fix this. > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> [...] MBR, Sergei
diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index 9b875d776b29..70bca2a6fb02 100644 --- a/drivers/net/ethernet/marvell/mvpp2.c +++ b/drivers/net/ethernet/marvell/mvpp2.c @@ -4186,8 +4186,6 @@ static void mvpp22_port_mii_set(struct mvpp2_port *port) { u32 val; - return; - /* Only GOP port 0 has an XLG MAC */ if (port->gop_id == 0) { val = readl(port->base + MVPP22_XLG_CTRL3_REG);
The mvpp22_port_mii_set() function was added by 2697582144dd, but the function directly returns without doing anything. This return was used when debugging and wasn't removed before sending the patch. Fix this. Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> --- drivers/net/ethernet/marvell/mvpp2.c | 2 -- 1 file changed, 2 deletions(-)