From patchwork Fri Jun 9 08:31:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Luebbe X-Patchwork-Id: 9777497 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4D72E60393 for ; Fri, 9 Jun 2017 08:32:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3B5A0285E8 for ; Fri, 9 Jun 2017 08:32:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2F8AD28609; Fri, 9 Jun 2017 08:32:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9C0AB285E8 for ; Fri, 9 Jun 2017 08:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=S7WAvu51JPFkRphyC4N3Abvh8C7/PnLg4ra+DynNWb8=; b=p9zmiLAT4TgYM8OUp/q82ydnLW kCp9VDgxM2zycxKFd3HnQdO/8/pzgzwBIOH5gOG/nuULOrFLTFlYCyscc6+GMfGDHquiP7/pnA9mm xnz9y+Zrd6bcOHtQrn+ehAZ7ODtVl0UdPGcChL4D25FvTSpnTYWTiYUWKR04nOkPJiLGfyLbEL791 J4UogkePGbLkJMXxQQ4IFyrZhDwbn9RRZ/n7OZUPBFqelEdkMDbi7cwc1vGtLHZCB6cZde5lLQNMm O01ZAdvTG+F4OCrRw+mWkYXJw/DDyS04lDaorzO2gO/iqugTflG3vykTe6rBKVws2kAd5T/2gIDet QNE/XIQw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dJFLV-0001Da-JE; Fri, 09 Jun 2017 08:32:41 +0000 Received: from merlin.infradead.org ([205.233.59.134]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dJFL5-0000gj-86 for linux-arm-kernel@bombadil.infradead.org; Fri, 09 Jun 2017 08:32:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IviHCpqokIhT6PPMQ2AUL2f65ysL6m03dAy8VhVe+Zc=; b=TJiyeHJTj23G4fzW2I6ETOe3q xH+lGe6v6pRDb5HkMAWzuyAFd12tMeBK9JJspmUjCuqRtl4xWgQRsMiHu9yJfjPCJoZCR56Wm8KUU 8oQWdXtTFBJ1QWccWk20wA+q8KLX2NMRO9XbM9W+jmRWgTZ891ifh3d0C+ToiSaDbLXKq5OE5/OHW Io/aCy709TS2CVgg8d7NHnxsf2hSG+u5Gw7S2Qm10SvZRHU4ELdXk9vx5n9pE+++sFQMpuS+hy65n x9lsa3Vv8MQ5FNYFOD6/oP+1R1TJX8dnCG9fQy5co55zdZOkSKBsCQioq5Q6DqrKQY6spoDhxz5OS DrghNj6sw==; Received: from metis.ext.4.pengutronix.de ([92.198.50.35]) by merlin.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dJFL3-0002ap-5Z for linux-arm-kernel@lists.infradead.org; Fri, 09 Jun 2017 08:32:14 +0000 Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dJFKg-0001ca-H7; Fri, 09 Jun 2017 10:31:50 +0200 Received: from jlu by dude.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1dJFKe-00022H-Cs; Fri, 09 Jun 2017 10:31:48 +0200 From: Jan Luebbe To: Chris Packham , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org Subject: [RFC PATCH 4/7] EDAC: Add devres helpers for edac_mc_alloc/edac_mc_add_mc(_with_groups) Date: Fri, 9 Jun 2017 10:31:20 +0200 Message-Id: <20170609083123.6539-5-jlu@pengutronix.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170609083123.6539-1-jlu@pengutronix.de> References: <20170609083123.6539-1-jlu@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: jlu@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170609_043213_390427_DAB58157 X-CRM114-Status: GOOD ( 13.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jan Luebbe , kernel@pengutronix.de MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP These helpers simplify error handling in the _probe functions and automate deallocation in the _remove functions. Signed-off-by: Jan Luebbe --- drivers/edac/edac_mc.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++ drivers/edac/edac_mc.h | 26 +++++++++++++++++++++++++ 2 files changed, 79 insertions(+) diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c index 480072139b7a..4d6759222592 100644 --- a/drivers/edac/edac_mc.c +++ b/drivers/edac/edac_mc.c @@ -517,6 +517,33 @@ void edac_mc_free(struct mem_ctl_info *mci) } EXPORT_SYMBOL_GPL(edac_mc_free); +/** + * devm_edac_mc_free() - Internal helper to call edac_mc_free from a devres + * action. + */ +static void devm_edac_mc_free(void *mci) +{ + edac_mc_free((struct mem_ctl_info *)mci); +} + +struct mem_ctl_info *devm_edac_mc_alloc(struct device *dev, + unsigned mc_num, + unsigned n_layers, + struct edac_mc_layer *layers, + unsigned sz_pvt) +{ + struct mem_ctl_info *mci; + mci = edac_mc_alloc(mc_num, n_layers, layers, sz_pvt); + if (!mci) + return mci; + + if (devm_add_action_or_reset(dev, devm_edac_mc_free, mci)) + return NULL; + + return mci; +} +EXPORT_SYMBOL_GPL(devm_edac_mc_alloc); + bool edac_has_mcs(void) { bool ret; @@ -828,6 +855,32 @@ struct mem_ctl_info *edac_mc_del_mc(struct device *dev) } EXPORT_SYMBOL_GPL(edac_mc_del_mc); +/** + * devm_edac_mc_del_mc() - Internal helper to call edac_mc_del_mc from a devres + * action. + */ +static void devm_edac_mc_del_mc(void *dev) +{ + edac_mc_del_mc((struct device *)dev); +} + +int devm_edac_mc_add_mc_with_groups(struct device *dev, + struct mem_ctl_info *mci, + const struct attribute_group **groups) +{ + int ret; + + ret = edac_mc_add_mc_with_groups(mci, groups); + if (ret) + return ret; + + if (devm_add_action_or_reset(dev, devm_edac_mc_del_mc, dev)) + return 1; + + return 0; +} +EXPORT_SYMBOL_GPL(devm_edac_mc_add_mc_with_groups); + static void edac_mc_scrub_block(unsigned long page, unsigned long offset, u32 size) { diff --git a/drivers/edac/edac_mc.h b/drivers/edac/edac_mc.h index 5357800e418d..c89f4301ed3f 100644 --- a/drivers/edac/edac_mc.h +++ b/drivers/edac/edac_mc.h @@ -149,6 +149,32 @@ extern int edac_mc_add_mc_with_groups(struct mem_ctl_info *mci, extern void edac_mc_free(struct mem_ctl_info *mci); /** + * devm_edac_mc_alloc() - Helper to call edac_mc_alloc() and register it for + * cleanup with devres. + * + * Returns: + * On success, return a pointer to struct mem_ctl_info pointer; + * %NULL otherwise + */ +struct mem_ctl_info *devm_edac_mc_alloc(struct device *dev, + unsigned mc_num, + unsigned n_layers, + struct edac_mc_layer *layers, + unsigned sz_pvt); + +/** + * devm_edac_mc_add_mc_with_groups() - Helper to call + * edac_mc_add_mc_with_groups() and register it for cleanup with devres. + * + * Returns: + * 0 on Success, or an error code on failure + */ +int devm_edac_mc_add_mc_with_groups(struct device *dev, + struct mem_ctl_info *mci, + const struct attribute_group **groups); +#define devm_edac_mc_add_mc(dev, mci) devm_edac_mc_add_mc_with_groups(dev, mci, NULL) + +/** * edac_has_mcs() - Check if any MCs have been allocated. * * Returns: