diff mbox

ARM: dts: meson8: fix the IR receiver pins

Message ID 20170609222039.25191-1-martin.blumenstingl@googlemail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Martin Blumenstingl June 9, 2017, 10:20 p.m. UTC
The IR receiver pins are currently defined in the CBUS pin-controller.
However the pins are in the AO region, which is controlled by the AOBUS
pin-controller. Move the pins to pinctrl_aobus so they can actually be
used.

Fixes: b60e1157d8fa ("ARM: dts: amlogic: Split pinctrl device for Meson8 / Meson8b")
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 arch/arm/boot/dts/meson8.dtsi | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comments

Neil Armstrong June 12, 2017, 7:38 a.m. UTC | #1
On 06/10/2017 12:20 AM, Martin Blumenstingl wrote:
> The IR receiver pins are currently defined in the CBUS pin-controller.
> However the pins are in the AO region, which is controlled by the AOBUS
> pin-controller. Move the pins to pinctrl_aobus so they can actually be
> used.
> 
> Fixes: b60e1157d8fa ("ARM: dts: amlogic: Split pinctrl device for Meson8 / Meson8b")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
>  arch/arm/boot/dts/meson8.dtsi | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
> index 9b0b3ddbb17e..e4f7357b4b31 100644
> --- a/arch/arm/boot/dts/meson8.dtsi
> +++ b/arch/arm/boot/dts/meson8.dtsi
> @@ -116,6 +116,13 @@
>  				function = "i2c_mst_ao";
>  			};
>  		};
> +
> +		ir_recv_pins: remote {
> +			mux {
> +				groups = "remote_input";
> +				function = "remote";
> +			};
> +		};
>  	};
>  };
>  
> @@ -151,13 +158,6 @@
>  			};
>  		};
>  
> -		ir_recv_pins: remote {
> -			mux {
> -				groups = "remote_input";
> -				function = "remote";
> -			};
> -		};
> -
>  		eth_pins: ethernet {
>  			mux {
>  				groups = "eth_tx_clk_50m", "eth_tx_en",
> 


Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Kevin Hilman June 16, 2017, 6:40 p.m. UTC | #2
Neil Armstrong <narmstrong@baylibre.com> writes:

> On 06/10/2017 12:20 AM, Martin Blumenstingl wrote:
>> The IR receiver pins are currently defined in the CBUS pin-controller.
>> However the pins are in the AO region, which is controlled by the AOBUS
>> pin-controller. Move the pins to pinctrl_aobus so they can actually be
>> used.
>> 
>> Fixes: b60e1157d8fa ("ARM: dts: amlogic: Split pinctrl device for Meson8 / Meson8b")
>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

[..]

> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

Applied to v4.13/dt with Neil's ack, will go in round 2 of pull requests
to arm-soc.

Kevin
diff mbox

Patch

diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
index 9b0b3ddbb17e..e4f7357b4b31 100644
--- a/arch/arm/boot/dts/meson8.dtsi
+++ b/arch/arm/boot/dts/meson8.dtsi
@@ -116,6 +116,13 @@ 
 				function = "i2c_mst_ao";
 			};
 		};
+
+		ir_recv_pins: remote {
+			mux {
+				groups = "remote_input";
+				function = "remote";
+			};
+		};
 	};
 };
 
@@ -151,13 +158,6 @@ 
 			};
 		};
 
-		ir_recv_pins: remote {
-			mux {
-				groups = "remote_input";
-				function = "remote";
-			};
-		};
-
 		eth_pins: ethernet {
 			mux {
 				groups = "eth_tx_clk_50m", "eth_tx_en",