| Message ID | 20170609231206.19798-2-sre@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Sebastian Reichel <sre@kernel.org> [170609 16:16]: > Add missing functional clock for DES3DES IP core. This is > documented in the TRM as CM_L4SEC_DES3DES_CLKCTRL. Tero care to ack? Also, see the other two hwmod patches in this series for your clkctrl changes. Regards, Tony > Signed-off-by: Sebastian Reichel <sre@kernel.org> > --- > arch/arm/boot/dts/omap44xx-clocks.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/omap44xx-clocks.dtsi b/arch/arm/boot/dts/omap44xx-clocks.dtsi > index 9573b37fbaa7..e997265460d4 100644 > --- a/arch/arm/boot/dts/omap44xx-clocks.dtsi > +++ b/arch/arm/boot/dts/omap44xx-clocks.dtsi > @@ -985,6 +985,14 @@ > reg = <0x15a8>; > }; > > + des_fck: des_fck@15b0 { > + #clock-cells = <0>; > + compatible = "ti,gate-clock"; > + clocks = <&l3_div_ck>; > + ti,bit-shift = <1>; > + reg = <0x15b0>; > + }; > + > dss_sys_clk: dss_sys_clk@1120 { > #clock-cells = <0>; > compatible = "ti,gate-clock"; > -- > 2.11.0 >
On 10/06/17 02:12, Sebastian Reichel wrote: > Add missing functional clock for DES3DES IP core. This is > documented in the TRM as CM_L4SEC_DES3DES_CLKCTRL. > > Signed-off-by: Sebastian Reichel <sre@kernel.org> > --- > arch/arm/boot/dts/omap44xx-clocks.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/omap44xx-clocks.dtsi b/arch/arm/boot/dts/omap44xx-clocks.dtsi > index 9573b37fbaa7..e997265460d4 100644 > --- a/arch/arm/boot/dts/omap44xx-clocks.dtsi > +++ b/arch/arm/boot/dts/omap44xx-clocks.dtsi > @@ -985,6 +985,14 @@ > reg = <0x15a8>; > }; > > + des_fck: des_fck@15b0 { > + #clock-cells = <0>; > + compatible = "ti,gate-clock"; > + clocks = <&l3_div_ck>; > + ti,bit-shift = <1>; > + reg = <0x15b0>; > + }; > + > dss_sys_clk: dss_sys_clk@1120 { > #clock-cells = <0>; > compatible = "ti,gate-clock"; > NAK. Don't add a duplicate entry for the hwmod clkctrl clock. You are adding control to the exact same bit via the hwmod data entry also causing a possibility for race condition. -Tero
diff --git a/arch/arm/boot/dts/omap44xx-clocks.dtsi b/arch/arm/boot/dts/omap44xx-clocks.dtsi index 9573b37fbaa7..e997265460d4 100644 --- a/arch/arm/boot/dts/omap44xx-clocks.dtsi +++ b/arch/arm/boot/dts/omap44xx-clocks.dtsi @@ -985,6 +985,14 @@ reg = <0x15a8>; }; + des_fck: des_fck@15b0 { + #clock-cells = <0>; + compatible = "ti,gate-clock"; + clocks = <&l3_div_ck>; + ti,bit-shift = <1>; + reg = <0x15b0>; + }; + dss_sys_clk: dss_sys_clk@1120 { #clock-cells = <0>; compatible = "ti,gate-clock";
Add missing functional clock for DES3DES IP core. This is documented in the TRM as CM_L4SEC_DES3DES_CLKCTRL. Signed-off-by: Sebastian Reichel <sre@kernel.org> --- arch/arm/boot/dts/omap44xx-clocks.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)