| Message ID | 20170614154911.14510-11-antoine.tenart@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jun 14, 2017 at 05:49:10PM +0200, Antoine Tenart wrote: > A new compatible for Marvell xMDIO interfaces was added into the Marvell > MDIO driver. Document this new compatible. > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> > --- > Documentation/devicetree/bindings/net/marvell-orion-mdio.txt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt > index ccdabdcc8618..b93a5b5a0472 100644 > --- a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt > +++ b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt > @@ -1,12 +1,12 @@ > * Marvell MDIO Ethernet Controller interface > > The Ethernet controllers of the Marvel Kirkwood, Dove, Orion5x, > -MV78xx0, Armada 370 and Armada XP have an identical unit that provides > -an interface with the MDIO bus. This driver handles this MDIO > -interface. > +MV78xx0, Armada 370, Armada XP, Armada 7k and Armada 8k have an > +identical unit that provides an interface with the MDIO bus or > +with the xMDIO bus. This driver handles these interfaces. Hi Antoine This patches is looking good now. One nit. The description above suggests Kirkwood, Dove, Orion5x, MV78xx0, Armada 370 and Armada XP all have xmdio. Maybe better wording would be: The Ethernet controllers of the Marvel Kirkwood, Dove, Orion5x, MV78xx0, Armada 370, Armada XP, Armada 7k and Armada 8k have an identical unit that provides an interface with the MDIO bus. Additionally, Armada 7k and Armada 8k has a second unit which provides an interface with the xMDIO bus. This driver handles these interfaces. Andrew
Hi Andrew, On Wed, Jun 14, 2017 at 06:35:37PM +0200, Andrew Lunn wrote: > On Wed, Jun 14, 2017 at 05:49:10PM +0200, Antoine Tenart wrote: > > > > The Ethernet controllers of the Marvel Kirkwood, Dove, Orion5x, > > -MV78xx0, Armada 370 and Armada XP have an identical unit that provides > > -an interface with the MDIO bus. This driver handles this MDIO > > -interface. > > +MV78xx0, Armada 370, Armada XP, Armada 7k and Armada 8k have an > > +identical unit that provides an interface with the MDIO bus or > > +with the xMDIO bus. This driver handles these interfaces. > > This patches is looking good now. One nit. The description above > suggests Kirkwood, Dove, Orion5x, MV78xx0, Armada 370 and Armada XP > all have xmdio. Maybe better wording would be: > > The Ethernet controllers of the Marvel Kirkwood, Dove, Orion5x, > MV78xx0, Armada 370, Armada XP, Armada 7k and Armada 8k have an > identical unit that provides an interface with the MDIO bus. > Additionally, Armada 7k and Armada 8k has a second unit which > provides an interface with the xMDIO bus. This driver handles > these interfaces. Agreed, your description is better :) I'll respin this patch only, if there is no other comment. Thanks! Antoine
> Agreed, your description is better :) > I'll respin this patch only, if there is no other comment. I assume these patches are going via net-next? Dave will not like a respin of a single patch. You need to post them all again. Andrew
Hi Andrew, On Thu, Jun 15, 2017 at 03:12:32PM +0200, Andrew Lunn wrote: > > Agreed, your description is better :) > > I'll respin this patch only, if there is no other comment. > > I assume these patches are going via net-next? Dave will not like a > respin of a single patch. You need to post them all again. OK, I'll respin the whole series with the net-next tag. Antoine
diff --git a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt index ccdabdcc8618..b93a5b5a0472 100644 --- a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt +++ b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt @@ -1,12 +1,12 @@ * Marvell MDIO Ethernet Controller interface The Ethernet controllers of the Marvel Kirkwood, Dove, Orion5x, -MV78xx0, Armada 370 and Armada XP have an identical unit that provides -an interface with the MDIO bus. This driver handles this MDIO -interface. +MV78xx0, Armada 370, Armada XP, Armada 7k and Armada 8k have an +identical unit that provides an interface with the MDIO bus or +with the xMDIO bus. This driver handles these interfaces. Required properties: -- compatible: "marvell,orion-mdio" +- compatible: "marvell,orion-mdio" or "marvell,xmdio" - reg: address and length of the MDIO registers. When an interrupt is not present, the length is the size of the SMI register (4 bytes) otherwise it must be 0x84 bytes to cover the interrupt control
A new compatible for Marvell xMDIO interfaces was added into the Marvell MDIO driver. Document this new compatible. Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> --- Documentation/devicetree/bindings/net/marvell-orion-mdio.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)