diff mbox

[v3] ARM: dts: da850-evm: drop VPIF endpoints

Message ID 20170615215730.28585-1-khilman@baylibre.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kevin Hilman June 15, 2017, 9:57 p.m. UTC
Drop the unused endpoints.  They should only be used when there is
an actual remote-endpoint connected.

Signed-off-by: Kevin Hilman <khilman@baylibre.com>
---
Since v2: actually CC DT maintainers
Since v1: attempt to Cc DT maintainers :(

 arch/arm/boot/dts/da850-evm.dts | 21 ---------------------
 1 file changed, 21 deletions(-)

Comments

Sekhar Nori July 17, 2017, 11 a.m. UTC | #1
Hi Kevin,

On Friday 16 June 2017 03:27 AM, Kevin Hilman wrote:
> Drop the unused endpoints.  They should only be used when there is
> an actual remote-endpoint connected.
> 
> Signed-off-by: Kevin Hilman <khilman@baylibre.com>

A similar patch is needed for da850-lcdk too. In fact with v4.13-rc1, 
without it, we get a warning splat that starts with:

WARNING: CPU: 0 PID: 129 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x5c/0x7c
sysfs: cannot create duplicate filename '/bus/platform/devices/vpif_capture'

I am adding this patch to fixes and would like to send this along with 
a similar LCDK patch (hopefully both for -rc2). While committing this I 
will add "unused" to subject line too.

Thanks,
Sekhar
Kevin Hilman July 17, 2017, 5:47 p.m. UTC | #2
Sekhar Nori <nsekhar@ti.com> writes:

> Hi Kevin,
>
> On Friday 16 June 2017 03:27 AM, Kevin Hilman wrote:
>> Drop the unused endpoints.  They should only be used when there is
>> an actual remote-endpoint connected.
>> 
>> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
>
> A similar patch is needed for da850-lcdk too. In fact with v4.13-rc1, 
> without it, we get a warning splat that starts with:
>
> WARNING: CPU: 0 PID: 129 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x5c/0x7c
> sysfs: cannot create duplicate filename '/bus/platform/devices/vpif_capture'
>
> I am adding this patch to fixes and would like to send this along with 
> a similar LCDK patch (hopefully both for -rc2). While committing this I 
> will add "unused" to subject line too.

Patch for LCDK sent, with "unused" added to the subject line.

Kevin
diff mbox

Patch

diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
index a423e8ebfb37..67e72bc72e80 100644
--- a/arch/arm/boot/dts/da850-evm.dts
+++ b/arch/arm/boot/dts/da850-evm.dts
@@ -301,25 +301,4 @@ 
 	pinctrl-names = "default";
 	pinctrl-0 = <&vpif_capture_pins>, <&vpif_display_pins>;
 	status = "okay";
-
-	/* VPIF capture port */
-	port@0 {
-		vpif_input_ch0: endpoint@0 {
-			reg = <0>;
-			bus-width = <8>;
-		};
-
-		vpif_input_ch1: endpoint@1 {
-			reg = <1>;
-			bus-width = <8>;
-			data-shift = <8>;
-		};
-	};
-
-	/* VPIF display port */
-	port@1 {
-		vpif_output_ch0: endpoint {
-			bus-width = <8>;
-		};
-	};
 };