diff mbox

drivers: perf: hisi: fix ptr_ret.cocci warnings

Message ID 20170628104218.GA32735@lkp-wsm-ep1 (mailing list archive)
State New, archived
Headers show

Commit Message

kernel test robot June 28, 2017, 10:42 a.m. UTC 
drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c:274:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: 2dd3bcc1c8a7 ("drivers: perf: hisi: Add support for HiSilicon SoC DDRC PMU driver")
CC: Shaokun Zhang <zhangshaokun@hisilicon.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 hisi_uncore_ddrc_pmu.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
diff mbox

Patch

--- a/drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c
+++ b/drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c
@@ -271,10 +271,7 @@  static int hisi_ddrc_pmu_init_data(struc
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	ddrc_pmu->base = devm_ioremap_resource(dev, res);
-	if (IS_ERR(ddrc_pmu->base))
-		return PTR_ERR(ddrc_pmu->base);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(ddrc_pmu->base);
 }
 
 static struct attribute *hisi_ddrc_pmu_format_attr[] = {