diff mbox

[RESEND] serial: imx: Enable RTSD only when needed

Message ID 20170628135936.30537-1-romain.perier@collabora.com (mailing list archive)
State New, archived
Headers show

Commit Message

Romain Perier June 28, 2017, 1:59 p.m. UTC 
From: Nandor Han <nandor.han@ge.com>

Currently, this IRQ is always enabled. Some devices might mux these pins
to other I/Os, like I2C. This could lead to spurious interrupts.

This commit makes this IRQ optional, by using the field have_rtscts.

Signed-off-by: Nandor Han <nandor.han@ge.com>
Signed-off-by: Romain Perier <romain.perier@collabora.com>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 drivers/tty/serial/imx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Uwe Kleine-König June 29, 2017, 6:18 p.m. UTC | #1 
Hello,

On Wed, Jun 28, 2017 at 03:59:36PM +0200, Romain Perier wrote:
> +	temp |= UCR1_RRDYEN | UCR1_UARTEN;
> +	if (sport->have_rtscts)
> +			temp |= UCR1_RTSDEN;

There is a tab too much.
 
>  	writel(temp, sport->port.membase + UCR1);

Other than that:
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
diff mbox

Patch

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 7327477..5437b34 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -1302,7 +1302,9 @@  static int imx_startup(struct uart_port *port)
 		imx_enable_dma(sport);
 
 	temp = readl(sport->port.membase + UCR1);
-	temp |= UCR1_RRDYEN | UCR1_RTSDEN | UCR1_UARTEN;
+	temp |= UCR1_RRDYEN | UCR1_UARTEN;
+	if (sport->have_rtscts)
+			temp |= UCR1_RTSDEN;
 
 	writel(temp, sport->port.membase + UCR1);