From patchwork Fri Jun 30 07:42:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 9818605 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EF9F66035F for ; Fri, 30 Jun 2017 07:43:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B502528520 for ; Fri, 30 Jun 2017 07:43:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A68A7285CC; Fri, 30 Jun 2017 07:43:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1E46F28520 for ; Fri, 30 Jun 2017 07:43:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From :Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=diElO/Fpc9uYlIo00/slRqBJ3g4ausx07rPzcJYkh5g=; b=k0yZNVyyf0yxzt I3I2KqT25huAH10kXyLEQ+hHLgXCUbyIdsC4pVsXoT/VzcXxxjup6r/YAyjH1pA4xtVYANDa+GroA RzYsv04XD7CbdVpX8NAcY+JkA+U94fhJ0XMoHJLKSABoZE7LThF+MhEDT/+xCbREJH9K8llMXQ9/8 Z6sWzTjsgxO/5dcSs0ruBHcOD8Ypf5nG4FJtbT7/rg38eQMPq+eGHO8Bnln9RzhFqFVGKpsLcJMpd wwESu+i9nObdqK8kk1dbzLYCZuC27pPYJhb/exxVpX/kjTasAWI7uH65lhCw4zOFK/MEUcCQ+Vyhd ON4o+BI0POjqk0xE8ltg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dQqaB-00039b-Rt; Fri, 30 Jun 2017 07:43:15 +0000 Received: from gateway33.websitewelcome.com ([192.185.146.195]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dQqa8-00032B-2Q for linux-arm-kernel@lists.infradead.org; Fri, 30 Jun 2017 07:43:13 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 31E8349E8AD for ; Fri, 30 Jun 2017 02:42:48 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id QqZgdWTIHZqNPQqZgd6Qwo; Fri, 30 Jun 2017 02:42:44 -0500 Received: from [189.152.189.231] (port=48646 helo=embeddedgus) by gator4166.hostgator.com with esmtpa (Exim 4.87) (envelope-from ) id 1dQqZj-0037eF-TG; Fri, 30 Jun 2017 02:42:47 -0500 Date: Fri, 30 Jun 2017 02:42:47 -0500 From: "Gustavo A. R. Silva" To: Vinod Koul , Dan Williams , Michal Simek , =?iso-8859-1?Q?S=F6ren?= Brinkmann Subject: [PATCH] dmaengine: zynqmp_dma: fix error return code in zynqmp_dma_chan_probe() Message-ID: <20170630074247.GA26153@embeddedgus> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.189.231 X-Exim-ID: 1dQqZj-0037eF-TG X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.189.231]:48646 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 31 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170630_004312_202278_54DBF490 X-CRM114-Status: UNSURE ( 8.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dmaengine@vger.kernel.org, "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Print error message and propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva Reviewed-by: Sören Brinkmann --- drivers/dma/xilinx/zynqmp_dma.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c index 6d221e5..5fa6d0d 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -996,8 +996,11 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev, zynqmp_dma_init(chan); chan->irq = platform_get_irq(pdev, 0); - if (chan->irq < 0) - return -ENXIO; + if (chan->irq < 0) { + dev_err(&pdev->dev, "failed to get IRQ: %d\n", chan->irq); + return chan->irq; + } + err = devm_request_irq(&pdev->dev, chan->irq, zynqmp_dma_irq_handler, 0, "zynqmp-dma", chan); if (err)