diff mbox

[v2] ARM: dts: imx7d-sdb: Set VLDO4 outpt to 2.8V for MIPI CSI/DSI

Message ID 20170701073911.7338-1-mindentropy@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

mindentropy July 1, 2017, 7:39 a.m. UTC
From: Gautam Bhat <mindentropy@gmail.com>

 * According to mx7sabresd schematics the MIPI CSI/DSI voltage rails
   should be 2.8V but the voltage provided is a maximum of 3.3V and
   minimum of 1.8V. Providing such a higher voltage might damage the
   peripherals and violates the schematic settings.

Signed-off-by: Gautam Bhat <mindentropy@gmail.com>
---
Changes in v2:
 - Added subject line according to convention

 arch/arm/boot/dts/imx7d-sdb.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Fabio Estevam July 1, 2017, 12:41 p.m. UTC | #1
On Sat, Jul 1, 2017 at 4:39 AM, mindentropy <mindentropy@gmail.com> wrote:
> From: Gautam Bhat <mindentropy@gmail.com>
>
>  * According to mx7sabresd schematics the MIPI CSI/DSI voltage rails
>    should be 2.8V but the voltage provided is a maximum of 3.3V and
>    minimum of 1.8V. Providing such a higher voltage might damage the
>    peripherals and violates the schematic settings.
>
> Signed-off-by: Gautam Bhat <mindentropy@gmail.com>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Shawn Guo July 12, 2017, 7:18 a.m. UTC | #2
On Sat, Jul 01, 2017 at 01:09:11PM +0530, mindentropy wrote:
> From: Gautam Bhat <mindentropy@gmail.com>
> 
>  * According to mx7sabresd schematics the MIPI CSI/DSI voltage rails
>    should be 2.8V but the voltage provided is a maximum of 3.3V and
>    minimum of 1.8V. Providing such a higher voltage might damage the
>    peripherals and violates the schematic settings.

For such single paragraph commit log, the bullet and indentation are not
really necessary.  I edited it a bit and apply the patch.  Thanks.

Shawn

> 
> Signed-off-by: Gautam Bhat <mindentropy@gmail.com>
> ---
> Changes in v2:
>  - Added subject line according to convention
> 
>  arch/arm/boot/dts/imx7d-sdb.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
> index 5be01a1bf840..1da1f97ec342 100644
> --- a/arch/arm/boot/dts/imx7d-sdb.dts
> +++ b/arch/arm/boot/dts/imx7d-sdb.dts
> @@ -262,8 +262,8 @@
>  			};
>  
>  			vgen6_reg: vldo4 {
> -				regulator-min-microvolt = <1800000>;
> -				regulator-max-microvolt = <3300000>;
> +				regulator-min-microvolt = <2800000>;
> +				regulator-max-microvolt = <2800000>;
>  				regulator-always-on;
>  			};
>  		};
> -- 
> 2.11.0
>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
index 5be01a1bf840..1da1f97ec342 100644
--- a/arch/arm/boot/dts/imx7d-sdb.dts
+++ b/arch/arm/boot/dts/imx7d-sdb.dts
@@ -262,8 +262,8 @@ 
 			};
 
 			vgen6_reg: vldo4 {
-				regulator-min-microvolt = <1800000>;
-				regulator-max-microvolt = <3300000>;
+				regulator-min-microvolt = <2800000>;
+				regulator-max-microvolt = <2800000>;
 				regulator-always-on;
 			};
 		};