diff mbox

ARM: sunxi: h3/h5: Correct emac register size

Message ID 20170706085334.25380-1-clabbe.montjoie@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Corentin Labbe July 6, 2017, 8:53 a.m. UTC 
The datasheet said that emac register size is 0x1000 not 0x104

Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
 arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Maxime Ripard July 6, 2017, 6:52 p.m. UTC | #1 
On Thu, Jul 06, 2017 at 10:53:34AM +0200, Corentin Labbe wrote:
> The datasheet said that emac register size is 0x1000 not 0x104
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
>  arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> index 716e7d668dec..5a57b67c9b77 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -406,7 +406,7 @@
>  		emac: ethernet@1c30000 {
>  			compatible = "allwinner,sun8i-h3-emac";
>  			syscon = <&syscon>;
> -			reg = <0x01c30000 0x104>;
> +			reg = <0x01c30000 0x1000>;

The size is actually 0x10000. I fixed it and applied.

The A64 DTSI has the same issue, can you send a patch for this one
too?

Thanks,
Maxime
Corentin Labbe July 6, 2017, 7:05 p.m. UTC | #2 
On Thu, Jul 06, 2017 at 08:52:05PM +0200, Maxime Ripard wrote:
> On Thu, Jul 06, 2017 at 10:53:34AM +0200, Corentin Labbe wrote:
> > The datasheet said that emac register size is 0x1000 not 0x104
> > 
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > ---
> >  arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > index 716e7d668dec..5a57b67c9b77 100644
> > --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > @@ -406,7 +406,7 @@
> >  		emac: ethernet@1c30000 {
> >  			compatible = "allwinner,sun8i-h3-emac";
> >  			syscon = <&syscon>;
> > -			reg = <0x01c30000 0x104>;
> > +			reg = <0x01c30000 0x1000>;
> 
> The size is actually 0x10000. I fixed it and applied.
> 
> The A64 DTSI has the same issue, can you send a patch for this one
> too?
> 

Yes
Thanks for the fixing
Regards
Corentin Labbe
diff mbox

Patch

diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index 716e7d668dec..5a57b67c9b77 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -406,7 +406,7 @@ 
 		emac: ethernet@1c30000 {
 			compatible = "allwinner,sun8i-h3-emac";
 			syscon = <&syscon>;
-			reg = <0x01c30000 0x104>;
+			reg = <0x01c30000 0x1000>;
 			interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "macirq";
 			resets = <&ccu RST_BUS_EMAC>;