| Message ID | 20170706142822.20296-2-icenowy@aosc.io (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Thu, Jul 06, 2017 at 10:28:21PM +0800, Icenowy Zheng wrote: > The PH16 pin has a function with mux id 0x5, which is the DET pin of the > "sim" (smart card reader) IP block. > > This function is missing both in the old A10 and A20 drivers, so it's > not found during the merge of these two drivers. > > Add it to the driver. As we now merged A20 pinctrl driver to the A10 > one, we need to only fix the A10 driver now. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> I'm not sure what you mean there. It's not mentionned in the A10 datasheet, and neither in the A20. Where did you get that info from? Maxime
在 2017-07-07 04:46，Maxime Ripard 写道： > Hi, > > On Thu, Jul 06, 2017 at 10:28:21PM +0800, Icenowy Zheng wrote: >> The PH16 pin has a function with mux id 0x5, which is the DET pin of >> the >> "sim" (smart card reader) IP block. >> >> This function is missing both in the old A10 and A20 drivers, so it's >> not found during the merge of these two drivers. >> >> Add it to the driver. As we now merged A20 pinctrl driver to the A10 >> one, we need to only fix the A10 driver now. >> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > > I'm not sure what you mean there. It's not mentionned in the A10 > datasheet, and neither in the A20. Where did you get that info from? It's mentioned in all newest datasheets: "A10 Datasheet V1.70.pdf" and "A20 Datasheet V1.41 20131230.pdf". > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com
On Fri, Jul 07, 2017 at 07:21:19AM +0800, icenowy@aosc.io wrote: > 在 2017-07-07 04:46，Maxime Ripard 写道： > > Hi, > > > > On Thu, Jul 06, 2017 at 10:28:21PM +0800, Icenowy Zheng wrote: > > > The PH16 pin has a function with mux id 0x5, which is the DET pin of > > > the > > > "sim" (smart card reader) IP block. > > > > > > This function is missing both in the old A10 and A20 drivers, so it's > > > not found during the merge of these two drivers. > > > > > > Add it to the driver. As we now merged A20 pinctrl driver to the A10 > > > one, we need to only fix the A10 driver now. > > > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > > > > I'm not sure what you mean there. It's not mentionned in the A10 > > datasheet, and neither in the A20. Where did you get that info from? > > It's mentioned in all newest datasheets: "A10 Datasheet V1.70.pdf" and > "A20 Datasheet V1.41 20131230.pdf". Mentionning that in the commit log would be great. Where did you find those? Maxime
于 2017年7月10日 GMT+08:00 下午4:44:00, Maxime Ripard <maxime.ripard@free-electrons.com> 写到: >On Fri, Jul 07, 2017 at 07:21:19AM +0800, icenowy@aosc.io wrote: >> 在 2017-07-07 04:46，Maxime Ripard 写道： >> > Hi, >> > >> > On Thu, Jul 06, 2017 at 10:28:21PM +0800, Icenowy Zheng wrote: >> > > The PH16 pin has a function with mux id 0x5, which is the DET pin >of >> > > the >> > > "sim" (smart card reader) IP block. >> > > >> > > This function is missing both in the old A10 and A20 drivers, so >it's >> > > not found during the merge of these two drivers. >> > > >> > > Add it to the driver. As we now merged A20 pinctrl driver to the >A10 >> > > one, we need to only fix the A10 driver now. >> > > >> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> >> > >> > I'm not sure what you mean there. It's not mentionned in the A10 >> > datasheet, and neither in the A20. Where did you get that info >from? >> >> It's mentioned in all newest datasheets: "A10 Datasheet V1.70.pdf" >and >> "A20 Datasheet V1.41 20131230.pdf". > >Mentionning that in the commit log would be great. > >Where did you find those? dl.linux-sunxi.org > >Maxime
diff --git a/drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c b/drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c index 159580c04b14..47a392bc73c8 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c +++ b/drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c @@ -918,6 +918,7 @@ static const struct sunxi_desc_pin sun4i_a10_pins[] = { SUNXI_FUNCTION_VARIANT(0x3, "emac", /* ETXD1 */ PINCTRL_SUN7I_A20), SUNXI_FUNCTION(0x4, "keypad"), /* IN6 */ + SUNXI_FUNCTION(0x5, "sim"), /* DET */ SUNXI_FUNCTION_IRQ(0x6, 16), /* EINT16 */ SUNXI_FUNCTION(0x7, "csi1")), /* D16 */ SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 17),
The PH16 pin has a function with mux id 0x5, which is the DET pin of the "sim" (smart card reader) IP block. This function is missing both in the old A10 and A20 drivers, so it's not found during the merge of these two drivers. Add it to the driver. As we now merged A20 pinctrl driver to the A10 one, we need to only fix the A10 driver now. Signed-off-by: Icenowy Zheng <icenowy@aosc.io> --- drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c | 1 + 1 file changed, 1 insertion(+)