From patchwork Thu Jul 6 20:51:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 9829021 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 59681602BD for ; Thu, 6 Jul 2017 21:06:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 475D6284B5 for ; Thu, 6 Jul 2017 21:06:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3C03B2851E; Thu, 6 Jul 2017 21:06:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C24CE284B5 for ; Thu, 6 Jul 2017 21:06:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From :Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=jvtkiS1DsgqQcHZQNxk1S2gr4eKWuObu9FnMjeDDUyo=; b=MmWxo33E8TmJUv JFTs5lH6H7pN3Ym7GRk2hevD/obgBYJ5c6RrU1S3Wb9q2eT9luogljCc08oNG3ugm56JNBVESEF0b 9rm510Y7ybS4IlOPsflPuSRe8AnLLGwUwVGq6pInpYNDOK7sCM7WrXws06VTphtIMoKo6Lh70nGLO 16SZelbLTiOWaGgk5mnurBvKNKaDjhNME1TGiO6fFmSkE6tagWbFoqUET0Zje98NbBXVZS9oRFLPp n2gC0ZVH7JrhaosKPWBFrtY3RHRf034P9cYCql2Cg4FcaUdAk0QGBC7s/3aLR3bHBZ9XuOzon78Z2 zUh3iwBdM38KCxddPjdQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dTDz5-0003Pt-6J; Thu, 06 Jul 2017 21:06:47 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dTDz2-0003JW-MY for linux-arm-kernel@bombadil.infradead.org; Thu, 06 Jul 2017 21:06:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OZBcWYzisU0w9BbWPOGnU31eF2/bsLek80Ol0SiO9Bg=; b=rFK7TbBicp6nZm5FE2kpWs9iDx y913hnin+bCU1uwRvh9lTp+uIrEb/EdaBz95PfPDSpUrV6fZva+jcmYpeidfiiTOewUWVr89FcdTK pKuFjgNFPSyhQzfAVy4KyekZaaCDHnnPQinflUfox+aJDSSyG6nKdyLjwFFitzwPzCrIY33Mf3XEt R2vPPevUwNd23CQJotCh386HnzRtYY5Zpu/jcBtN+qw0IykVTAKPq8f+jid0aLjX1OjjM9W2NViTs sDiEaYGxXFjo91fMcfycZELqs9QsS6735lZO+D4Ck6JYb5temIxCgdBE4d03vN5tL4DiAZZXZ26/7 hzTZCbMA==; Received: from gateway24.websitewelcome.com ([192.185.51.202]) by casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dTDkz-0004P5-1K for linux-arm-kernel@lists.infradead.org; Thu, 06 Jul 2017 20:52:14 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 0A431A5A56 for ; Thu, 6 Jul 2017 15:51:28 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id TDkldEFEueE2kTDkldKKKu; Thu, 06 Jul 2017 15:51:59 -0500 Received: from [189.152.196.165] (port=37104 helo=embeddedgus) by gator4166.hostgator.com with esmtpa (Exim 4.87) (envelope-from ) id 1dTDkF-0009zb-N2; Thu, 06 Jul 2017 15:51:27 -0500 Date: Thu, 6 Jul 2017 15:51:27 -0500 From: "Gustavo A. R. Silva" To: Rick Chang , Bin Liu , Mauro Carvalho Chehab , Matthias Brugger Subject: [PATCH] mediatek: constify vb2_ops structure Message-ID: <20170706205127.GA20926@embeddedgus> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.196.165 X-Exim-ID: 1dTDkF-0009zb-N2 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.196.165]:37104 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 45 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170706_215213_176841_A8BA888B X-CRM114-Status: UNSURE ( 8.99 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Gustavo A. R. Silva" , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also. This issue was detected using Coccinelle and the following semantic patch: @r disable optional_qualifier@ identifier i; position p; @@ static struct vb2_ops i@p = { ... }; @ok@ identifier r.i; struct vb2_queue e; position p; @@ e.ops = &i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct vb2_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct vb2_ops i = { ... }; Signed-off-by: Gustavo A. R. Silva --- drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c index 451a540..f17a86b 100644 --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c @@ -756,7 +756,7 @@ static void mtk_jpeg_stop_streaming(struct vb2_queue *q) pm_runtime_put_sync(ctx->jpeg->dev); } -static struct vb2_ops mtk_jpeg_qops = { +static const struct vb2_ops mtk_jpeg_qops = { .queue_setup = mtk_jpeg_queue_setup, .buf_prepare = mtk_jpeg_buf_prepare, .buf_queue = mtk_jpeg_buf_queue,