From patchwork Mon Jul 17 14:27:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoffer Dall X-Patchwork-Id: 9845299 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3865760386 for ; Mon, 17 Jul 2017 14:30:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2AAAC2851D for ; Mon, 17 Jul 2017 14:30:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1FA4428544; Mon, 17 Jul 2017 14:30:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 92CCE27E63 for ; Mon, 17 Jul 2017 14:30:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Bb1KW0Apk/PZPSjp9tCyuCiXibe5SQHnQPThn14ZQ5Q=; b=jxt/4GcgmrXdGplwYa4VaBMvvT t+YOBbMWfY1sxR7SUgUpAF4RmEf09WtHi8GZJ2yA26qGwL/GOSFwii3Hp3cFVopUUeyzNEreVBI5h Hp3Zy0h6fvTtMgNh7+fNMejqWs2fTxTrRhp+iyvCGVQfP1XCIwk7LKnOaMLwnY+WJ1fO9L32HcSZN hVWh11BKnr7pXjzllRy2D6QumxVwWB3NX0yqKiG4Y7WB6IXWwSY/38P8S+koRwj+14pP+XM3wQkpl dOBhQMuql/ZhoZ/iB9IdgtBfalUuLmuMkr8c7hLYlgpgsuqgYTXf66CdnJaF99j4ZdW67pkQjP65k LEaOr5bQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dX72O-0004n5-7W; Mon, 17 Jul 2017 14:30:16 +0000 Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dX706-0001Lx-BS for linux-arm-kernel@lists.infradead.org; Mon, 17 Jul 2017 14:28:07 +0000 Received: by mail-wm0-x229.google.com with SMTP id f67so85836994wmh.1 for ; Mon, 17 Jul 2017 07:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4L8aGWDQgZ6zv4YbjeOOTPMy4xroEftTbpacQlflBYw=; b=cPpg9ZM1gIG8ODlWzBTRddTV9J/X3I7udzZHVQxd5hCg1Hhe0iasWFZ90uK6sZoEjO +8hWm/nshMQAAXjJZMAYJCAV4+KtBH+1zvORxThv343X/xTz8aGzjA0pN10qbCIBq7fj gkiM3krTLi4A5ClmD8mtSNRVDUQ0ywqq+VNM4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4L8aGWDQgZ6zv4YbjeOOTPMy4xroEftTbpacQlflBYw=; b=Xt2Px97TP535IuSFz3xnBHO4Z4vdavupi5N2loQw/n4ea30q/SbRQH3onJTLH2Wxqv ODAujJZz5Az2aPMHmlFj/AFSS+x+qiMRzmp0a3bOIY+RtJIEJbbLnEoKHB8zXs5Rtwuj +saoF2zoAhB2gHEKtUwOtjFyd+X0DJ6XCUzqoInCTuO+Bzm3RbNJdDdh6g9P4ng/Q3Qg ToTzrLjdvbj2Zhpiv20pe0wWQwlbazzL88AFtB1CgdYGAw2SKJXY/2ksex0oBPCik/0C ezJeBT9kKEFhHADQQJ2pCwMBOLGOV48Az2ubyH1QZd944Lo8yTgvgNxt9Uc3oKgAmnca rrvA== X-Gm-Message-State: AIVw111z1fa5UV7sULT/g28HX2QpKjf1WgXa5CSyhsLg70XtG2Rlix5o iF5NYCz+Hbe2VQcY X-Received: by 10.80.149.133 with SMTP id w5mr17471200eda.82.1500301652070; Mon, 17 Jul 2017 07:27:32 -0700 (PDT) Received: from localhost.localdomain (xd93ddc2d.cust.hiper.dk. [217.61.220.45]) by smtp.gmail.com with ESMTPSA id b30sm9428952edd.6.2017.07.17.07.27.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 17 Jul 2017 07:27:31 -0700 (PDT) From: Christoffer Dall To: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH v2 07/19] KVM: arm/arm64: Rename soft timer to bg_timer Date: Mon, 17 Jul 2017 16:27:06 +0200 Message-Id: <20170717142718.13853-8-cdall@linaro.org> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170717142718.13853-1-cdall@linaro.org> References: <20170717142718.13853-1-cdall@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170717_072755_020293_55223ED3 X-CRM114-Status: GOOD ( 14.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier , Christoffer Dall , kvm@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP As we are about to introduce a separate hrtimer for the physical timer, call this timer bg_timer, because we refer to this timer as the background timer in the code and comments elsewhere. Signed-off-by: Christoffer Dall --- include/kvm/arm_arch_timer.h | 3 +-- virt/kvm/arm/arch_timer.c | 22 +++++++++++----------- 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/include/kvm/arm_arch_timer.h b/include/kvm/arm_arch_timer.h index f0053f8..dcbb2e1 100644 --- a/include/kvm/arm_arch_timer.h +++ b/include/kvm/arm_arch_timer.h @@ -43,8 +43,7 @@ struct arch_timer_cpu { struct arch_timer_context ptimer; /* Background timer used when the guest is not running */ - struct hrtimer timer; - + struct hrtimer bg_timer; /* Work queued with the above timer expires */ struct work_struct expired; diff --git a/virt/kvm/arm/arch_timer.c b/virt/kvm/arm/arch_timer.c index 871d8ae..c2e8326 100644 --- a/virt/kvm/arm/arch_timer.c +++ b/virt/kvm/arm/arch_timer.c @@ -56,7 +56,7 @@ u64 kvm_phys_timer_read(void) return timecounter->cc->read(timecounter->cc); } -static bool soft_timer_is_armed(struct arch_timer_cpu *timer) +static bool bg_timer_is_armed(struct arch_timer_cpu *timer) { return timer->armed; } @@ -154,13 +154,13 @@ static u64 kvm_timer_earliest_exp(struct kvm_vcpu *vcpu) return min(min_virt, min_phys); } -static enum hrtimer_restart kvm_timer_expire(struct hrtimer *hrt) +static enum hrtimer_restart kvm_bg_timer_expire(struct hrtimer *hrt) { struct arch_timer_cpu *timer; struct kvm_vcpu *vcpu; u64 ns; - timer = container_of(hrt, struct arch_timer_cpu, timer); + timer = container_of(hrt, struct arch_timer_cpu, bg_timer); vcpu = container_of(timer, struct kvm_vcpu, arch.timer_cpu); /* @@ -267,7 +267,7 @@ static void kvm_timer_emulate(struct kvm_vcpu *vcpu, return; /* The timer has not yet expired, schedule a background timer */ - soft_timer_start(&timer->timer, kvm_timer_compute_delta(timer_ctx)); + soft_timer_start(&timer->bg_timer, kvm_timer_compute_delta(timer_ctx)); } /* @@ -281,7 +281,7 @@ void kvm_timer_schedule(struct kvm_vcpu *vcpu) struct arch_timer_context *vtimer = vcpu_vtimer(vcpu); struct arch_timer_context *ptimer = vcpu_ptimer(vcpu); - BUG_ON(soft_timer_is_armed(timer)); + BUG_ON(bg_timer_is_armed(timer)); /* * No need to schedule a background timer if any guest timer has @@ -303,14 +303,14 @@ void kvm_timer_schedule(struct kvm_vcpu *vcpu) * Set the earliest expiration time among the guest timers. */ timer->armed = true; - soft_timer_start(&timer->timer, kvm_timer_earliest_exp(vcpu)); + soft_timer_start(&timer->bg_timer, kvm_timer_earliest_exp(vcpu)); } void kvm_timer_unschedule(struct kvm_vcpu *vcpu) { struct arch_timer_cpu *timer = &vcpu->arch.timer_cpu; - soft_timer_cancel(&timer->timer, &timer->expired); + soft_timer_cancel(&timer->bg_timer, &timer->expired); timer->armed = false; } @@ -447,7 +447,7 @@ void kvm_timer_sync_hwstate(struct kvm_vcpu *vcpu) * This is to cancel the background timer for the physical timer * emulation if it is set. */ - soft_timer_cancel(&timer->timer, &timer->expired); + soft_timer_cancel(&timer->bg_timer, &timer->expired); /* * The guest could have modified the timer registers or the timer @@ -504,8 +504,8 @@ void kvm_timer_vcpu_init(struct kvm_vcpu *vcpu) vcpu_ptimer(vcpu)->cntvoff = 0; INIT_WORK(&timer->expired, kvm_timer_inject_irq_work); - hrtimer_init(&timer->timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS); - timer->timer.function = kvm_timer_expire; + hrtimer_init(&timer->bg_timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS); + timer->bg_timer.function = kvm_bg_timer_expire; vtimer->irq.irq = default_vtimer_irq.irq; ptimer->irq.irq = default_ptimer_irq.irq; @@ -614,7 +614,7 @@ void kvm_timer_vcpu_terminate(struct kvm_vcpu *vcpu) struct arch_timer_cpu *timer = &vcpu->arch.timer_cpu; struct arch_timer_context *vtimer = vcpu_vtimer(vcpu); - soft_timer_cancel(&timer->timer, &timer->expired); + soft_timer_cancel(&timer->bg_timer, &timer->expired); kvm_vgic_unmap_phys_irq(vcpu, vtimer->irq.irq); }