| Message ID | 20170801145416.61854-1-icenowy@aosc.io (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Aug 1, 2017 at 10:54 PM, Icenowy Zheng <icenowy@aosc.io> wrote: > The V3s pin controller doesn't have the bank 0 (starts at address > 0x200), which is like A33. However, this is not workarounded when was not worked around "Work around" is a verb phrase. "Workaround" is a noun. > developing the driver, which makes IRQ not working. broke the IRQs. > > Fix the IRQ bank base. > > Fixes: 56d9e4a76039 ("pinctrl: sunxi: add driver for V3s SoC") > Cc: stable@vger.kernel.org > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> Confirmed this is the same thing we saw on A33. The fix is the same. Apart from the typo / grammar errors above, Reviewed-by: Chen-Yu Tsai <wens@csie.org>
在 2017-08-04 10:23，Chen-Yu Tsai 写道： > On Tue, Aug 1, 2017 at 10:54 PM, Icenowy Zheng <icenowy@aosc.io> wrote: >> The V3s pin controller doesn't have the bank 0 (starts at address >> 0x200), which is like A33. However, this is not workarounded when > > was not worked around > > "Work around" is a verb phrase. "Workaround" is a noun. > >> developing the driver, which makes IRQ not working. > > broke the IRQs. > >> >> Fix the IRQ bank base. >> >> Fixes: 56d9e4a76039 ("pinctrl: sunxi: add driver for V3s SoC") >> Cc: stable@vger.kernel.org >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > > Confirmed this is the same thing we saw on A33. > The fix is the same. > > Apart from the typo / grammar errors above, > > Reviewed-by: Chen-Yu Tsai <wens@csie.org> Should I send a v2 now to fix the language errors? > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Tue, Aug 1, 2017 at 4:54 PM, Icenowy Zheng <icenowy@aosc.io> wrote: > The V3s pin controller doesn't have the bank 0 (starts at address > 0x200), which is like A33. However, this is not workarounded when > developing the driver, which makes IRQ not working. > > Fix the IRQ bank base. > > Fixes: 56d9e4a76039 ("pinctrl: sunxi: add driver for V3s SoC") > Cc: stable@vger.kernel.org This patch only applies on the devel branch so I don't see why it is tagged for stable. > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> Patch applied. Yours, Linus Walleij
在 2017-08-07 21:09，Linus Walleij 写道： > On Tue, Aug 1, 2017 at 4:54 PM, Icenowy Zheng <icenowy@aosc.io> wrote: > >> The V3s pin controller doesn't have the bank 0 (starts at address >> 0x200), which is like A33. However, this is not workarounded when >> developing the driver, which makes IRQ not working. >> >> Fix the IRQ bank base. >> >> Fixes: 56d9e4a76039 ("pinctrl: sunxi: add driver for V3s SoC") >> Cc: stable@vger.kernel.org > > This patch only applies on the devel branch so I don't see why it is > tagged > for stable. I can apply it on v4.12 tag. The V3s pinctrl driver is introduced in 4.11. > >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > > Patch applied. > > Yours, > Linus Walleij > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c b/drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c index c86d3c42a905..496ba34e1f5f 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c @@ -297,6 +297,7 @@ static const struct sunxi_pinctrl_desc sun8i_v3s_pinctrl_data = { .pins = sun8i_v3s_pins, .npins = ARRAY_SIZE(sun8i_v3s_pins), .irq_banks = 2, + .irq_bank_base = 1, .irq_read_needs_mux = true };
The V3s pin controller doesn't have the bank 0 (starts at address 0x200), which is like A33. However, this is not workarounded when developing the driver, which makes IRQ not working. Fix the IRQ bank base. Fixes: 56d9e4a76039 ("pinctrl: sunxi: add driver for V3s SoC") Cc: stable@vger.kernel.org Signed-off-by: Icenowy Zheng <icenowy@aosc.io> --- drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c | 1 + 1 file changed, 1 insertion(+)