From patchwork Sun Aug 6 13:38:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 9883789 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5514460360 for ; Sun, 6 Aug 2017 13:47:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 45B1A2844B for ; Sun, 6 Aug 2017 13:47:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3A33D2854A; Sun, 6 Aug 2017 13:47:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EFD3C28544 for ; Sun, 6 Aug 2017 13:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Subject:To:Date:Message-Id :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=lwb8j/lR61EbvJaE6OMf9Fmx9pzpLOrciZR3FqfAzbI=; b=k4YZQPnKNWQy4V gxA9cqXO9yhSXeNhkQpyk6WX7mPCEfES/3rPEb25leHYC/Zr2djivSH3AKP/e+44rP/ibsVtUC6xF gWqUJ8jY5ZoRjgiyD4och9YwiP00MEmGnf7dHAFPTyMbmpWz7oj9awXUcTe1LcwS7CnQrsaovOs2j wNt/PhZnHxV+FUwfwlmGJ/L/kODZmjDxbHM9UJAzvRglVtpy6VPo8qH77AF2200bk2mR4b01HiFHe s8n7dL/hYgMiS8ShjCSBxpdHRaIq+cysKTJ/sVZxztStWK6f+r8niMXtW/IyFa8yp0bHxudUM0zlA FeYds4YKOjCL79IYhUNw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1deLtY-00050r-C9; Sun, 06 Aug 2017 13:47:04 +0000 Received: from mail-lf0-x234.google.com ([2a00:1450:4010:c07::234]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1deLsa-0004E6-Ql for linux-arm-kernel@lists.infradead.org; Sun, 06 Aug 2017 13:46:07 +0000 Received: by mail-lf0-x234.google.com with SMTP id d17so21528999lfe.0 for ; Sun, 06 Aug 2017 06:45:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:user-agent:date:to:cc:subject:mime-version :content-disposition; bh=VoJRQi0oZ6DtS08++MkzTz6cizRBKvFXJ5ZjSGPJfN0=; b=nwQOgx34XEogCjHu+hsNgPzbwgZ2D46OkiaA+GN/yY/eGvQ3k4Rr5bKaTvuM6Kn2Dg aPyr9y/Gah03WDqAbNQ6LT25NOBhL47V5Qdnb/kskLz/WDYJUeXlJwzvwdheZ0t4qq7b WIaJ6kVaF8M6lvC0r8gtX2ErBC7uiAZY8Pp9Yp56b6d0I7ay8ghhy6aWlCMGGK7E76R3 HYtCKnXG6fjZgGLP5n7UlHtzjwit+Mw7659WCKVrUattxzPcTDWNQHvcgz4owUOg+T4g P32dZwHODkxXzjX0c9McyEtBOpP/lNSsHzM3ZKGsUOb0SM1z9bd7FmgFCCtkn0LkT9ka A1Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:user-agent:date:to:cc:subject :mime-version:content-disposition; bh=VoJRQi0oZ6DtS08++MkzTz6cizRBKvFXJ5ZjSGPJfN0=; b=m94C5MA+mf8A1oAiuXnG4UhK6SXHlXUaD+jK0NoeL/JwyXEl2KscbzBC+GEyoddJ92 2pE7UgsBhBuFaHDLtqWkCCySmHNn6kIIMbWR1qZ4id85bhbfjx+xrbyxYWuRFuRtiqz7 FN9aLzj1GTMAGhGFWrlKUVkZ+ON4N4H2V36LHnM8UPnGRfzk4JHuu7Zis1Ixsvs/sETN y4VFTKGxQzAnPfMQr1ZN0o01Vrt6ZhfmkhPrwni9DYT05L0NRDsTMLgtbCzJgqZKvz01 5OaWZcPsrf1g+iJXFlbDIFm65Ftl1Oj5QymRaWWOi9vWAU5zep5uFzQwP1Jynlis3gyd Cizg== X-Gm-Message-State: AHYfb5i+7ep+DzOw212/w5i4xgH4X5I6LyPQ5mJhNjDvUi7sp6yG83jI 1Q37buIGgjnUvhCy X-Received: by 10.25.205.84 with SMTP id d81mr3207731lfg.255.1502027142891; Sun, 06 Aug 2017 06:45:42 -0700 (PDT) Received: from wasted.cogentembedded.com ([31.173.85.122]) by smtp.gmail.com with ESMTPSA id e7sm2452771ljb.84.2017.08.06.06.45.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Aug 2017 06:45:41 -0700 (PDT) From: Sergei Shtylyov X-Google-Original-From: "Sergei Shtylyov" Received: by wasted.cogentembedded.com (sSMTP sendmail emulation); Sun, 06 Aug 2017 16:45:39 +0300 Message-Id: <20170806134539.404484506@cogentembedded.com> User-Agent: quilt/0.64 Date: Sun, 06 Aug 2017 16:38:50 +0300 To: Rajendra Nayak , Paul Walmsley , Tony Lindgren , linux-omap@vger.kernel.org Subject: [PATCH 1/2] ARM: OMAP3: PRM: fix of_irq_get() result check MIME-Version: 1.0 Content-Disposition: inline; filename=ARM-OMAP3-PRM-fix-of_irq_get-result-check.patch X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170806_064605_110677_41C11F24 X-CRM114-Status: GOOD ( 10.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Russell King , Sergei Shtylyov , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP of_irq_get() may return 0 as well as a nagative error number on failure (and never on success), however omap3xxx_prm_late_init() regards 0 as a valid IRQ -- fix this. Fixes: 1e037794f7f ("ARM: OMAP3+: PRM: register interrupt information from DT") Signed-off-by: Sergei Shtylyov --- arch/arm/mach-omap2/prm3xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-omap/arch/arm/mach-omap2/prm3xxx.c =================================================================== --- linux-omap.orig/arch/arm/mach-omap2/prm3xxx.c +++ linux-omap/arch/arm/mach-omap2/prm3xxx.c @@ -706,7 +706,7 @@ static int omap3xxx_prm_late_init(void) np = of_find_matching_node(NULL, omap3_prm_dt_match_table); if (np) { irq_num = of_irq_get(np, 0); - if (irq_num >= 0) + if (irq_num > 0) omap3_prcm_irq_setup.irq = irq_num; } }