Message ID | 20170806151710.416156875@cogentembedded.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 408A660360 for <patchwork-linux-arm@patchwork.kernel.org>; Sun, 6 Aug 2017 15:18:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 316E5285E6 for <patchwork-linux-arm@patchwork.kernel.org>; Sun, 6 Aug 2017 15:18:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 26591285EA; Sun, 6 Aug 2017 15:18:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 680A9285E8 for <patchwork-linux-arm@patchwork.kernel.org>; Sun, 6 Aug 2017 15:18:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Subject:To:Date:Message-Id :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Bu1kFeQOb75bhG5ReRQcuCZ651ijlpvXWixEaaE+L/k=; b=BCUEox/Xx9DJ4j dTIQhMQ26pVYTlvBqjiJZMW+Ok9An2iY0cB+xFOaG3MuIDRu+pyKbWfr3Oe6GTjFiibZpk2xVriKD a5LduMIKy+gxFfhYJ2zaTdl3Z85LnGN955O4noO3wPvr5INoD42H07cdh+jW5OWcTzBn2ixjSSVEM NH7uwMyrgmgg+YSEAe73A6QheeRZWPUynYRag+/zp5OknR9UJoYeOHIZWKHqIi1MVSdGspv1U9mgn bJrhACeoq9hUaluy+AEWswPlcmYZr3r5IG9WRpqsaBiKleRExobBZHqK890FIQat/Nu7+sEH/y72M sf9QMx5hw6al94Rv8hZQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1deNJR-00005p-Cv; Sun, 06 Aug 2017 15:17:53 +0000 Received: from mail-lf0-x229.google.com ([2a00:1450:4010:c07::229]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1deNJA-00088g-1Q for linux-arm-kernel@lists.infradead.org; Sun, 06 Aug 2017 15:17:38 +0000 Received: by mail-lf0-x229.google.com with SMTP id y15so21776066lfd.5 for <linux-arm-kernel@lists.infradead.org>; Sun, 06 Aug 2017 08:17:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:user-agent:date:to:cc:subject:mime-version :content-disposition; bh=wjfbAgrLrRMEm3glsnb7hx/H+pZ89Rr1zIGtIF+VPco=; b=NbWBO+wfNReMyFSL+099HNRAzl/+RXzyY/6Q/k0JbMY5EtZtjtM/xZvq0xGfChrlmu /WV9a5drktdTgLqnR7yn1/O565YMT7elUiT5Y8tIfzWzsvFAxiiaizpa1226msE6RncY fbpPwLRo4trAH+myNJOn7BHvD+RTk4AUuLgDk8/IHMvqhEBy5iG6jBGSbi6763irU+Sm GJJaZNbHjxGNSpPgF+AjavF8DLBzDkFfa+kQF31PUHD/m26FHgr7mtrFxNN6jjJeEJJP Fq/O8mjKqvvy1emtTVEQ6S7Hf29No53ph7Ic8FrozGCOgGaMqdPEzgBO9rfJ4A9gVsw7 NA/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:user-agent:date:to:cc:subject :mime-version:content-disposition; bh=wjfbAgrLrRMEm3glsnb7hx/H+pZ89Rr1zIGtIF+VPco=; b=e8dmxNg0W2q6df74t8UTHZeP6MC/QqrlbV50tBXoJlrWTghgtL45VqdKhlZCrugOES Iqi4sIPTcC30pDkl03G97BUPujgv8/SQEgtrs84QwunkpATS2SKQ6wHfMc7F0nwaxKSU Si/7zF/A7EVN4UkWpE2GtCoDDLOdnS/eqHceNGBroPDaJzfIL6x4G/IX6EAtUBlrJq0m 3uZW99og64rLDaR7n3NVLI70oQ5OgpHth9jOflWdOz0C0UYlh0clTsrytX6X7l25RdXe KboVcQMnPFBaxuE8Ni9/myITveYGA+fZjQSxWce3hdRmCDanRDiXvPJpyLYuom/dCHuE BJXA== X-Gm-Message-State: AHYfb5iTFf+GUExGnQKcHuCZ4apczmYwa9A73oZ4LBupGWqmCaMdSQ+A o9cr9Qd9oSnjeGRN X-Received: by 10.25.15.74 with SMTP id e71mr2253689lfi.13.1502032634012; Sun, 06 Aug 2017 08:17:14 -0700 (PDT) Received: from wasted.cogentembedded.com ([31.173.85.122]) by smtp.gmail.com with ESMTPSA id g84sm480867lfl.61.2017.08.06.08.17.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Aug 2017 08:17:13 -0700 (PDT) From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> X-Google-Original-From: "Sergei Shtylyov" <headless@wasted.cogentembedded.com> Received: by wasted.cogentembedded.com (sSMTP sendmail emulation); Sun, 06 Aug 2017 18:17:10 +0300 Message-Id: <20170806151710.416156875@cogentembedded.com> User-Agent: quilt/0.64 Date: Sun, 06 Aug 2017 18:14:21 +0300 To: Rajendra Nayak <rnayak@codeaurora.org>, Paul Walmsley <paul@pwsan.com>, Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org Subject: [PATCH v2 1/2] ARM: OMAP3+: PRM: fix of_irq_get() result check MIME-Version: 1.0 Content-Disposition: inline; filename=ARM-OMAP3-PRM-fix-of_irq_get-result-check-v2.patch X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170806_081736_378388_6030591C X-CRM114-Status: GOOD ( 10.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: Russell King <linux@arm.linux.org.uk>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP |
Index: linux-omap/arch/arm/mach-omap2/prm3xxx.c =================================================================== --- linux-omap.orig/arch/arm/mach-omap2/prm3xxx.c +++ linux-omap/arch/arm/mach-omap2/prm3xxx.c @@ -706,7 +706,7 @@ static int omap3xxx_prm_late_init(void) np = of_find_matching_node(NULL, omap3_prm_dt_match_table); if (np) { irq_num = of_irq_get(np, 0); - if (irq_num >= 0) + if (irq_num > 0) omap3_prcm_irq_setup.irq = irq_num; }
of_irq_get() may return 0 as well as a nagative error number on failure (and never on success), however omap3xxx_prm_late_init() regards 0 as a valid IRQ -- fix this. Fixes: 1e037794f7f ("ARM: OMAP3+: PRM: register interrupt information from DT") Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- Changes ion version 2: - rebased to the 'omap-for-v4.13/fixes' branch; - fixed Rajendra Nayak's email; - added + to OMAP3 in the patch subject. arch/arm/mach-omap2/prm3xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)